bda8d93ba9
Summary: It's always annoying to find a header does not include its own dependencies and only works when included after other includes. This change adds `make check-headers` which validates that each header can be included at the top of a file. Some headers are excluded e.g. because of platform or external dependencies. rocksdb_namespace.h had to be re-worked slightly to enable checking for failure to include it. (ROCKSDB_NAMESPACE is a valid namespace name.) Fixes mostly involve adding and cleaning up #includes, but for FileTraceWriter, a constructor was out-of-lined to make a forward declaration sufficient. This check is not currently run with `make check` but is added to CircleCI build-linux-unity since that one is already relatively fast. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8893 Test Plan: existing tests and resolving issues detected by new check Reviewed By: mrambacher Differential Revision: D30823300 Pulled By: pdillinger fbshipit-source-id: 9fff223944994c83c105e2e6496d24845dc8e572
29 lines
923 B
C++
29 lines
923 B
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cstddef>
|
|
#include <unordered_map>
|
|
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// Helper methods to estimate memroy usage by std containers.
|
|
|
|
template <class Key, class Value, class Hash>
|
|
size_t ApproximateMemoryUsage(
|
|
const std::unordered_map<Key, Value, Hash>& umap) {
|
|
using Map = std::unordered_map<Key, Value, Hash>;
|
|
return sizeof(umap) +
|
|
// Size of all items plus a next pointer for each item.
|
|
(sizeof(typename Map::value_type) + sizeof(void*)) * umap.size() +
|
|
// Size of hash buckets.
|
|
umap.bucket_count() * sizeof(void*);
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|