andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2ed9b9206b
rocksdb/util
History
Yueh-Hsuan Chiang 4860bfdeab Fixed a dependency issue of ThreadLocalPtr 
Summary:
When a child thread that uses ThreadLocalPtr, ThreadLocalPtr::OnThreadExit
will be called when that child thread is destroyed.  However,
OnThreadExit will try to access a static singleton of ThreadLocalPtr,
which will be destroyed when the main thread exit.  As a result,
when a child thread that uses ThreadLocalPtr exits AFTER the main thread
exits, illegal memory access will occur.

This diff includes a test that reproduce this legacy bug.

    ==2095206==ERROR: AddressSanitizer: heap-use-after-free on address
    0x608000007fa0 at pc 0x959b79 bp 0x7f5fa7426b60 sp 0x7f5fa7426b58
    READ of size 8 at 0x608000007fa0 thread T1

This patch fix this issue by having the thread local mutex never be deleted
(but will leak small piece of memory at the end.)   The patch also describe
a better solution (thread_local) in the comment that requires gcc 4.8.1 and
in latest clang as a future work once we agree to move toward gcc 4.8.

Test Plan:
COMPILE_WITH_ASAN=1 make thread_local_test -j32
./thread_local_test --gtest_filter="*MainThreadDiesFirst"

Reviewers: anthony, hermanlee4, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D53013
2016-02-10 16:56:21 -08:00
..
aligned_buffer.h Address code review comments both GH and internal 2015-09-11 17:36:48 -07:00
allocator.h Enforce write buffer memory limit across column families 2014-12-02 12:09:20 -08:00
arena_test.cc Enable MS compiler warning c4244. 2015-12-11 16:47:34 -08:00
arena.cc support for concurrent adds to memtable 2015-12-25 11:03:40 -08:00
arena.h support for concurrent adds to memtable 2015-12-25 11:03:40 -08:00
auto_roll_logger_test.cc Clean and expose CreateLoggerFromOptions 2015-10-29 18:07:37 -07:00
auto_roll_logger.cc Clean and expose CreateLoggerFromOptions 2015-10-29 18:07:37 -07:00
auto_roll_logger.h Clean and expose CreateLoggerFromOptions 2015-10-29 18:07:37 -07:00
autovector_test.cc Make autovector_test runnable in ROCKSDB_LITE 2015-06-18 15:58:00 -07:00
autovector.h "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
bloom_test.cc Skipped tests shouldn't be failures 2015-09-15 18:10:36 -07:00
bloom.cc fix typos 2015-04-25 18:14:27 +09:00
build_version.h build: do not relink every single binary just for a timestamp 2015-02-19 13:11:10 -08:00
cache_bench.cc Fix -Wshadow for tools 2014-11-07 15:04:30 -08:00
cache_test.cc Fix memory leaks in PinnedUsageTest 2015-06-19 09:43:08 -07:00
cache.cc Replace malloc with new for LRU Cache Handle 2015-12-04 15:12:07 -08:00
channel.h Multithreaded backup and restore in BackupEngineImpl 2015-07-02 11:35:51 -07:00
coding_test.cc rocksdb: switch to gtest 2015-03-17 14:08:00 -07:00
coding.cc Removing BitStream* functions 2014-08-19 06:48:21 -07:00
coding.h Enable C4267 warning 2015-11-24 16:33:09 +03:00
compaction_job_stats_impl.cc Fix compaction_job_stats under ROCKSDB_LITE 2015-09-14 12:42:06 -07:00
comparator.cc Added Equal method to Comparator interface 2015-09-08 15:30:49 -07:00
compression.h ZSTD to use CompressionOptions.level 2015-12-16 16:58:04 -08:00
concurrent_arena.cc Fix CLANG errors introduced by 7d87f02799 2015-12-28 10:00:58 -08:00
concurrent_arena.h Not generating "__attribute__((__unused__))" for padding fields if it is not CLANG 2015-12-28 18:37:23 -08:00
crc32c_test.cc rocksdb: switch to gtest 2015-03-17 14:08:00 -07:00
crc32c.cc fix an unused function compiler warning in crc32c in 32-bit mode 2016-01-07 13:27:20 -05:00
crc32c.h Print Fast CRC32 support information in DB LOG 2015-07-10 17:59:36 -07:00
db_info_dumper.cc Change the log level of DB start-up log from Warn to Header. 2015-09-16 11:31:45 -07:00
db_info_dumper.h Fix iOS compile with -Wshorten-64-to-32 2014-11-13 14:39:30 -05:00
delete_scheduler_impl.cc Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
delete_scheduler_impl.h Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
delete_scheduler_test.cc Clear SyncPoint Trace in DeleteSchedulerTests 2015-09-28 15:58:50 -07:00
dynamic_bloom_test.cc Fix DynamicBloomTest.concurrent_with_perf to pass TSAN 2015-12-29 16:28:45 -08:00
dynamic_bloom.cc support for concurrent adds to memtable 2015-12-25 11:03:40 -08:00
dynamic_bloom.h support for concurrent adds to memtable 2015-12-25 11:03:40 -08:00
env_hdfs.cc more foramt 2015-12-26 19:52:35 -08:00
env_posix.cc Fixed a dependency issue of ThreadLocalPtr 2016-02-10 16:56:21 -08:00
env_test.cc Make use of portable uint64_t type to make possible file access 2015-11-10 17:03:42 -08:00
env.cc Lint everything 2015-11-16 12:56:21 -08:00
event_logger_test.cc rocksdb: switch to gtest 2015-03-17 14:08:00 -07:00
event_logger.cc Allow EventLogger to directly log from a JSONWriter. 2015-05-21 15:39:30 -07:00
event_logger.h Added JSON manifest dump option to ldb command 2015-07-17 10:07:40 -07:00
file_reader_writer_test.cc Make use of portable uint64_t type to make possible file access 2015-11-10 17:03:42 -08:00
file_reader_writer.cc Make use of portable uint64_t type to make possible file access 2015-11-10 17:03:42 -08:00
file_reader_writer.h Make use of portable uint64_t type to make possible file access 2015-11-10 17:03:42 -08:00
file_util.cc Fix iOS build 2015-10-19 13:40:44 -07:00
file_util.h Rate limit deletes issued by DestroyDB 2015-08-19 15:02:17 -07:00
filelock_test.cc rocksdb: switch to gtest 2015-03-17 14:08:00 -07:00
filter_policy.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
hash.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
hash.h Introduce GetThreadList API 2014-11-20 10:49:32 -08:00
heap_test.cc Fix compile on Mac 2015-07-16 11:22:21 +02:00
heap.h Replace std::priority_queue in MergingIterator with custom heap, take 2 2015-07-15 03:34:40 -07:00
histogram_test.cc fix typos 2015-04-25 18:14:27 +09:00
histogram.cc Enable MS compiler warning c4244. 2015-12-11 16:47:34 -08:00
histogram.h "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
instrumented_mutex.cc Make perf_context.db_mutex_lock_nanos and db_condition_wait_nanos only measures DB Mutex 2015-10-13 10:41:48 -07:00
instrumented_mutex.h Add a counter for collecting the wait time on db mutex. 2015-02-04 21:39:45 -08:00
io_posix.cc Make use of portable uint64_t type to make possible file access 2015-11-10 17:03:42 -08:00
io_posix.h Make use of portable uint64_t type to make possible file access 2015-11-10 17:03:42 -08:00
iostats_context_imp.h Removed two unused macros in iostats_context 2015-06-12 10:45:02 -07:00
iostats_context.cc Add options.compaction_measure_io_stats to print write I/O stats in compactions 2015-08-13 16:52:26 -07:00
kv_map.h Moving memtable related files from util to a new directory memtable 2015-10-16 14:10:33 -07:00
log_buffer.cc Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00
log_buffer.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
log_write_bench.cc Fix more gflag namespace issues 2014-05-09 08:41:02 -07:00
logging.cc Make the benchmark scripts configurable and add tests 2015-03-30 11:28:25 -07:00
logging.h Make the benchmark scripts configurable and add tests 2015-03-30 11:28:25 -07:00
memenv_test.cc Improved FileExists API 2015-07-20 17:20:40 -07:00
memenv.cc Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
mock_env_test.cc Improved FileExists API 2015-07-20 17:20:40 -07:00
mock_env.cc Refactor to support file_reader_writer on Windows. 2015-09-11 09:57:02 -07:00
mock_env.h [Cleanup] Remove RandomRWFile 2015-08-12 10:18:59 -07:00
murmurhash.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
murmurhash.h Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
mutable_cf_options.cc Deprecate options.soft_rate_limit and add options.soft_pending_compaction_bytes_limit 2015-12-09 18:22:45 -08:00
mutable_cf_options.h Deprecate options.soft_rate_limit and add options.soft_pending_compaction_bytes_limit 2015-12-09 18:22:45 -08:00
mutexlock.h support for concurrent adds to memtable 2015-12-25 11:03:40 -08:00
options_builder.cc Enable C4267 warning 2015-11-24 16:33:09 +03:00
options_helper.cc Deprecate options.soft_rate_limit and add options.soft_pending_compaction_bytes_limit 2015-12-09 18:22:45 -08:00
options_helper.h Deprecate options.soft_rate_limit and add options.soft_pending_compaction_bytes_limit 2015-12-09 18:22:45 -08:00
options_parser.cc Resubmit the fix for a race condition in persisting options 2015-12-08 17:01:02 -08:00
options_parser.h Add OptionsUtil::LoadOptionsFromFile() API 2015-11-12 06:52:43 -08:00
options_sanity_check.cc Add OptionsSanityCheckLevel 2015-11-04 18:53:30 -08:00
options_sanity_check.h Fix clang compile error under Linux 2015-12-24 12:41:40 +08:00
options_test.cc Merge pull request #839 from SherlockNoMad/memtableOption 2015-11-17 17:09:49 -08:00
options.cc support for concurrent adds to memtable 2015-12-25 11:03:40 -08:00
perf_context_imp.h Make perf_context.db_mutex_lock_nanos and db_condition_wait_nanos only measures DB Mutex 2015-10-13 10:41:48 -07:00
perf_context.cc bloom hit/miss stats for SST and memtable 2015-10-07 11:23:20 -07:00
perf_level_imp.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
perf_level.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
perf_step_timer.h more times in perf_context and iostats_context 2015-06-02 02:07:58 -07:00
posix_logger.h Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00
random.cc remove constexpr from util/random.h for MSVC compat 2015-11-10 16:41:23 -08:00
random.h remove constexpr from util/random.h for MSVC compat 2015-11-10 16:41:23 -08:00
rate_limiter_test.cc Enable dynamic changing of rate limiter's bytes_per_second 2015-03-18 15:35:55 -07:00
rate_limiter.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
rate_limiter.h Fix another rebase problems. 2015-12-11 17:33:40 -08:00
skiplistrep.cc Explictly fail when memtable doesn't support concurrent insert 2016-02-05 15:35:37 -08:00
slice_transform_test.cc rocksdb: switch to gtest 2015-03-17 14:08:00 -07:00
slice.cc [RocksDB Options] Support more options in RocksDBOptionParser for sanity check. 2015-10-02 15:35:32 -07:00
statistics.cc Relax memory order for faster tickers 2015-09-15 10:52:00 -07:00
statistics.h Align statistics 2016-01-13 14:53:23 -08:00
status_message.cc Support static Status messages 2015-08-31 16:13:29 -07:00
status.cc Support static Status messages 2015-08-31 16:13:29 -07:00
stop_watch.h Compaction filter on merge operands 2015-10-07 09:30:03 -07:00
string_util.cc Clean up StringSplit 2014-11-21 11:05:28 -05:00
string_util.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
sync_point.cc crash_test to trigger some less frequent crash point more frequently 2015-10-27 12:06:06 -07:00
sync_point.h fix typos in comments 2015-12-11 01:54:48 +09:00
testharness.cc rocksdb: print status error message when (ASSERT|EXPECT)_OK fails 2015-03-19 17:32:43 -07:00
testharness.h rocksdb: print status error message when (ASSERT|EXPECT)_OK fails 2015-03-19 17:32:43 -07:00
testutil.cc Add OptionsUtil::LoadOptionsFromFile() API 2015-11-12 06:52:43 -08:00
testutil.h plain table reader: non-mmap mode to keep two recent buffers 2016-01-08 10:53:57 -08:00
thread_list_test.cc rocksdb: switch to gtest 2015-03-17 14:08:00 -07:00
thread_local_test.cc Fixed a dependency issue of ThreadLocalPtr 2016-02-10 16:56:21 -08:00
thread_local.cc Fixed a dependency issue of ThreadLocalPtr 2016-02-10 16:56:21 -08:00
thread_local.h Fixed a dependency issue of ThreadLocalPtr 2016-02-10 16:56:21 -08:00
thread_operation.h Deprecate CompactionFilterV2 2015-07-17 18:59:11 +02:00
thread_posix.cc Running manual compactions in parallel with other automatic or manual compactions in restricted cases 2015-12-14 11:20:34 -08:00
thread_posix.h Running manual compactions in parallel with other automatic or manual compactions in restricted cases 2015-12-14 11:20:34 -08:00
thread_status_impl.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
thread_status_updater_debug.cc Allow GetThreadList() to indicate a thread is doing Compaction. 2015-01-13 00:04:08 -08:00
thread_status_updater.cc Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
thread_status_updater.h Windows Port from Microsoft 2015-07-01 16:13:56 -07:00
thread_status_util_debug.cc Fix bad performance in debug mode 2015-04-13 15:58:45 -07:00
thread_status_util.cc Only initialize the ThreadStatusData when necessary. 2015-06-17 11:21:18 -07:00
thread_status_util.h Only initialize the ThreadStatusData when necessary. 2015-06-17 11:21:18 -07:00
vectorrep.cc Moving memtable related files from util to a new directory memtable 2015-10-16 14:10:33 -07:00
xfunc.cc New amalgamation target 2015-10-01 08:29:31 +13:00
xfunc.h Merge the latest changes from github/master 2015-07-02 17:23:41 -07:00
xxhash.cc Enable MS Warning C4804 : unsafe use of type 'bool' in operation 2015-11-18 16:23:19 -08:00
xxhash.h Prevent xxhash symbols from polluting global namespace 2015-03-12 12:07:10 -07:00