andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
Siying Dong 2f1a3a4d74 Refactor ReadBlockContents() 
Summary:
Divide ReadBlockContents() to multiple sub-functions. Maintaining the input and intermediate data in a new class BlockFetcher.
I hope in general it makes the code easier to maintain.
Another motivation to do it is to clearly divide the logic before file reading and after file reading. The refactor will help us evaluate how can we make I/O async in the future.
Closes https://github.com/facebook/rocksdb/pull/3244

Differential Revision: D6520983

Pulled By: siying

fbshipit-source-id: 338d90bc0338472d46be7a7682028dc9114b12e9
2017-12-11 15:27:32 -08:00
..
adaptive_table_factory.cc
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
adaptive_table_factory.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
block_based_filter_block_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_based_filter_block.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
block_based_filter_block.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_based_table_builder.cc
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
block_based_table_builder.h
TableProperty::oldest_key_time defaults to 0
2017-10-27 15:00:05 -07:00
block_based_table_factory.cc
Support for block_cache num_shards and other config via option string.
2017-11-28 10:48:53 -08:00
block_based_table_factory.h
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
block_based_table_reader.cc
Refactor ReadBlockContents()
2017-12-11 15:27:32 -08:00
block_based_table_reader.h
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
block_builder.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_fetcher.cc
Refactor ReadBlockContents()
2017-12-11 15:27:32 -08:00
block_fetcher.h
Refactor ReadBlockContents()
2017-12-11 15:27:32 -08:00
block_prefix_index.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_prefix_index.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_test.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
block.cc
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
block.h
table/block.h: change memset
2017-07-17 10:41:56 -07:00
bloom_block.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
bloom_block.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cleanable_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
cuckoo_table_builder_test.cc
allow nullptr Slice only as sentinel
2017-08-23 10:56:06 -07:00
cuckoo_table_builder.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
cuckoo_table_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cuckoo_table_factory.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
cuckoo_table_factory.h
Replace dynamic_cast<>
2017-07-28 16:27:16 -07:00
cuckoo_table_reader_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
cuckoo_table_reader.cc
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
cuckoo_table_reader.h
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
filter_block.h
Extend pin_l0 to filter partitions
2017-08-23 07:56:08 -07:00
flush_block_policy.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
format.cc
Refactor ReadBlockContents()
2017-12-11 15:27:32 -08:00
format.h
Refactor ReadBlockContents()
2017-12-11 15:27:32 -08:00
full_filter_bits_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
full_filter_block_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
full_filter_block.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
full_filter_block.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
get_context.cc
Add ValueType::kTypeBlobIndex
2017-10-03 09:11:23 -07:00
get_context.h
Add ValueType::kTypeBlobIndex
2017-10-03 09:11:23 -07:00
index_builder.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
index_builder.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
internal_iterator.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
iter_heap.h
Make InternalKeyComparator final and directly use it in merging iterator
2017-09-11 12:04:21 -07:00
iterator_wrapper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
iterator.cc
PinnableSlice move assignment
2017-10-12 18:28:24 -07:00
merger_test.cc
Make InternalKeyComparator final and directly use it in merging iterator
2017-09-11 12:04:21 -07:00
merging_iterator.cc
fix DBImpl::NewInternalIterator super-version leak on failure
2017-10-11 14:57:43 -07:00
merging_iterator.h
fix DBImpl::NewInternalIterator super-version leak on failure
2017-10-11 14:57:43 -07:00
meta_blocks.cc
Refactor ReadBlockContents()
2017-12-11 15:27:32 -08:00
meta_blocks.h
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
mock_table.cc
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
mock_table.h
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
partitioned_filter_block_test.cc
Fix calculating filter partition target size
2017-11-20 13:26:57 -08:00
partitioned_filter_block.cc
Extend pin_l0 to filter partitions
2017-08-23 07:56:08 -07:00
partitioned_filter_block.h
Extend pin_l0 to filter partitions
2017-08-23 07:56:08 -07:00
persistent_cache_helper.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
persistent_cache_helper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
persistent_cache_options.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_builder.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_factory.cc
Allow upgrades from nullptr to some merge operator
2017-10-04 09:57:23 -07:00
plain_table_factory.h
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
plain_table_index.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_index.h
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
plain_table_key_coding.cc
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
plain_table_key_coding.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_reader.cc
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
plain_table_reader.h
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
scoped_arena_iterator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
sst_file_writer_collectors.h
Revert "comment out unused parameters"
2017-07-21 18:26:26 -07:00
sst_file_writer.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
table_builder.h
TableProperty::oldest_key_time defaults to 0
2017-10-27 15:00:05 -07:00
table_properties_internal.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
table_properties.cc
Add DB::Properties::kEstimateOldestKeyTime
2017-10-23 15:27:27 -07:00
table_reader_bench.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
table_reader.h
add VerifyChecksum() to db.h
2017-08-09 15:58:13 -07:00
table_test.cc
Preload l0 index partitions
2017-08-18 10:56:20 -07:00
two_level_iterator.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
two_level_iterator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00