30fb9dd50f
Summary: The patch introduces a helper method in `util/compression.h` called `UncompressData` that dispatches calls to the correct uncompression method based on type, and changes `UncompressBlockContentsForCompressionType` and `Benchmark::Uncompress` in `db_bench` so they are implemented in terms of the new method. This eliminates some code duplication. (`Benchmark::Compress` is also updated to use the previously introduced `CompressData` helper.) In addition, the patch brings the implementation of `Snappy_Uncompress` into sync with the other uncompression methods by making the method compute the buffer size and allocate the buffer itself. Finally, the patch eliminates some potentially risky back-and-forth conversions between various unsigned and signed integer types by exposing the size of the allocated buffer as a `size_t` instead of an `int`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7434 Test Plan: `make check` `./db_bench -benchmarks=compress,uncompress --compression_type ...` Reviewed By: riversand963 Differential Revision: D23900011 Pulled By: ltamasi fbshipit-source-id: b25df63ceec4639889be94acb22eb53e530c54e0 |
||
|---|---|---|
| .. | ||
| env_default.cc | ||
| env_win.cc | ||
| env_win.h | ||
| io_win.cc | ||
| io_win.h | ||
| port_win.cc | ||
| port_win.h | ||
| win_jemalloc.cc | ||
| win_logger.cc | ||
| win_logger.h | ||
| win_thread.cc | ||
| win_thread.h | ||
| xpress_win.cc | ||
| xpress_win.h | ||