andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/util
History
Sagar Vemuri 440621aab8 Fix Copying of data between buffers in FilePrefetchBuffer (#4100) 
Summary:
Copy data between buffers inside FilePrefetchBuffer only when chunk length is greater than 0. Otherwise AlignedBuffer was accessing memory out of its range causing crashes.

Removing the tracking of buffer length outside of `AlignedBuffer`, i.e. in `FilePrefetchBuffer` and `ReadaheadRandomAccessFile`, will follow in a separate PR, as it is not the root cause of the crash reported in #4051. (`FilePrefetchBuffer` itself has been this way from its inception, and `ReadaheadRandomAccessFile` was updated to add the buffer length at some point).

Comprehensive tests for `FilePrefetchBuffer` also to follow in a separate PR.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4100

Differential Revision: D8792590

Pulled By: sagar0

fbshipit-source-id: 3578f45761cf6884243e767f749db4016ccc93e1
2018-07-11 12:28:13 -07:00
..
aligned_buffer.h
Fix Copying of data between buffers in FilePrefetchBuffer (#4100)
2018-07-11 12:28:13 -07:00
allocator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
arena_test.cc
arena: derive alignment unit from std::max_align_t
2017-10-17 11:13:19 -07:00
arena.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
arena.h
arena: derive alignment unit from std::max_align_t
2017-10-17 11:13:19 -07:00
auto_roll_logger_test.cc
fix memory leak in two_level_iterator
2018-04-15 17:26:26 -07:00
auto_roll_logger.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
auto_roll_logger.h
Fix the Logger::Close() and DBImpl::Close() design pattern
2018-02-23 13:57:26 -08:00
autovector_test.cc
fix memory leak in two_level_iterator
2018-04-15 17:26:26 -07:00
autovector.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
bloom_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
bloom.cc
Prefetch cache lines for filter lookup (#4068)
2018-06-28 13:20:29 -07:00
build_version.cc.in
Makefile: generate util/build_version.cc from .in file (#1384)
2016-10-25 11:31:39 -07:00
build_version.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cast_util.h
Add a missing "once" in .h
2017-07-31 12:12:03 -07:00
channel.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
coding_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
coding.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
coding.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
compaction_job_stats_impl.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
comparator.cc
use user_key and iterate_upper_bound to determine compatibility of bloom filters (#3899)
2018-06-26 15:57:26 -07:00
compression_context_cache.cc
run make format for PR 3838 (#3954)
2018-06-05 12:58:02 -07:00
compression_context_cache.h
run make format for PR 3838 (#3954)
2018-06-05 12:58:02 -07:00
compression.h
ZSTD compression: should also expect type = kZSTDNotFinalCompression (#3964)
2018-06-06 23:42:29 -07:00
concurrent_arena.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
concurrent_arena.h
util: Fix coverity issues
2017-11-03 14:42:08 -07:00
core_local.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
crc32c_ppc_asm.S
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
crc32c_ppc_constants.h
Make it explicit blob db doesn't support CF
2017-09-08 11:11:04 -07:00
crc32c_ppc.c
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
crc32c_ppc.h
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
crc32c_test.cc
Build and tests fixes for Solaris Sparc (#4000)
2018-06-15 12:42:53 -07:00
crc32c.cc
Suppress UBSAN error in finer guanularity
2018-02-13 12:18:07 -08:00
crc32c.h
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
delete_scheduler_test.cc
In delete scheduler, before ftruncate file for slow delete, check whether there is other hard links (#4093)
2018-07-09 15:28:12 -07:00
delete_scheduler.cc
In delete scheduler, before ftruncate file for slow delete, check whether there is other hard links (#4093)
2018-07-09 15:28:12 -07:00
delete_scheduler.h
In delete scheduler, before ftruncate file for slow delete, check whether there is other hard links (#4093)
2018-07-09 15:28:12 -07:00
duplicate_detector.h
Improve db_stress with transactions
2018-04-18 16:32:35 -07:00
dynamic_bloom_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
dynamic_bloom.cc
Use nullptr instead of NULL / 0 more consistently.
2018-03-07 12:42:12 -08:00
dynamic_bloom.h
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
event_logger_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
event_logger.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
event_logger.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
fault_injection_test_env.cc
Allow DB resume after background errors (#3997)
2018-06-28 12:34:40 -07:00
fault_injection_test_env.h
Allow DB resume after background errors (#3997)
2018-06-28 12:34:40 -07:00
file_reader_writer_test.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
file_reader_writer.cc
Fix Copying of data between buffers in FilePrefetchBuffer (#4100)
2018-07-11 12:28:13 -07:00
file_reader_writer.h
Improve direct IO range scan performance with readahead (#3884)
2018-06-21 11:13:08 -07:00
file_util.cc
Add file name info to SequentialFileReader. (#4026)
2018-06-21 08:42:24 -07:00
file_util.h
Sync parent directory after deleting a file in delete scheduler
2018-04-26 13:58:20 -07:00
filelock_test.cc
Check with PosixEnv before opening LOCK file (#3993)
2018-06-13 17:32:04 -07:00
filename.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
filename.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
filter_policy.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
gflags_compat.h
fix gflags namespace
2017-12-01 10:42:05 -08:00
hash_map.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
hash_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
hash.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
hash.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
heap_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
heap.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
kv_map.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_buffer.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_buffer.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_write_bench.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
logging.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
memory_usage.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
murmurhash.cc
Suppress UBSAN error in finer guanularity
2018-02-13 12:18:07 -08:00
murmurhash.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
mutexlock.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
ppc-opcode.h
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
random.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
random.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
rate_limiter_test.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
rate_limiter.cc
rate limit auto-tuning
2017-10-04 19:15:01 -07:00
rate_limiter.h
rate limit auto-tuning
2017-10-04 19:15:01 -07:00
set_comparator.h
WritePrepared Txn: Move DuplicateDetector to util
2018-03-05 23:57:12 -08:00
slice_transform_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
slice.cc
use user_key and iterate_upper_bound to determine compatibility of bloom filters (#3899)
2018-06-26 15:57:26 -07:00
sst_file_manager_impl.cc
Sync parent directory after deleting a file in delete scheduler
2018-04-26 13:58:20 -07:00
sst_file_manager_impl.h
Sync parent directory after deleting a file in delete scheduler
2018-04-26 13:58:20 -07:00
status_message.cc
Allow DB resume after background errors (#3997)
2018-06-28 12:34:40 -07:00
status.cc
Allow DB resume after background errors (#3997)
2018-06-28 12:34:40 -07:00
stderr_logger.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
stop_watch.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
string_util.cc
Several small "fixes"
2018-02-15 16:57:37 -08:00
string_util.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
sync_point_impl.cc
Avoid acquiring SyncPoint mutex when it is disabled (#3991)
2018-06-13 13:13:18 -07:00
sync_point_impl.h
Avoid acquiring SyncPoint mutex when it is disabled (#3991)
2018-06-13 13:13:18 -07:00
sync_point.cc
Refactor sync_point to make implementation either customizable or replaceable
2018-03-23 12:56:52 -07:00
sync_point.h
Fix singleton destruction order of PosixEnv and SyncPoint (#3951)
2018-06-04 15:58:46 -07:00
testharness.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
testharness.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
testutil.cc
Pin top-level index on partitioned index/filter blocks (#4037)
2018-06-22 15:27:46 -07:00
testutil.h
Add file name info to SequentialFileReader. (#4026)
2018-06-21 08:42:24 -07:00
thread_list_test.cc
Use nullptr instead of NULL / 0 more consistently.
2018-03-07 12:42:12 -08:00
thread_local_test.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
thread_local.cc
util: Fix coverity issues
2017-11-03 14:42:08 -07:00
thread_local.h
Provide a way to override windows memory allocator with jemalloc for ZSTD
2018-06-04 12:12:48 -07:00
thread_operation.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
threadpool_imp.cc
Support lowering CPU priority of background threads
2018-04-24 08:41:51 -07:00
threadpool_imp.h
Support lowering CPU priority of background threads
2018-04-24 08:41:51 -07:00
timer_queue_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
timer_queue.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
transaction_test_util.cc
WritePrepared Txn: enable rollback in stress test
2018-05-02 18:13:05 -07:00
transaction_test_util.h
WritePrepared Txn: stress test
2017-12-06 09:42:28 -08:00
xxhash.cc
fixed typo
2017-06-05 11:27:34 -07:00
xxhash.h
Prevent xxhash symbols from polluting global namespace
2015-03-12 12:07:10 -07:00