1d34cd797e
Summary: Calling the GetImpl function could leave reference to a local callback function in a field of a parameter struct. As this is performance-critical code, I'm not going to attempt to sanitize this code too much, but make the existing hack a bit cleaner by reverting what it overwrites in the input struct. Added SaveAndRestore utility class to make that easier. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8590 Test Plan: added unit test for SaveAndRestore; existing tests for GetImpl Reviewed By: riversand963 Differential Revision: D29947983 Pulled By: pdillinger fbshipit-source-id: 2f608853f970bc06724e834cc84dcc4b8599ddeb
51 lines
1.0 KiB
C++
51 lines
1.0 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "port/port.h"
|
|
#include "port/stack_trace.h"
|
|
#include "test_util/testharness.h"
|
|
#include "util/defer.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
class DeferTest {};
|
|
|
|
TEST(DeferTest, BlockScope) {
|
|
int v = 1;
|
|
{
|
|
Defer defer([&v]() { v *= 2; });
|
|
}
|
|
ASSERT_EQ(2, v);
|
|
}
|
|
|
|
TEST(DeferTest, FunctionScope) {
|
|
int v = 1;
|
|
auto f = [&v]() {
|
|
Defer defer([&v]() { v *= 2; });
|
|
v = 2;
|
|
};
|
|
f();
|
|
ASSERT_EQ(4, v);
|
|
}
|
|
|
|
TEST(SaveAndRestoreTest, BlockScope) {
|
|
int v = 1;
|
|
{
|
|
SaveAndRestore<int> sr(&v);
|
|
ASSERT_EQ(v, 1);
|
|
v = 2;
|
|
ASSERT_EQ(v, 2);
|
|
}
|
|
ASSERT_EQ(v, 1);
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
int main(int argc, char** argv) {
|
|
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|