rocksdb/tools/block_cache_analyzer
Ramkumar Vadivelu 9a690a74e1 In ParseInternalKey(), include corrupt key info in Status (#7515)
Summary:
Fixes Issue https://github.com/facebook/rocksdb/issues/7497

When allow_data_in_errors db_options is set, log error key details in `ParseInternalKey()`

Have fixed most of the calls. Have few TODOs still pending - because have to make more deeper changes to pass in the allow_data_in_errors flag. Will do those in a separate PR later.

Tests:
- make check
- some of the existing tests that exercise the "internal key too small" condition are: dbformat_test, cuckoo_table_builder_test
- some of the existing tests that exercise the corrupted key path are: corruption_test, merge_helper_test, compaction_iterator_test

Example of new status returns:
- Key too small - `Corrupted Key: Internal Key too small. Size=5`
- Corrupt key with allow_data_in_errors option set to false: `Corrupted Key: '<redacted>' seq:3, type:3`
- Corrupt key with allow_data_in_errors option set to true: `Corrupted Key: '61' seq:3, type:3`

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7515

Reviewed By: ajkr

Differential Revision: D24240264

Pulled By: ramvadiv

fbshipit-source-id: bc48f5d4475ac19d7713e16df37505b31aac42e7
2020-10-28 10:12:58 -07:00
..
__init__.py Block cache simulator: Add pysim to simulate caches using reinforcement learning. (#5610) 2019-07-26 14:41:13 -07:00
block_cache_pysim_test.py Pysim more algorithms (#5644) 2019-08-06 18:50:59 -07:00
block_cache_pysim.py Pysim more algorithms (#5644) 2019-08-06 18:50:59 -07:00
block_cache_pysim.sh Pysim more algorithms (#5644) 2019-08-06 18:50:59 -07:00
block_cache_trace_analyzer_plot.py Block cache analyzer: python script to plot graphs (#5673) 2019-08-05 18:35:52 -07:00
block_cache_trace_analyzer_test.cc fix MSVC build failures (#6517) 2020-03-12 08:42:39 -07:00
block_cache_trace_analyzer_tool.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
block_cache_trace_analyzer.cc C++20 compatibility (#6697) 2020-04-20 13:24:25 -07:00
block_cache_trace_analyzer.h In ParseInternalKey(), include corrupt key info in Status (#7515) 2020-10-28 10:12:58 -07:00