andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/util
History
Andrew Kryczka 3943d16780 Fix race conditions in auto-rolling logger 
Summary:
For GetLogFileSize() and Flush(), they previously did not follow the
synchronization pattern for accessing logger_. This meant ResetLogger() could
cause logger_ destruction while the unsynchronized functions were accessing it,
causing a segfault.

Also made the mutex instance variable mutable so we can preserve
GetLogFileSize()'s const-ness.

Test Plan:
new test case, it's quite ugly because both threads need to access
one of the functions with SyncPoints (PosixLogger::Flush()), and also special
handling is needed to prevent the mutex and sync points from conflicting.

Reviewers: kradhakrishnan, IslamAbdelRahman, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D54237
2016-02-17 12:06:45 -08:00
..
aligned_buffer.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
allocator.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
arena_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
arena.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
arena.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
autovector_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
autovector.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
bloom_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
bloom.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
build_version.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
cache_bench.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
cache_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
cache.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
channel.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
coding_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
coding.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
coding.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
compaction_job_stats_impl.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
comparator.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
compression.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
concurrent_arena.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
concurrent_arena.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
crc32c_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
crc32c.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
crc32c.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
delete_scheduler_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
delete_scheduler.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
delete_scheduler.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
dynamic_bloom_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
dynamic_bloom.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
dynamic_bloom.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
env_hdfs.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
env_posix.cc
Fixed a dependency issue of ThreadLocalPtr
2016-02-10 16:56:01 -08:00
env_test.cc
Fix includes for env_test
2016-02-12 14:17:14 -08:00
env.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
event_logger_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
event_logger.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
event_logger.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_reader_writer_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_reader_writer.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_reader_writer.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_util.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
file_util.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
filelock_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
filter_policy.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
hash.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
hash.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
heap_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
heap.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
histogram_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
histogram.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
histogram.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
instrumented_mutex.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
instrumented_mutex.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
io_posix.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
io_posix.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
iostats_context_imp.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
iostats_context.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
kv_map.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_buffer.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_buffer.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
log_write_bench.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
logging.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
logging.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
memenv_test.cc
[directory includes cleanup] Finish removing util->db dependencies
2016-01-26 10:49:24 -08:00
memenv.cc
Refactor to support file_reader_writer on Windows.
2015-09-11 09:57:02 -07:00
mock_env_test.cc
[directory includes cleanup] Finish removing util->db dependencies
2016-01-26 10:49:24 -08:00
mock_env.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
mock_env.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
murmurhash.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
murmurhash.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
mutable_cf_options.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
mutable_cf_options.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
mutexlock.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_builder.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_helper.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_helper.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_parser.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_parser.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_sanity_check.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_sanity_check.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
options.cc
fixes typo in options logging
2016-02-15 23:55:29 +00:00
perf_context_imp.h
fix ios build error
2016-02-17 20:22:40 +08:00
perf_context.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
perf_level_imp.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
perf_level.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
perf_step_timer.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
posix_logger.h
Fix race conditions in auto-rolling logger
2016-02-17 12:06:45 -08:00
random.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
random.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
rate_limiter_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
rate_limiter.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
rate_limiter.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
slice_transform_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
slice.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
sst_file_manager_impl.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
sst_file_manager_impl.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
statistics.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
statistics.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
status_message.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
status.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
stop_watch.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
string_util.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
string_util.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
sync_point.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
sync_point.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
testharness.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
testharness.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
testutil.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
testutil.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_list_test.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_local_test.cc
Fixed a dependency issue of ThreadLocalPtr
2016-02-10 16:56:01 -08:00
thread_local.cc
Fixed a dependency issue of ThreadLocalPtr
2016-02-10 16:56:01 -08:00
thread_local.h
Fixed a dependency issue of ThreadLocalPtr
2016-02-10 16:56:01 -08:00
thread_operation.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_posix.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_posix.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_status_impl.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_status_updater_debug.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_status_updater.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_status_updater.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_status_util_debug.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_status_util.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
thread_status_util.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
xfunc.cc
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
xfunc.h
Updated all copyright headers to the new format.
2016-02-09 15:12:00 -08:00
xxhash.cc
Enable MS Warning C4804 : unsafe use of type 'bool' in operation
2015-11-18 16:23:19 -08:00
xxhash.h
Prevent xxhash symbols from polluting global namespace
2015-03-12 12:07:10 -07:00