449029f865
Summary: Regexes are considered potentially problematic for use in registering RocksDB extensions, so we are removing ObjectLibrary::Register() and the Regex public API it depended on (now unused). In reference to https://github.com/facebook/rocksdb/issues/9389 Why? * The power of Regexes can make it hard to reason about which extension will match what. (The replacement API isn't perfect, but we are at least "holding the line" on patterns we have seen in practice.) * It is easy to make regexes that don't quite mean what you think they mean, such as forgetting that the `.` in `foo.bar` can match any character or that matching is nondeterministic, as in `a🅱️42` matching `.*:[0-9]+`. * Some regexes and implementations can have disastrously bad performance. This might not be much practical concern for ObjectLibray here, but we don't want to encourage potentially dangerous further use in production code. (Testing code is fine. See TestRegex.) Pull Request resolved: https://github.com/facebook/rocksdb/pull/9439 Test Plan: CI Reviewed By: mrambacher Differential Revision: D33792342 Pulled By: pdillinger fbshipit-source-id: 4f64dcb04764e639162c8977a5fa196f67754cec |
||
|---|---|---|
| .. | ||
| mock_time_env.cc | ||
| mock_time_env.h | ||
| sync_point_impl.cc | ||
| sync_point_impl.h | ||
| sync_point.cc | ||
| sync_point.h | ||
| testharness.cc | ||
| testharness.h | ||
| testutil_test.cc | ||
| testutil.cc | ||
| testutil.h | ||
| transaction_test_util.cc | ||
| transaction_test_util.h | ||