Andrew Kryczka ed3af9ef99 improve ldb CLI option support
Summary:
- Made CLI arguments take precedence over options file when both are provided. Note some of the CLI args are not settable via options file, like `--compression_max_dict_bytes`, so it's necessary to allow both ways of providing options simultaneously.
- Changed `PrepareOptionsForOpenDB` to update the proper `ColumnFamilyOptions` if one exists for the user's `--column_family_name` argument. I supported this only in the base class, `LDBCommand`, so it works for the general arguments. Will defer adding support for subcommand-specific arguments.
- Made the command fail if `--try_load_options` is provided and loading options file returns NotFound. I found the previous behavior of silently continuing confusing.
Closes https://github.com/facebook/rocksdb/pull/3144

Differential Revision: D6270544

Pulled By: ajkr

fbshipit-source-id: 7c2eac9f9b38720523d74466fb9e78db53561367
2017-11-28 17:28:58 -08:00
..
2017-07-15 16:11:23 -07:00
2017-08-03 15:56:46 -07:00
2017-08-03 15:56:46 -07:00
2017-08-03 15:56:46 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-08-03 15:56:46 -07:00
2017-08-03 15:56:46 -07:00
2017-07-15 16:11:23 -07:00
2017-07-15 16:11:23 -07:00
2017-11-28 17:28:58 -08:00
2017-05-12 15:54:06 -07:00
2017-07-15 16:11:23 -07:00
2017-08-03 15:56:46 -07:00
2017-07-15 16:11:23 -07:00
2017-08-03 15:56:46 -07:00
2017-08-03 15:56:46 -07:00
2017-07-15 16:11:23 -07:00
2017-08-03 15:56:46 -07:00
2015-10-28 16:15:07 -07:00