3e422ce0ca
Summary: There's a potential deadlock caused by MockTimeEnv time value get to a large number, which causes TimedWait() wait forever. The test misuses the microseconds as seconds, making it more likely to happen. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7277 Reviewed By: pdillinger Differential Revision: D23183873 Pulled By: jay-zhuang fbshipit-source-id: 6fc38ebd40b4125a99551204b271f91a27e70086
227 lines
7.1 KiB
C++
227 lines
7.1 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#include "monitoring/stats_dump_scheduler.h"
|
|
|
|
#include "db/db_test_util.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
class StatsDumpSchedulerTest : public DBTestBase {
|
|
public:
|
|
StatsDumpSchedulerTest()
|
|
: DBTestBase("/stats_dump_scheduler_test", /*env_do_fsync=*/true),
|
|
mock_env_(new MockTimeEnv(Env::Default())) {}
|
|
|
|
protected:
|
|
std::unique_ptr<MockTimeEnv> mock_env_;
|
|
|
|
void SetUp() override {
|
|
mock_env_->InstallTimedWaitFixCallback();
|
|
SyncPoint::GetInstance()->SetCallBack(
|
|
"DBImpl::StartStatsDumpScheduler:Init", [&](void* arg) {
|
|
auto* stats_dump_scheduler_ptr =
|
|
reinterpret_cast<StatsDumpScheduler**>(arg);
|
|
*stats_dump_scheduler_ptr =
|
|
StatsDumpTestScheduler::Default(mock_env_.get());
|
|
});
|
|
}
|
|
};
|
|
|
|
TEST_F(StatsDumpSchedulerTest, Basic) {
|
|
constexpr int kPeriodSec = 5;
|
|
Close();
|
|
Options options;
|
|
options.stats_dump_period_sec = kPeriodSec;
|
|
options.stats_persist_period_sec = kPeriodSec;
|
|
options.create_if_missing = true;
|
|
int mock_time_sec = 0;
|
|
mock_env_->set_current_time(mock_time_sec);
|
|
options.env = mock_env_.get();
|
|
|
|
int dump_st_counter = 0;
|
|
SyncPoint::GetInstance()->SetCallBack("DBImpl::DumpStats:StartRunning",
|
|
[&](void*) { dump_st_counter++; });
|
|
|
|
int pst_st_counter = 0;
|
|
SyncPoint::GetInstance()->SetCallBack("DBImpl::PersistStats:StartRunning",
|
|
[&](void*) { pst_st_counter++; });
|
|
SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
Reopen(options);
|
|
|
|
ASSERT_EQ(5u, dbfull()->GetDBOptions().stats_dump_period_sec);
|
|
ASSERT_EQ(5u, dbfull()->GetDBOptions().stats_persist_period_sec);
|
|
|
|
mock_time_sec += kPeriodSec - 1;
|
|
dbfull()->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
|
|
auto scheduler = dbfull()->TEST_GetStatsDumpScheduler();
|
|
ASSERT_NE(nullptr, scheduler);
|
|
ASSERT_EQ(2, scheduler->TEST_GetValidTaskNum());
|
|
|
|
ASSERT_EQ(1, dump_st_counter);
|
|
ASSERT_EQ(1, pst_st_counter);
|
|
|
|
mock_time_sec += kPeriodSec;
|
|
dbfull()->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
|
|
ASSERT_EQ(2, dump_st_counter);
|
|
ASSERT_EQ(2, pst_st_counter);
|
|
|
|
mock_time_sec += kPeriodSec;
|
|
dbfull()->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
|
|
ASSERT_EQ(3, dump_st_counter);
|
|
ASSERT_EQ(3, pst_st_counter);
|
|
|
|
// Disable scheduler with SetOption
|
|
ASSERT_OK(dbfull()->SetDBOptions(
|
|
{{"stats_dump_period_sec", "0"}, {"stats_persist_period_sec", "0"}}));
|
|
ASSERT_EQ(0u, dbfull()->GetDBOptions().stats_dump_period_sec);
|
|
ASSERT_EQ(0u, dbfull()->GetDBOptions().stats_persist_period_sec);
|
|
|
|
scheduler = dbfull()->TEST_GetStatsDumpScheduler();
|
|
ASSERT_EQ(0u, scheduler->TEST_GetValidTaskNum());
|
|
|
|
// Re-enable one task
|
|
ASSERT_OK(dbfull()->SetDBOptions({{"stats_dump_period_sec", "5"}}));
|
|
ASSERT_EQ(5u, dbfull()->GetDBOptions().stats_dump_period_sec);
|
|
ASSERT_EQ(0u, dbfull()->GetDBOptions().stats_persist_period_sec);
|
|
|
|
scheduler = dbfull()->TEST_GetStatsDumpScheduler();
|
|
ASSERT_NE(nullptr, scheduler);
|
|
ASSERT_EQ(1, scheduler->TEST_GetValidTaskNum());
|
|
|
|
dump_st_counter = 0;
|
|
mock_time_sec += kPeriodSec;
|
|
dbfull()->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
ASSERT_EQ(1, dump_st_counter);
|
|
|
|
Close();
|
|
}
|
|
|
|
TEST_F(StatsDumpSchedulerTest, MultiInstances) {
|
|
constexpr int kPeriodSec = 5;
|
|
const int kInstanceNum = 10;
|
|
|
|
Close();
|
|
Options options;
|
|
options.stats_dump_period_sec = kPeriodSec;
|
|
options.stats_persist_period_sec = kPeriodSec;
|
|
options.create_if_missing = true;
|
|
int mock_time_sec = 0;
|
|
mock_env_->set_current_time(mock_time_sec);
|
|
options.env = mock_env_.get();
|
|
|
|
int dump_st_counter = 0;
|
|
SyncPoint::GetInstance()->SetCallBack("DBImpl::DumpStats:2",
|
|
[&](void*) { dump_st_counter++; });
|
|
|
|
int pst_st_counter = 0;
|
|
SyncPoint::GetInstance()->SetCallBack("DBImpl::PersistStats:StartRunning",
|
|
[&](void*) { pst_st_counter++; });
|
|
SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
auto dbs = std::vector<DB*>(kInstanceNum);
|
|
for (int i = 0; i < kInstanceNum; i++) {
|
|
ASSERT_OK(
|
|
DB::Open(options, test::PerThreadDBPath(std::to_string(i)), &(dbs[i])));
|
|
}
|
|
|
|
auto dbi = static_cast_with_check<DBImpl>(dbs[kInstanceNum - 1]);
|
|
auto scheduler = dbi->TEST_GetStatsDumpScheduler();
|
|
ASSERT_EQ(kInstanceNum * 2, scheduler->TEST_GetValidTaskNum());
|
|
|
|
int expected_run = kInstanceNum;
|
|
mock_time_sec += kPeriodSec - 1;
|
|
dbi->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
ASSERT_EQ(expected_run, dump_st_counter);
|
|
ASSERT_EQ(expected_run, pst_st_counter);
|
|
|
|
expected_run += kInstanceNum;
|
|
mock_time_sec += kPeriodSec;
|
|
dbi->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
ASSERT_EQ(expected_run, dump_st_counter);
|
|
ASSERT_EQ(expected_run, pst_st_counter);
|
|
|
|
expected_run += kInstanceNum;
|
|
mock_time_sec += kPeriodSec;
|
|
dbi->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
ASSERT_EQ(expected_run, dump_st_counter);
|
|
ASSERT_EQ(expected_run, pst_st_counter);
|
|
|
|
int half = kInstanceNum / 2;
|
|
for (int i = 0; i < half; i++) {
|
|
delete dbs[i];
|
|
}
|
|
|
|
expected_run += (kInstanceNum - half) * 2;
|
|
|
|
mock_time_sec += kPeriodSec;
|
|
dbi->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
mock_time_sec += kPeriodSec;
|
|
dbi->TEST_WaitForStatsDumpRun(
|
|
[&] { mock_env_->set_current_time(mock_time_sec); });
|
|
ASSERT_EQ(expected_run, dump_st_counter);
|
|
ASSERT_EQ(expected_run, pst_st_counter);
|
|
|
|
for (int i = half; i < kInstanceNum; i++) {
|
|
dbs[i]->Close();
|
|
delete dbs[i];
|
|
}
|
|
}
|
|
|
|
TEST_F(StatsDumpSchedulerTest, MultiEnv) {
|
|
constexpr int kDumpPeriodSec = 5;
|
|
constexpr int kPersistPeriodSec = 10;
|
|
Close();
|
|
Options options1;
|
|
options1.stats_dump_period_sec = kDumpPeriodSec;
|
|
options1.stats_persist_period_sec = kPersistPeriodSec;
|
|
options1.create_if_missing = true;
|
|
mock_env_->set_current_time(0);
|
|
options1.env = mock_env_.get();
|
|
|
|
Reopen(options1);
|
|
|
|
std::unique_ptr<MockTimeEnv> mock_env2(new MockTimeEnv(Env::Default()));
|
|
Options options2;
|
|
options2.stats_dump_period_sec = kDumpPeriodSec;
|
|
options2.stats_persist_period_sec = kPersistPeriodSec;
|
|
options2.create_if_missing = true;
|
|
mock_env2->set_current_time(0);
|
|
options1.env = mock_env2.get();
|
|
|
|
std::string dbname = test::PerThreadDBPath("multi_env_test");
|
|
DB* db;
|
|
ASSERT_OK(DB::Open(options2, dbname, &db));
|
|
DBImpl* dbi = static_cast_with_check<DBImpl>(db);
|
|
|
|
ASSERT_EQ(dbi->TEST_GetStatsDumpScheduler(),
|
|
dbfull()->TEST_GetStatsDumpScheduler());
|
|
|
|
db->Close();
|
|
delete db;
|
|
Close();
|
|
}
|
|
#endif // !ROCKSDB_LITE
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
int main(int argc, char** argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
|
|
return RUN_ALL_TESTS();
|
|
}
|