andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3fc08fa88e
rocksdb/utilities/date_tiered
History
Siying Dong 64b6452e0c Make InternalKeyComparator final and directly use it in merging iterator 
Summary:
Merging iterator invokes InternalKeyComparator.Compare() frequently to heap merge. By making InternalKeyComparator final and merging iterator to directly use InternalKeyComparator rather than through Iterator interface, we can give compiler a choice to avoid one more virtual function call if possible. I ran readseq benchmark in memory-only use case to make sure the performance at least doesn't regress.

I have to disable the final key word in debug build, as a hack test class depends on overriding the class.
Closes https://github.com/facebook/rocksdb/pull/2860

Differential Revision: D5800461

Pulled By: siying

fbshipit-source-id: ab876f22a09bb5c560740911412336e0e25ccb53
2017-09-11 12:04:21 -07:00
..
date_tiered_db_impl.cc Make InternalKeyComparator final and directly use it in merging iterator 2017-09-11 12:04:21 -07:00
date_tiered_db_impl.h Make InternalKeyComparator final and directly use it in merging iterator 2017-09-11 12:04:21 -07:00
date_tiered_test.cc Fix GetCurrentTime() initialization for valgrind 2017-07-05 12:12:00 -07:00