cf8adc971e
Summary: Allow arcanist_util to work with both new and old arc versions. The diff is based on Adam Retter's pull request https://github.com/facebook/rocksdb/pull/1168 Many thanks to Adam to initiate this work Test Plan: run arc lint and arc diff using different arc versions Reviewers: sdong, IslamAbdelRahman, kradhakrishnan, andrewkr, adamretter, igor Reviewed By: adamretter Subscribers: andrewkr, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D59697
75 lines
2.0 KiB
PHP
75 lines
2.0 KiB
PHP
<?php
|
|
// Copyright 2004-present Facebook. All Rights Reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
abstract class BaseDirectoryScopedFormatLinter extends ArcanistLinter {
|
|
|
|
const LINT_FORMATTING = 1;
|
|
|
|
private $changedLines = array();
|
|
private $rawLintOutput = array();
|
|
|
|
abstract protected function getPathsToLint();
|
|
|
|
protected function shouldLintPath($path) {
|
|
foreach ($this->getPathsToLint() as $p) {
|
|
// check if $path starts with $p
|
|
if (strncmp($path, $p, strlen($p)) === 0) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
// API to tell this linter which lines were changed
|
|
final public function setPathChangedLines($path, $changed) {
|
|
$this->changedLines[$path] = $changed;
|
|
}
|
|
|
|
final public function willLintPaths(array $paths) {
|
|
$futures = array();
|
|
foreach ($paths as $path) {
|
|
if (!$this->shouldLintPath($path)) {
|
|
continue;
|
|
}
|
|
|
|
$changed = $this->changedLines[$path];
|
|
if (!isset($changed)) {
|
|
// do not run linter if there are no changes
|
|
continue;
|
|
}
|
|
|
|
$futures[$path] = $this->getFormatFuture($path, $changed);
|
|
}
|
|
|
|
foreach (id(new FutureIterator($futures))->limit(8) as $p => $f) {
|
|
$this->rawLintOutput[$p] = $f->resolvex();
|
|
}
|
|
}
|
|
|
|
abstract protected function getFormatFuture($path, array $changed);
|
|
abstract protected function getLintMessage($diff);
|
|
|
|
final public function lintPath($path) {
|
|
if (!isset($this->rawLintOutput[$path])) {
|
|
return;
|
|
}
|
|
|
|
list($new_content) = $this->rawLintOutput[$path];
|
|
$old_content = $this->getData($path);
|
|
|
|
if ($new_content != $old_content) {
|
|
$diff = ArcanistDiffUtils::renderDifferences($old_content, $new_content);
|
|
$this->raiseLintAtOffset(
|
|
0,
|
|
self::LINT_FORMATTING,
|
|
$this->getLintMessage($diff),
|
|
$old_content,
|
|
$new_content);
|
|
}
|
|
}
|
|
|
|
}
|