andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
42c109cc2e
rocksdb/table
History
Mayank Agarwal 352f0636ef Fix memory leak in table.cc 
Summary:
In InternalGet, BlockReader returns an Iterator which is legitimately freed at the end of the 'else' scope. BUT there is a break statement in between and must be freed there too!
The best solution would be to move to unique_ptr and let it handle. Changed it to a unique_ptr.

Test Plan: valgrind ./db_test;make all check

Reviewers: dhruba, haobo

Reviewed By: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D12681
2013-09-02 22:13:29 -07:00
..
block_builder.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
block_builder.h Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
block_test.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
block.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
block.h Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
filter_block_test.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
filter_block.cc Internal/user key bug fix. 2013-08-23 14:49:57 -07:00
filter_block.h Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
format.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
format.h Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
iter_heap.h Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
iterator_wrapper.h Codemod NULL to nullptr 2013-02-28 18:04:58 -08:00
iterator.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
merger.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
merger.h A number of fixes: 2011-10-31 17:22:06 +00:00
table_builder.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
table_test.cc Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00
table.cc Fix memory leak in table.cc 2013-09-02 22:13:29 -07:00
table.h Introduced a new flag non_blocking_io in ReadOptions. 2013-08-28 10:49:14 -07:00
two_level_iterator.cc [RocksDB] [Performance] Allow different posix advice to be applied to the same table file 2013-05-30 19:08:44 -07:00
two_level_iterator.h Replace include/leveldb with include/rocksdb. 2013-08-23 10:51:00 -07:00