rocksdb/utilities/persistent_cache
Mike Kolupaev 397ab11152 Improve Status message for block checksum mismatches
Summary:
We've got some DBs where iterators return Status with message "Corruption: block checksum mismatch" all the time. That's not very informative. It would be much easier to investigate if the error message contained the file name - then we would know e.g. how old the corrupted file is, which would be very useful for finding the root cause. This PR adds file name, offset and other stuff to some block corruption-related status messages.

It doesn't improve all the error messages, just a few that were easy to improve. I'm mostly interested in "block checksum mismatch" and "Bad table magic number" since they're the only corruption errors that I've ever seen in the wild.
Closes https://github.com/facebook/rocksdb/pull/2507

Differential Revision: D5345702

Pulled By: al13n321

fbshipit-source-id: fc8023d43f1935ad927cef1b9c55481ab3cb1339
2017-06-28 21:27:01 -07:00
..
block_cache_tier_file_buffer.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
block_cache_tier_file.cc Improve Status message for block checksum mismatches 2017-06-28 21:27:01 -07:00
block_cache_tier_file.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
block_cache_tier_metadata.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
block_cache_tier_metadata.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
block_cache_tier.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
block_cache_tier.h Fix data races caught by tsan 2017-05-22 10:27:23 -07:00
hash_table_bench.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
hash_table_evictable.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
hash_table_test.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
hash_table.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
lrulist.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
persistent_cache_bench.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
persistent_cache_test.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
persistent_cache_test.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
persistent_cache_tier.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
persistent_cache_tier.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
persistent_cache_util.h Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
volatile_tier_impl.cc Add GPLv2 as an alternative license. 2017-04-27 18:06:12 -07:00
volatile_tier_impl.h Fix data races caught by tsan 2017-05-22 10:27:23 -07:00