A library that provides an embeddable, persistent key-value store for fast storage.
Go to file
Yueh-Hsuan Chiang 43f170502f Fix a bug where flush does not happen when a manual compaction is running
Summary:
Currently, when rocksdb tries to run manual compaction to refit data into a level,
there's a ReFitLevel() process that requires no bg work is currently running.
When RocksDB plans to ReFitLevel(), it will do the following:

 1. pause scheduling new bg work.
 2. wait until all bg work finished
 3. do the ReFitLevel()
 4. unpause scheduling new bg work.

However, as it pause scheduling new bg work at step one and waiting for all bg work
finished in step 2, RocksDB will stop flushing until all bg work is done (which
could take a long time.)

This patch fix this issue by changing the way ReFitLevel() pause the background work:

1. pause scheduling compaction.
2. wait until all bg work finished.
3. pause scheduling flush
4. do ReFitLevel()
5. unpause both flush and compaction.

The major difference is that.  We only pause scheduling compaction in step 1 and wait
for all bg work finished in step 2.  This prevent flush being blocked for a long time.
Although there's a very rare case that ReFitLevel() might be in starvation in step 2,
but it's less likely the case as flush typically finish very fast.

Test Plan: existing test.

Reviewers: anthony, IslamAbdelRahman, kradhakrishnan, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D55029
2016-03-21 15:41:23 -07:00
arcanist_util Don't spew warnings when flint doesn't exist 2015-10-19 18:47:59 -07:00
build_tools Fix fb-only build for gcc 4.8.1 2015-12-09 11:04:06 -08:00
coverage Fix coverage script 2014-11-03 14:53:00 -08:00
db Fix a bug where flush does not happen when a manual compaction is running 2016-03-21 15:41:23 -07:00
doc Remove seek compaction 2014-06-20 10:23:02 +02:00
examples [RocksDB Options File] Add TableOptions section and support BlockBasedTable 2015-10-11 12:17:42 -07:00
hdfs [Cleanup] Remove RandomRWFile 2015-08-12 10:18:59 -07:00
include/rocksdb Correct the comment of GetApproximateMemoryUsageByType 2015-11-08 09:02:35 -08:00
java options: add recycle_log_file_num option 2015-10-18 21:21:24 -04:00
memtable Enable C4305 'identifier' : truncation from 'type1' to 'type2' 2015-11-06 16:44:39 -08:00
port "make format" in some recent commits 2015-10-29 17:11:14 -07:00
table Revert "Adding new table properties" 2015-11-06 16:49:38 -08:00
third-party "make format" against last 10 commits 2015-07-13 13:50:18 -07:00
tools Fix compilation problem on Windows. 2015-10-29 11:29:18 -07:00
util Upgrade to ZSTD 0.4.2 2015-12-09 11:02:49 -08:00
utilities Delete test iterators 2015-11-05 13:30:51 -08:00
.arcconfig Integrate Jenkins with Phabricator 2015-04-07 11:56:29 -07:00
.clang-format A script that automatically reformat affected lines 2014-01-14 12:21:24 -08:00
.gitignore New amalgamation target 2015-10-01 08:29:31 +13:00
.travis.yml Run ROCKSDB_LITE tests in travis 2015-10-16 10:47:37 -07:00
appveyor.yml Do not build test only code and unit tests in Release builds 2015-10-20 13:35:08 -07:00
appveyordailytests.yml Do not build test only code and unit tests in Release builds 2015-10-20 13:35:08 -07:00
AUTHORS Add AUTHORS file. Fix #203 2014-09-29 10:52:18 -07:00
CMakeLists.txt Enable C4305 'identifier' : truncation from 'type1' to 'type2' 2015-11-06 16:44:39 -08:00
CONTRIBUTING.md facebook accounts are not required for CLA signers 2014-07-08 05:57:54 -04:00
DUMP_FORMAT.md First version of rocksdb_dump and rocksdb_undump. 2015-06-19 16:24:36 -07:00
HISTORY.md Update HISTORY.md for RocksDB 4.1 2015-11-17 13:53:06 -08:00
INSTALL.md Update 4 is required for building with MS Visual Studio 13 2015-10-15 11:06:02 -07:00
LICENSE Fix copyright year 2014-03-12 12:06:58 -07:00
Makefile Include ldb_tools and sst_dump_tools libraries in shared library 2015-12-09 11:05:01 -08:00
PATENTS Update Patent Grant. 2015-04-13 10:33:43 +01:00
README.md Replaced "built on on earlier work" by "built on earlier work" in README.md 2014-09-17 01:16:17 -07:00
ROCKSDB_LITE.md Optimistic Transactions 2015-05-29 14:36:35 -07:00
src.mk Add OptionsSanityCheckLevel 2015-11-04 18:53:30 -08:00
thirdparty.inc Improve CI build and fix Windows build breakage 2015-09-30 11:20:23 -07:00
USERS.md Add Cloudera's blog post to USERS.md 2015-09-02 14:04:51 -07:00
Vagrantfile RocksDB on FreeBSD support 2015-02-26 15:19:17 -08:00
WINDOWS_PORT.md Commit both PR and internal code review changes 2015-07-07 16:58:20 -07:00

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

Build Status

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it specially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/master/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Design discussions are conducted in https://www.facebook.com/groups/rocksdb.dev/