284c365b77
Summary: It is a regression valgrind bug caused by using FileMetaData as index block handle. One of the fields of FileMetaData is not initialized after being contructed and copied, but I'm not able to find which one. Also, I realized that it's not a good idea to use FileMetaData as in TwoLevelIterator::InitDataBlock(), a copied FileMetaData can be compared with the one in version set byte by byte, but the refs can be changed. Also comparing such a large structure is slightly more expensive. Use a simpler structure instead Test Plan: Run the failing valgrind test (Harness.RandomizedLongDB) make all check Reviewers: igor, haobo, ljin Reviewed By: igor CC: yhchiang, leveldb Differential Revision: https://reviews.facebook.net/D17409
102 lines
4.2 KiB
C++
102 lines
4.2 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
//
|
|
// Thread-safe (provides internal synchronization)
|
|
|
|
#pragma once
|
|
#include <string>
|
|
#include <stdint.h>
|
|
|
|
#include "db/dbformat.h"
|
|
#include "port/port.h"
|
|
#include "rocksdb/cache.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/table.h"
|
|
#include "table/table_reader.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class Env;
|
|
struct FileMetaData;
|
|
|
|
// TODO(sdong): try to come up with a better API to pass the file information
|
|
// other than simply passing FileMetaData.
|
|
class TableCache {
|
|
public:
|
|
TableCache(const std::string& dbname, const Options* options,
|
|
const EnvOptions& storage_options, int entries);
|
|
~TableCache();
|
|
|
|
// Return an iterator for the specified file number (the corresponding
|
|
// file length must be exactly "file_size" bytes). If "tableptr" is
|
|
// non-nullptr, also sets "*tableptr" to point to the Table object
|
|
// underlying the returned iterator, or nullptr if no Table object underlies
|
|
// the returned iterator. The returned "*tableptr" object is owned by
|
|
// the cache and should not be deleted, and is valid for as long as the
|
|
// returned iterator is live.
|
|
Iterator* NewIterator(const ReadOptions& options, const EnvOptions& toptions,
|
|
const InternalKeyComparator& internal_comparator,
|
|
const FileMetaData& file_meta,
|
|
TableReader** table_reader_ptr = nullptr,
|
|
bool for_compaction = false);
|
|
|
|
// If a seek to internal key "k" in specified file finds an entry,
|
|
// call (*handle_result)(arg, found_key, found_value) repeatedly until
|
|
// it returns false.
|
|
Status Get(const ReadOptions& options,
|
|
const InternalKeyComparator& internal_comparator,
|
|
const FileMetaData& file_meta, const Slice& k, void* arg,
|
|
bool (*handle_result)(void*, const ParsedInternalKey&,
|
|
const Slice&, bool),
|
|
bool* table_io, void (*mark_key_may_exist)(void*) = nullptr);
|
|
|
|
// Determine whether the table may contain the specified prefix. If
|
|
// the table index or blooms are not in memory, this may cause an I/O
|
|
bool PrefixMayMatch(const ReadOptions& options,
|
|
const InternalKeyComparator& internal_comparator,
|
|
const FileMetaData& file_meta,
|
|
const Slice& internal_prefix, bool* table_io);
|
|
|
|
// Evict any entry for the specified file number
|
|
void Evict(uint64_t file_number);
|
|
|
|
// Find table reader
|
|
Status FindTable(const EnvOptions& toptions,
|
|
const InternalKeyComparator& internal_comparator,
|
|
uint64_t file_number, uint64_t file_size, Cache::Handle**,
|
|
bool* table_io = nullptr, const bool no_io = false);
|
|
|
|
// Get TableReader from a cache handle.
|
|
TableReader* GetTableReaderFromHandle(Cache::Handle* handle);
|
|
|
|
// Get the table properties of a given table.
|
|
// @no_io: indicates if we should load table to the cache if it is not present
|
|
// in table cache yet.
|
|
// @returns: `properties` will be reset on success. Please note that we will
|
|
// return Status::Incomplete() if table is not present in cache and
|
|
// we set `no_io` to be true.
|
|
Status GetTableProperties(const EnvOptions& toptions,
|
|
const InternalKeyComparator& internal_comparator,
|
|
const FileMetaData& file_meta,
|
|
std::shared_ptr<const TableProperties>* properties,
|
|
bool no_io = false);
|
|
|
|
// Release the handle from a cache
|
|
void ReleaseHandle(Cache::Handle* handle);
|
|
|
|
private:
|
|
Env* const env_;
|
|
const std::string dbname_;
|
|
const Options* options_;
|
|
const EnvOptions& storage_options_;
|
|
std::shared_ptr<Cache> cache_;
|
|
};
|
|
|
|
} // namespace rocksdb
|