andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4a60cb20ad
rocksdb/file
History
Jason Volk 4a60cb20ad Fix bug in MultiRead() coalescing introduced in 4fc216649d (#6446). (#6979) 
Summary:
TryMerge() overzealously creates one huge file read request in an attempt to merge smaller disjoint requests. For example, ~30 input requests of ~100 bytes output as 1 request of 100 MiB causing alarmingly large read throughputs to be repeatedly observed by the environment.

Signed-off-by: Jason Volk <jason@zemos.net>

Pull Request resolved: https://github.com/facebook/rocksdb/pull/6979

Reviewed By: siying

Differential Revision: D22668892

Pulled By: cheng-chang

fbshipit-source-id: 7506fe9621b7f1a747dadf6b8ddb1b1a141c1937
2020-07-22 15:03:22 -07:00
..
delete_scheduler_test.cc More Makefile Cleanup (#7097) 2020-07-09 14:35:17 -07:00
delete_scheduler.cc Fix for TSAN failure in DeleteScheduler (#7029) 2020-06-26 15:37:22 -07:00
delete_scheduler.h Fix for TSAN failure in DeleteScheduler (#7029) 2020-06-26 15:37:22 -07:00
file_prefetch_buffer.cc Extend Get/MultiGet deadline support to table open (#6982) 2020-06-29 14:53:17 -07:00
file_prefetch_buffer.h Extend Get/MultiGet deadline support to table open (#6982) 2020-06-29 14:53:17 -07:00
file_util.cc More Makefile Cleanup (#7097) 2020-07-09 14:35:17 -07:00
file_util.h More Makefile Cleanup (#7097) 2020-07-09 14:35:17 -07:00
filename.cc Find/purge obsolete blob files (#6807) 2020-05-07 09:32:51 -07:00
filename.h Find/purge obsolete blob files (#6807) 2020-05-07 09:32:51 -07:00
random_access_file_reader_test.cc More Makefile Cleanup (#7097) 2020-07-09 14:35:17 -07:00
random_access_file_reader.cc Fix bug in MultiRead() coalescing introduced in 4fc216649d (#6446). (#6979) 2020-07-22 15:03:22 -07:00
random_access_file_reader.h Use steady_clock instead of system_clock in FileOperationInfo::TimePoint (#7153) 2020-07-22 08:55:02 -07:00
read_write_util.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
read_write_util.h Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
readahead_raf.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
readahead_raf.h Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
sequence_file_reader.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
sequence_file_reader.h Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
sst_file_manager_impl.cc Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) 2020-02-20 12:09:57 -08:00
sst_file_manager_impl.h Add logs and stats in DeleteScheduler (#6927) 2020-06-05 09:43:04 -07:00
writable_file_writer.cc Use steady_clock instead of system_clock in FileOperationInfo::TimePoint (#7153) 2020-07-22 08:55:02 -07:00
writable_file_writer.h Use steady_clock instead of system_clock in FileOperationInfo::TimePoint (#7153) 2020-07-22 08:55:02 -07:00