bda8d93ba9
Summary: It's always annoying to find a header does not include its own dependencies and only works when included after other includes. This change adds `make check-headers` which validates that each header can be included at the top of a file. Some headers are excluded e.g. because of platform or external dependencies. rocksdb_namespace.h had to be re-worked slightly to enable checking for failure to include it. (ROCKSDB_NAMESPACE is a valid namespace name.) Fixes mostly involve adding and cleaning up #includes, but for FileTraceWriter, a constructor was out-of-lined to make a forward declaration sufficient. This check is not currently run with `make check` but is added to CircleCI build-linux-unity since that one is already relatively fast. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8893 Test Plan: existing tests and resolving issues detected by new check Reviewed By: mrambacher Differential Revision: D30823300 Pulled By: pdillinger fbshipit-source-id: 9fff223944994c83c105e2e6496d24845dc8e572
46 lines
1.5 KiB
C++
46 lines
1.5 KiB
C++
// Copyright (c) 2016-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <cstdint>
|
|
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
struct CompactionIterationStats {
|
|
// Compaction statistics
|
|
|
|
// Doesn't include records skipped because of
|
|
// CompactionFilter::Decision::kRemoveAndSkipUntil.
|
|
int64_t num_record_drop_user = 0;
|
|
|
|
int64_t num_record_drop_hidden = 0;
|
|
int64_t num_record_drop_obsolete = 0;
|
|
int64_t num_record_drop_range_del = 0;
|
|
int64_t num_range_del_drop_obsolete = 0;
|
|
// Deletions obsoleted before bottom level due to file gap optimization.
|
|
int64_t num_optimized_del_drop_obsolete = 0;
|
|
uint64_t total_filter_time = 0;
|
|
|
|
// Input statistics
|
|
// TODO(noetzli): The stats are incomplete. They are lacking everything
|
|
// consumed by MergeHelper.
|
|
uint64_t num_input_records = 0;
|
|
uint64_t num_input_deletion_records = 0;
|
|
uint64_t num_input_corrupt_records = 0;
|
|
uint64_t total_input_raw_key_bytes = 0;
|
|
uint64_t total_input_raw_value_bytes = 0;
|
|
|
|
// Single-Delete diagnostics for exceptional situations
|
|
uint64_t num_single_del_fallthru = 0;
|
|
uint64_t num_single_del_mismatch = 0;
|
|
|
|
// Blob related statistics
|
|
uint64_t num_blobs_read = 0;
|
|
uint64_t total_blob_bytes_read = 0;
|
|
uint64_t num_blobs_relocated = 0;
|
|
uint64_t total_blob_bytes_relocated = 0;
|
|
};
|