5504a056f8
Summary: This adds some rules in the tools/advisor/advisor/rules.ini (refer this for more information) file and corresponding python parser scripts for parsing the rules file and the rocksdb LOG and OPTIONS files. This is WIP for adding rules depending on ODS. The starting point of the script is the rocksdb/tools/advisor/advisor/rule_parser.py file. Closes https://github.com/facebook/rocksdb/pull/3934 Reviewed By: maysamyabandeh Differential Revision: D8304059 Pulled By: poojam23 fbshipit-source-id: 47f2a50f04d46d40e225dd1cbf58ba490f79e239
59 lines
1.4 KiB
INI
59 lines
1.4 KiB
INI
[Rule "missing-suggestions"]
|
|
suggestions=
|
|
conditions=missing-source
|
|
|
|
[Condition "normal-rule"]
|
|
source=LOG
|
|
regex=Stopping writes because we have \d+ immutable memtables \(waiting for flush\), max_write_buffer_number is set to \d+
|
|
scope=column_family
|
|
|
|
[Suggestion "inc-bg-flush"]
|
|
option=DBOptions.max_background_flushes
|
|
action=increase
|
|
|
|
[Suggestion "inc-write-buffer"]
|
|
option=CFOptions.max_write_buffer_number
|
|
action=increase
|
|
|
|
[Rule "missing-conditions"]
|
|
conditions=
|
|
suggestions=missing-description
|
|
|
|
[Condition "missing-options"]
|
|
source=OPTIONS
|
|
options=
|
|
evaluate=int(options[0])*int(options[1])-int(options[2])<(-251659456) # should evaluate to a boolean
|
|
|
|
[Rule "missing-expression"]
|
|
conditions=missing-expression
|
|
suggestions=missing-description
|
|
|
|
[Condition "missing-expression"]
|
|
source=OPTIONS
|
|
options=CFOptions.level0_file_num_compaction_trigger:CFOptions.write_buffer_size:CFOptions.max_bytes_for_level_base
|
|
evaluate=
|
|
|
|
[Suggestion "missing-description"]
|
|
description=
|
|
|
|
[Rule "stop-too-many-L0"]
|
|
suggestions=inc-max-bg-compactions:missing-action:inc-l0-stop-writes-trigger
|
|
conditions=missing-regex
|
|
|
|
[Condition "missing-regex"]
|
|
source=LOG
|
|
regex=
|
|
scope=column_family
|
|
|
|
[Suggestion "missing-option"]
|
|
option=
|
|
action=increase
|
|
|
|
[Suggestion "normal-suggestion"]
|
|
option=CFOptions.write_buffer_size
|
|
action=increase
|
|
|
|
[Suggestion "inc-l0-stop-writes-trigger"]
|
|
option=CFOptions.level0_stop_writes_trigger
|
|
action=increase
|