3dff28cf9b
Summary: For performance purposes, the lower level routines were changed to use a SystemClock* instead of a std::shared_ptr<SystemClock>. The shared ptr has some performance degradation on certain hardware classes. For most of the system, there is no risk of the pointer being deleted/invalid because the shared_ptr will be stored elsewhere. For example, the ImmutableDBOptions stores the Env which has a std::shared_ptr<SystemClock> in it. The SystemClock* within the ImmutableDBOptions is essentially a "short cut" to gain access to this constant resource. There were a few classes (PeriodicWorkScheduler?) where the "short cut" property did not hold. In those cases, the shared pointer was preserved. Using db_bench readrandom perf_level=3 on my EC2 box, this change performed as well or better than 6.17: 6.17: readrandom : 28.046 micros/op 854902 ops/sec; 61.3 MB/s (355999 of 355999 found) 6.18: readrandom : 32.615 micros/op 735306 ops/sec; 52.7 MB/s (290999 of 290999 found) PR: readrandom : 27.500 micros/op 871909 ops/sec; 62.5 MB/s (367999 of 367999 found) (Note that the times for 6.18 are prior to revert of the SystemClock). Pull Request resolved: https://github.com/facebook/rocksdb/pull/8033 Reviewed By: pdillinger Differential Revision: D27014563 Pulled By: mrambacher fbshipit-source-id: ad0459eba03182e454391b5926bf5cdd45657b67
66 lines
1.7 KiB
C++
66 lines
1.7 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
//
|
|
// Logger implementation that can be shared by all environments
|
|
// where enough posix functionality is available.
|
|
|
|
#pragma once
|
|
|
|
#include <stdint.h>
|
|
#include <windows.h>
|
|
|
|
#include <atomic>
|
|
#include <memory>
|
|
|
|
#include "rocksdb/env.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
class SystemClock;
|
|
|
|
namespace port {
|
|
class WinLogger : public ROCKSDB_NAMESPACE::Logger {
|
|
public:
|
|
WinLogger(uint64_t (*gettid)(), SystemClock* clock, HANDLE file,
|
|
const InfoLogLevel log_level = InfoLogLevel::ERROR_LEVEL);
|
|
|
|
virtual ~WinLogger();
|
|
|
|
WinLogger(const WinLogger&) = delete;
|
|
|
|
WinLogger& operator=(const WinLogger&) = delete;
|
|
|
|
void Flush() override;
|
|
|
|
using ROCKSDB_NAMESPACE::Logger::Logv;
|
|
void Logv(const char* format, va_list ap) override;
|
|
|
|
size_t GetLogFileSize() const override;
|
|
|
|
void DebugWriter(const char* str, int len);
|
|
|
|
protected:
|
|
|
|
Status CloseImpl() override;
|
|
|
|
private:
|
|
HANDLE file_;
|
|
uint64_t (*gettid_)(); // Return the thread id for the current thread
|
|
std::atomic_size_t log_size_;
|
|
std::atomic_uint_fast64_t last_flush_micros_;
|
|
SystemClock* clock_;
|
|
bool flush_pending_;
|
|
|
|
Status CloseInternal();
|
|
|
|
const static uint64_t flush_every_seconds_ = 5;
|
|
};
|
|
}
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|