e7c434c364
Summary:
Summary:
Added a new option to ColumnFamllyOptions - optimize_filters_for_hits. This option can be used in the case where most
accesses to the store are key hits and we dont need to optimize performance for key misses.
This is useful when you have a very large database and most of your lookups succeed. The option allows the store to
not store and use filters in the last level (the largest level which contains data). These filters can take a large amount of
space for large databases (in memory and on-disk). For the last level, these filters are only useful for key misses and not
for key hits. If we are not optimizing for key misses, we can choose to not store these filters for that level.
This option is only provided for BlockBasedTable. We skip the filters when we are compacting
Test Plan:
1. Modified db_test toalso run tests with an additonal option (skip_filters_on_last_level)
2. Added another unit test to db_test which specifically tests that filters are being skipped
Reviewers: rven, igor, sdong
Reviewed By: sdong
Subscribers: lgalanis, yoshinorim, MarkCallaghan, rven, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D33717
70 lines
2.5 KiB
C++
70 lines
2.5 KiB
C++
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
#include "table/cuckoo_table_factory.h"
|
|
|
|
#include "db/dbformat.h"
|
|
#include "table/cuckoo_table_builder.h"
|
|
#include "table/cuckoo_table_reader.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
Status CuckooTableFactory::NewTableReader(const ImmutableCFOptions& ioptions,
|
|
const EnvOptions& env_options, const InternalKeyComparator& icomp,
|
|
std::unique_ptr<RandomAccessFile>&& file, uint64_t file_size,
|
|
std::unique_ptr<TableReader>* table) const {
|
|
std::unique_ptr<CuckooTableReader> new_reader(new CuckooTableReader(ioptions,
|
|
std::move(file), file_size, icomp.user_comparator(), nullptr));
|
|
Status s = new_reader->status();
|
|
if (s.ok()) {
|
|
*table = std::move(new_reader);
|
|
}
|
|
return s;
|
|
}
|
|
|
|
TableBuilder* CuckooTableFactory::NewTableBuilder(
|
|
const ImmutableCFOptions& ioptions,
|
|
const InternalKeyComparator& internal_comparator, WritableFile* file,
|
|
const CompressionType, const CompressionOptions&,
|
|
const bool skip_filters) const {
|
|
// Ignore the skipFIlters flag. Does not apply to this file format
|
|
//
|
|
|
|
// TODO: change builder to take the option struct
|
|
return new CuckooTableBuilder(file, table_options_.hash_table_ratio, 64,
|
|
table_options_.max_search_depth, internal_comparator.user_comparator(),
|
|
table_options_.cuckoo_block_size, table_options_.use_module_hash,
|
|
table_options_.identity_as_first_hash, nullptr);
|
|
}
|
|
|
|
std::string CuckooTableFactory::GetPrintableTableOptions() const {
|
|
std::string ret;
|
|
ret.reserve(2000);
|
|
const int kBufferSize = 200;
|
|
char buffer[kBufferSize];
|
|
|
|
snprintf(buffer, kBufferSize, " hash_table_ratio: %lf\n",
|
|
table_options_.hash_table_ratio);
|
|
ret.append(buffer);
|
|
snprintf(buffer, kBufferSize, " max_search_depth: %u\n",
|
|
table_options_.max_search_depth);
|
|
ret.append(buffer);
|
|
snprintf(buffer, kBufferSize, " cuckoo_block_size: %u\n",
|
|
table_options_.cuckoo_block_size);
|
|
ret.append(buffer);
|
|
snprintf(buffer, kBufferSize, " identity_as_first_hash: %d\n",
|
|
table_options_.identity_as_first_hash);
|
|
ret.append(buffer);
|
|
return ret;
|
|
}
|
|
|
|
TableFactory* NewCuckooTableFactory(const CuckooTableOptions& table_options) {
|
|
return new CuckooTableFactory(table_options);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
#endif // ROCKSDB_LITE
|