andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
57fcdc264a
rocksdb/java/rocksjni
History
zawlazaw 57fcdc264a added missing subcodes and improved error message for missing enum values 
Summary:
Java's `Status.SubCode` was out of sync with `include/rocksdb/status.h:SubCode`.

When running out of disc space this led to an `IllegalArgumentException` because of an invalid status code, rather than just returning the corresponding status code without an exception.

I added the missing status codes.

By this, we keep the behaviour of throwing an `IllegalArgumentException` in case of newly added status codes that are defined in C but not in Java.

We could think of an alternative strategy: add in Java another code "UnknownCode" which acts as a catch-all for all those status codes that are not yet mirrored from C to Java. This approach would never throw an exception but simply return a non-OK status-code.

I think the current approach of throwing an Exception in case of a C/Java inconsistency is fine, but if you have some opinion on the alternative strategy, then feel free to comment here.
Closes https://github.com/facebook/rocksdb/pull/3050

Differential Revision: D6129682

Pulled By: sagar0

fbshipit-source-id: f2bf44caad650837cffdcb1f93eb793b43580c66
2017-10-23 16:42:07 -07:00
..
backupablejni.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
backupenginejni.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
cassandra_compactionfilterjni.cc collecting kValue type tombstone 2017-09-18 16:27:12 -07:00
cassandra_value_operator.cc Limit number of merge operands in Cassandra merge operator 2017-10-02 16:11:40 -07:00
checkpoint.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
clock_cache.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
columnfamilyhandle.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
compaction_filter_factory_jnicallback.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
compaction_filter_factory_jnicallback.h Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
compaction_filter_factory.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
compaction_filter.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
compaction_options_fifo.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
compaction_options_universal.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
comparator.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
comparatorjnicallback.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
comparatorjnicallback.h Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
compression_options.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
env_options.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
env.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
filter.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
ingest_external_file_options.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
iterator.cc Add iterator's SeekForPrev functionality to the java-api 2017-09-12 10:56:29 -07:00
jnicallback.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
jnicallback.h Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
loggerjnicallback.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
loggerjnicallback.h Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
lru_cache.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
memtablejni.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
merge_operator.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
options_util.cc Expose LoadLatestOptions, LoadOptionsFromFile and GetLatestOptionsFileName APIs in RocksJava 2017-09-21 17:29:13 -07:00
options.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
portal.h added missing subcodes and improved error message for missing enum values 2017-10-23 16:42:07 -07:00
ratelimiterjni.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
remove_emptyvalue_compactionfilterjni.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
restorejni.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
rocks_callback_object.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
rocksdb_exception_test.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
rocksjni.cc DestroyDB API 2017-09-26 16:42:11 -07:00
slice.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
snapshot.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
sst_file_writerjni.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
statistics.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
statisticsjni.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
statisticsjni.h Change RocksDB License 2017-07-15 16:11:23 -07:00
table.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
transaction_log.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
ttl.cc Change RocksDB License 2017-07-15 16:11:23 -07:00
write_batch_test.cc Gcc 7 ParsedInternalKey replace memset with clear function. 2017-07-24 11:31:15 -07:00
write_batch_with_index.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
write_batch.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
writebatchhandlerjnicallback.cc Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00
writebatchhandlerjnicallback.h Added CompactionFilterFactory support to RocksJava 2017-10-12 11:12:16 -07:00