cfcf045acc
Summary: The ObjectRegistry class replaces the Registrar and NewCustomObjects. Objects are registered with the registry by Type (the class must implement the static const char *Type() method). This change is necessary for a few reasons: - By having a class (rather than static template instances), the class can be passed between compilation units, meaning that objects could be registered and shared from a dynamic library with an executable. - By having a class with instances, different units could have different objects registered. This could be useful if, for example, one Option allowed for a dynamic library and one did not. When combined with some other PRs (being able to load shared libraries, a Configurable interface to configure objects to/from string), this code will allow objects in external shared libraries to be added to a RocksDB image at run-time, rather than requiring every new extension to be built into the main library and called explicitly by every program. Test plan (on riversand963's devserver) ``` $COMPILE_WITH_ASAN=1 make -j32 all && sleep 1 && make check ``` All tests pass. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5293 Differential Revision: D16363396 Pulled By: riversand963 fbshipit-source-id: fbe4acb615bfc11103eef40a0b288845791c0180
175 lines
5.8 KiB
C++
175 lines
5.8 KiB
C++
// Copyright (c) 2016-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
#include "rocksdb/utilities/object_registry.h"
|
|
#include "test_util/testharness.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class EnvRegistryTest : public testing::Test {
|
|
public:
|
|
static int num_a, num_b;
|
|
};
|
|
|
|
int EnvRegistryTest::num_a = 0;
|
|
int EnvRegistryTest::num_b = 0;
|
|
static FactoryFunc<Env> test_reg_a = ObjectLibrary::Default()->Register<Env>(
|
|
"a://.*",
|
|
[](const std::string& /*uri*/, std::unique_ptr<Env>* /*env_guard*/,
|
|
std::string* /* errmsg */) {
|
|
++EnvRegistryTest::num_a;
|
|
return Env::Default();
|
|
});
|
|
|
|
static FactoryFunc<Env> test_reg_b = ObjectLibrary::Default()->Register<Env>(
|
|
"b://.*", [](const std::string& /*uri*/, std::unique_ptr<Env>* env_guard,
|
|
std::string* /* errmsg */) {
|
|
++EnvRegistryTest::num_b;
|
|
// Env::Default() is a singleton so we can't grant ownership directly to
|
|
// the caller - we must wrap it first.
|
|
env_guard->reset(new EnvWrapper(Env::Default()));
|
|
return env_guard->get();
|
|
});
|
|
|
|
TEST_F(EnvRegistryTest, Basics) {
|
|
std::string msg;
|
|
std::unique_ptr<Env> env_guard;
|
|
auto registry = ObjectRegistry::NewInstance();
|
|
auto res = registry->NewObject<Env>("a://test", &env_guard, &msg);
|
|
ASSERT_NE(res, nullptr);
|
|
ASSERT_EQ(env_guard, nullptr);
|
|
ASSERT_EQ(1, num_a);
|
|
ASSERT_EQ(0, num_b);
|
|
|
|
res = registry->NewObject<Env>("b://test", &env_guard, &msg);
|
|
ASSERT_NE(res, nullptr);
|
|
ASSERT_NE(env_guard, nullptr);
|
|
ASSERT_EQ(1, num_a);
|
|
ASSERT_EQ(1, num_b);
|
|
|
|
res = registry->NewObject<Env>("c://test", &env_guard, &msg);
|
|
ASSERT_EQ(res, nullptr);
|
|
ASSERT_EQ(env_guard, nullptr);
|
|
ASSERT_EQ(1, num_a);
|
|
ASSERT_EQ(1, num_b);
|
|
}
|
|
|
|
TEST_F(EnvRegistryTest, LocalRegistry) {
|
|
std::string msg;
|
|
std::unique_ptr<Env> guard;
|
|
auto registry = ObjectRegistry::NewInstance();
|
|
std::shared_ptr<ObjectLibrary> library = std::make_shared<ObjectLibrary>();
|
|
registry->AddLibrary(library);
|
|
library->Register<Env>(
|
|
"test-local",
|
|
[](const std::string& /*uri*/, std::unique_ptr<Env>* /*guard */,
|
|
std::string* /* errmsg */) { return Env::Default(); });
|
|
|
|
ObjectLibrary::Default()->Register<Env>(
|
|
"test-global",
|
|
[](const std::string& /*uri*/, std::unique_ptr<Env>* /*guard */,
|
|
std::string* /* errmsg */) { return Env::Default(); });
|
|
|
|
ASSERT_EQ(
|
|
ObjectRegistry::NewInstance()->NewObject<Env>("test-local", &guard, &msg),
|
|
nullptr);
|
|
ASSERT_NE(
|
|
ObjectRegistry::NewInstance()->NewObject("test-global", &guard, &msg),
|
|
nullptr);
|
|
ASSERT_NE(registry->NewObject<Env>("test-local", &guard, &msg), nullptr);
|
|
ASSERT_NE(registry->NewObject<Env>("test-global", &guard, &msg), nullptr);
|
|
}
|
|
|
|
TEST_F(EnvRegistryTest, CheckShared) {
|
|
std::shared_ptr<Env> shared;
|
|
std::shared_ptr<ObjectRegistry> registry = ObjectRegistry::NewInstance();
|
|
std::shared_ptr<ObjectLibrary> library = std::make_shared<ObjectLibrary>();
|
|
registry->AddLibrary(library);
|
|
library->Register<Env>(
|
|
"unguarded",
|
|
[](const std::string& /*uri*/, std::unique_ptr<Env>* /*guard */,
|
|
std::string* /* errmsg */) { return Env::Default(); });
|
|
|
|
library->Register<Env>(
|
|
"guarded", [](const std::string& /*uri*/, std::unique_ptr<Env>* guard,
|
|
std::string* /* errmsg */) {
|
|
guard->reset(new EnvWrapper(Env::Default()));
|
|
return guard->get();
|
|
});
|
|
|
|
ASSERT_OK(registry->NewSharedObject<Env>("guarded", &shared));
|
|
ASSERT_NE(shared, nullptr);
|
|
shared.reset();
|
|
ASSERT_NOK(registry->NewSharedObject<Env>("unguarded", &shared));
|
|
ASSERT_EQ(shared, nullptr);
|
|
}
|
|
|
|
TEST_F(EnvRegistryTest, CheckStatic) {
|
|
Env* env = nullptr;
|
|
std::shared_ptr<ObjectRegistry> registry = ObjectRegistry::NewInstance();
|
|
std::shared_ptr<ObjectLibrary> library = std::make_shared<ObjectLibrary>();
|
|
registry->AddLibrary(library);
|
|
library->Register<Env>(
|
|
"unguarded",
|
|
[](const std::string& /*uri*/, std::unique_ptr<Env>* /*guard */,
|
|
std::string* /* errmsg */) { return Env::Default(); });
|
|
|
|
library->Register<Env>(
|
|
"guarded", [](const std::string& /*uri*/, std::unique_ptr<Env>* guard,
|
|
std::string* /* errmsg */) {
|
|
guard->reset(new EnvWrapper(Env::Default()));
|
|
return guard->get();
|
|
});
|
|
|
|
ASSERT_NOK(registry->NewStaticObject<Env>("guarded", &env));
|
|
ASSERT_EQ(env, nullptr);
|
|
env = nullptr;
|
|
ASSERT_OK(registry->NewStaticObject<Env>("unguarded", &env));
|
|
ASSERT_NE(env, nullptr);
|
|
}
|
|
|
|
TEST_F(EnvRegistryTest, CheckUnique) {
|
|
std::unique_ptr<Env> unique;
|
|
std::shared_ptr<ObjectRegistry> registry = ObjectRegistry::NewInstance();
|
|
std::shared_ptr<ObjectLibrary> library = std::make_shared<ObjectLibrary>();
|
|
registry->AddLibrary(library);
|
|
library->Register<Env>(
|
|
"unguarded",
|
|
[](const std::string& /*uri*/, std::unique_ptr<Env>* /*guard */,
|
|
std::string* /* errmsg */) { return Env::Default(); });
|
|
|
|
library->Register<Env>(
|
|
"guarded", [](const std::string& /*uri*/, std::unique_ptr<Env>* guard,
|
|
std::string* /* errmsg */) {
|
|
guard->reset(new EnvWrapper(Env::Default()));
|
|
return guard->get();
|
|
});
|
|
|
|
ASSERT_OK(registry->NewUniqueObject<Env>("guarded", &unique));
|
|
ASSERT_NE(unique, nullptr);
|
|
unique.reset();
|
|
ASSERT_NOK(registry->NewUniqueObject<Env>("unguarded", &unique));
|
|
ASSERT_EQ(unique, nullptr);
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
|
|
int main(int argc, char** argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|
|
|
|
#else // ROCKSDB_LITE
|
|
#include <stdio.h>
|
|
|
|
int main(int /*argc*/, char** /*argv*/) {
|
|
fprintf(stderr, "SKIPPED as EnvRegistry is not supported in ROCKSDB_LITE\n");
|
|
return 0;
|
|
}
|
|
|
|
#endif // ROCKSDB_LITE
|