c7aedf1b48
Summary: * Add missing unit test for schema stability of FileChecksumGenCrc32c (previously was only comparing to itself) * A lot of clarifying comments * Add some assertions for preconditions * Rename WritableFileWriter::CalculateFileChecksum -> UpdateFileChecksum * Simplify FileChecksumGenCrc32c with shared functions * Implement EndianSwapValue to replace unused EndianTransform And incidentally since I had trouble with 'make check-format' GitHub action disagreeing with local run, * Output full diagnostic information when 'make check-format' fails in CI Pull Request resolved: https://github.com/facebook/rocksdb/pull/6861 Test Plan: new unit test passes before & after other changes Reviewed By: zhichao-cao Differential Revision: D21667115 Pulled By: pdillinger fbshipit-source-id: 6a99970f87605aa024fa540c78cd519ff322c3e6
42 lines
1.1 KiB
YAML
42 lines
1.1 KiB
YAML
name: Check buck targets and code format
|
|
on: [push, pull_request]
|
|
jobs:
|
|
check:
|
|
name: Check TARGETS file and code format
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout feature branch
|
|
uses: actions/checkout@v2
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Fetch from upstream
|
|
run: |
|
|
git remote add upstream https://github.com/facebook/rocksdb.git && git fetch upstream
|
|
|
|
- name: Where am I
|
|
run: |
|
|
echo git status && git status
|
|
echo "git remote -v" && git remote -v
|
|
echo git branch && git branch
|
|
|
|
- name: Setup Python
|
|
uses: actions/setup-python@v1
|
|
|
|
- name: Install Dependencies
|
|
run: python -m pip install --upgrade pip
|
|
|
|
- name: Install argparse
|
|
run: pip install argparse
|
|
|
|
- name: Download clang-format-diff.py
|
|
uses: wei/wget@v1
|
|
with:
|
|
args: https://raw.githubusercontent.com/llvm-mirror/clang/master/tools/clang-format/clang-format-diff.py
|
|
|
|
- name: Check format
|
|
run: VERBOSE_CHECK=1 make check-format
|
|
|
|
- name: Compare buckify output
|
|
run: make check-buck-targets
|