andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5e2db3b434
rocksdb/db
History
sdong 5e2db3b434 PlainTableIterator not to store copied key in std::string 
Summary:
Move PlainTableIterator's copied key from std::string local buffer to avoid paying the extra costs in std::string related to sharing. Reuse the same buffer class in DbIter. Move the class to dbformat.h.

This patch improves iterator performance significantly. Running this benchmark:

./table_reader_bench --num_keys2=17 --iterator --plain_table --time_unit=nanosecond

The average latency is improved to about 750 nanoseconds from 1100 nanoseconds.

Test Plan:
Add a unit test.
make all check

Reviewers: haobo, ljin

Reviewed By: haobo

CC: igor, yhchiang, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D17547
2014-04-07 19:06:09 -07:00
..
builder.cc Enhance partial merge to support multiple arguments 2014-03-24 17:57:13 -07:00
builder.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
c_test.c [C-API] added "rocksdb_options_set_plain_table_factory" to make it possible to use plain table factory 2014-04-03 10:47:37 +02:00
c.cc [C-API] implemented more options 2014-04-03 10:47:37 +02:00
column_family_test.cc Merge branch 'master' into columnfamilies 2014-03-31 13:39:24 -07:00
column_family.cc Simplify cleanup of dead (refcount == 0) column families 2014-04-07 14:31:02 -07:00
column_family.h Simplify cleanup of dead (refcount == 0) column families 2014-04-07 14:31:02 -07:00
compaction_picker.cc Merge branch 'master' into columnfamilies 2014-04-07 11:31:11 -07:00
compaction_picker.h [CF] Code cleanup part 1 2014-03-12 09:56:53 -07:00
compaction.cc Merge branch 'master' into columnfamilies 2014-03-19 17:22:20 -07:00
compaction.h Merge branch 'master' into columnfamilies 2014-02-12 14:01:30 -08:00
corruption_test.cc Some small cleaning up to make some compiling environment happy 2014-03-26 18:11:41 -07:00
db_bench.cc make hash_link_list Node's key space consecutively followed at the end 2014-04-04 15:37:28 -07:00
db_filesnapshot.cc Simplify cleanup of dead (refcount == 0) column families 2014-04-07 14:31:02 -07:00
db_impl_readonly.cc Merge branch 'master' into columnfamilies 2014-03-20 14:41:37 -07:00
db_impl_readonly.h [CF] Rethinking ColumnFamilyHandle and fix to dropping column families 2014-02-12 13:47:09 -08:00
db_impl.cc Small final fixes before merge 2014-04-07 15:38:53 -07:00
db_impl.h CallFlushDuringCompaction 2014-04-07 15:03:15 -07:00
db_iter.cc PlainTableIterator not to store copied key in std::string 2014-04-07 19:06:09 -07:00
db_iter.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
db_stats_logger.cc [CF] Rethinking ColumnFamilyHandle and fix to dropping column families 2014-02-12 13:47:09 -08:00
db_test.cc Merge branch 'master' into columnfamilies 2014-04-07 11:31:11 -07:00
dbformat_test.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
dbformat.cc DBIter to use static allocated char array for saved_key_ (if it is not too long) 2014-04-01 16:43:11 -07:00
dbformat.h PlainTableIterator not to store copied key in std::string 2014-04-07 19:06:09 -07:00
deletefile_test.cc Start DeleteFileTest with clean plate 2013-11-15 16:30:23 -08:00
filename_test.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
filename.cc Unify DeleteFile and DeleteWalFiles 2013-10-25 08:32:14 -07:00
filename.h Unify DeleteFile and DeleteWalFiles 2013-10-25 08:32:14 -07:00
internal_stats.cc Merge branch 'master' into columnfamilies 2014-03-31 13:39:24 -07:00
internal_stats.h Merge branch 'master' into columnfamilies 2014-03-31 13:39:24 -07:00
log_format.h Some minor refactoring on the code 2014-01-02 16:32:31 -08:00
log_reader.cc Make Log::Reader more robust 2014-02-28 13:19:47 -08:00
log_reader.h Fix UnmarkEOF for partial blocks 2014-01-27 14:49:10 -08:00
log_test.cc Make it compile on Debian/GCC 4.7 2014-03-14 22:44:35 +00:00
log_writer.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
log_writer.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
memtable_list.cc Merge branch 'master' into columnfamilies 2014-04-07 11:31:11 -07:00
memtable_list.h Merge branch 'master' into columnfamilies 2014-04-07 11:31:11 -07:00
memtable.cc Merge branch 'master' into columnfamilies 2014-04-07 11:31:11 -07:00
memtable.h Merge branch 'master' into columnfamilies 2014-03-13 13:21:20 -07:00
merge_context.h Enhance partial merge to support multiple arguments 2014-03-24 17:57:13 -07:00
merge_helper.cc Fix the bug in MergeUtil which causes mixing values of different keys. 2014-03-27 16:15:25 -07:00
merge_helper.h [rocksdb] new CompactionFilterV2 API 2014-03-24 20:47:53 -07:00
merge_operator.cc Some small cleaning up to make some compiling environment happy 2014-03-26 18:11:41 -07:00
merge_test.cc Enhance partial merge to support multiple arguments 2014-03-24 17:57:13 -07:00
perf_context_test.cc Missing includes 2014-03-14 13:02:20 -07:00
plain_table_db_test.cc PlainTableIterator not to store copied key in std::string 2014-04-07 19:06:09 -07:00
prefix_filter_iterator.h Moving Some includes from options.h to forward declaration 2014-01-24 17:16:22 -08:00
prefix_test.cc Fix HashSkipList and HashLinkedList SIGSEGV 2014-03-14 10:02:04 -07:00
repair.cc Merge branch 'master' into columnfamilies 2014-03-18 13:24:27 -07:00
simple_table_db_test.cc Make table properties shareable 2014-02-07 19:26:49 -08:00
skiplist_test.cc Clean up arena API 2014-01-30 22:10:10 -08:00
skiplist.h Consolidate SliceTransform object ownership 2014-03-10 12:56:46 -07:00
snapshot.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
table_cache.cc Merge branch 'master' into columnfamilies 2014-03-31 13:39:24 -07:00
table_cache.h Merge branch 'master' into columnfamilies 2014-04-07 11:31:11 -07:00
table_properties_collector_test.cc Fix problem 3 for issue #80 2014-02-11 17:52:18 -08:00
table_properties_collector.cc Extract metaindex block from block-based table 2013-12-05 16:34:16 -08:00
table_properties_collector.h Extract metaindex block from block-based table 2013-12-05 16:34:16 -08:00
tailing_iter.cc Merge branch 'master' into columnfamilies 2014-03-10 17:26:09 -07:00
tailing_iter.h [column families] Iterator and MultiGet 2014-02-03 17:44:40 -08:00
transaction_log_impl.cc Revert "Fix bad merge of D16791 and D16767" 2014-03-12 09:37:43 -07:00
transaction_log_impl.h Revert "Fix bad merge of D16791 and D16767" 2014-03-12 09:37:43 -07:00
version_edit_test.cc [CF] Dont reuse dropped column family IDs 2014-03-05 12:13:44 -08:00
version_edit.cc Merge branch 'master' into columnfamilies 2014-03-31 13:39:24 -07:00
version_edit.h Merge branch 'master' into columnfamilies 2014-03-31 13:39:24 -07:00
version_set_test.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
version_set.cc Merge branch 'master' into columnfamilies 2014-04-07 11:31:11 -07:00
version_set.h Merge branch 'master' into columnfamilies 2014-03-19 17:22:20 -07:00
write_batch_internal.h [CF] Code cleanup part 1 2014-03-12 09:56:53 -07:00
write_batch_test.cc Change WriteBatch interface 2014-03-14 13:40:06 -07:00
write_batch.cc [CF] WriteBatch to take in ColumnFamilyHandle 2014-03-14 11:30:14 -07:00