andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5f5e5fc2e9
rocksdb/table
History
Siying Dong 9718c790ec [Performance Branch] Fix a bug of PlainTable when building indexes 
Summary:
PlainTable now has a bug of the ordering of indexes for the prefixes in the same bucket. I thought std::map guaranteed key order but it didn't, probably because I didn't use it properly. But seems to me that we don't need to make extra sorting as input prefixes are already sorted. Found by problem by running leaf4 against plain table. Replace the map with a vector. It should performs better too.

After the fix, leaf4 unit tests are passing.

Test Plan:
run plain_table_db_test
Also going to run db_test with plain table in the uncommitted branch.

Reviewers: haobo, kailiu

Reviewed By: haobo

CC: nkg-, leveldb

Differential Revision: https://reviews.facebook.net/D14649
2013-12-12 22:22:35 -08:00
..
block_based_table_builder.cc Merge branch 'master' into performance 2013-12-06 14:15:42 -08:00
block_based_table_builder.h Parameterize table magic number 2013-12-04 15:17:40 -08:00
block_based_table_factory.cc Add TableOptions for BlockBasedTableFactory 2013-11-20 18:42:12 -08:00
block_based_table_factory.h Add TableOptions for BlockBasedTableFactory 2013-11-20 18:42:12 -08:00
block_based_table_reader.cc Merge branch 'master' into performance 2013-12-06 14:15:42 -08:00
block_based_table_reader.h Merge branch 'master' into performance 2013-12-06 14:15:42 -08:00
block_builder.cc Make the options in table_builder/block_builder less misleading 2013-11-16 23:21:15 -08:00
block_builder.h Make the options in table_builder/block_builder less misleading 2013-11-16 23:21:15 -08:00
block_test.cc Make the options in table_builder/block_builder less misleading 2013-11-16 23:21:15 -08:00
block.cc Implement a compressed block cache. 2013-11-01 14:31:35 -07:00
block.h Implement a compressed block cache. 2013-11-01 14:31:35 -07:00
filter_block_test.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
filter_block.cc Fix two nasty use-after-free-bugs 2013-11-19 21:01:48 -08:00
filter_block.h Add the index/filter block cache 2013-11-12 22:46:51 -08:00
flush_block_policy.cc Don't not suggest flushing data when data block is still empty 2013-11-11 21:05:16 -08:00
format.cc Generalize footer reading from file 2013-12-04 16:35:48 -08:00
format.h Generalize footer reading from file 2013-12-04 16:35:48 -08:00
iter_heap.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
iterator_wrapper.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
iterator.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
merger.cc Revert "Allow users to profile a query and see bottleneck of the query" 2013-11-21 17:40:39 -08:00
merger.h Revert "Allow users to profile a query and see bottleneck of the query" 2013-11-21 17:40:39 -08:00
meta_blocks.cc Extract metaindex block from block-based table 2013-12-05 16:34:16 -08:00
meta_blocks.h Extract metaindex block from block-based table 2013-12-05 16:34:16 -08:00
plain_table_builder.cc Fix a bunch of mac compilation issues in performance branch 2013-12-04 23:00:33 -08:00
plain_table_builder.h Fix a bunch of mac compilation issues in performance branch 2013-12-04 23:00:33 -08:00
plain_table_factory.cc Add BloomFilter to PlainTableIterator::Seek() 2013-11-21 22:26:39 -08:00
plain_table_reader.cc [Performance Branch] Fix a bug of PlainTable when building indexes 2013-12-12 22:22:35 -08:00
plain_table_reader.h [RocksDB Performance Branch] A more customized index in PlainTableReader 2013-12-04 13:43:45 -08:00
table_properties.cc Extract metaindex block from block-based table 2013-12-05 16:34:16 -08:00
table_reader_bench.cc [For Performance Branch] Bloom filter in PlainTableIterator::Seek() - Update 1 2013-11-21 23:33:45 -08:00
table_test.cc Fix #26 by putting the implementation of CreateDBStatistics() to a cc file 2013-12-05 22:29:03 -08:00
two_level_iterator.cc Fix slow no-io iterator 2013-11-06 14:11:52 -08:00
two_level_iterator.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00