Andrew Kryczka 710411aea6 fix asan/valgrind for TableCache cleanup ...

Summary:
Breaking commit: d12691b86fb788f0ee7180db626c4ea2445fa976

In the above commit, I moved the `TableCache` cleanup logic from `Version` destructor into `PurgeObsoleteFiles`. I missed cleaning up `TableCache` entries for the current `Version` during DB destruction.

This PR adds that logic to `VersionSet` destructor. One unfortunate side effect is now we're potentially deleting `TableReader`s after `column_family_set_.reset()`, which means we can't call `BlockBasedTableReader::Close` a second time as the block cache might already be destroyed.
Closes https://github.com/facebook/rocksdb/pull/2662

Differential Revision: D5515108

Pulled By: ajkr

fbshipit-source-id: 2cb820e19aa813e0d258d17f76b2d7b6b7ee0b18

2017-07-27 20:28:04 -07:00

..

adaptive_table_factory.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

adaptive_table_factory.h

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

block_based_filter_block_test.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_based_filter_block.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

block_based_filter_block.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_based_table_builder.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

block_based_table_builder.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_based_table_factory.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

block_based_table_factory.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_based_table_reader.cc

fix asan/valgrind for TableCache cleanup

2017-07-27 20:28:04 -07:00

block_based_table_reader.h

fix asan/valgrind for TableCache cleanup

2017-07-27 20:28:04 -07:00

block_builder.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_builder.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_prefix_index.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_prefix_index.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

block_test.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

block.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

block.h

table/block.h: change memset

2017-07-17 10:41:56 -07:00

bloom_block.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

bloom_block.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

cleanable_test.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

cuckoo_table_builder_test.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

cuckoo_table_builder.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

cuckoo_table_builder.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

cuckoo_table_factory.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

cuckoo_table_factory.h

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

cuckoo_table_reader_test.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

cuckoo_table_reader.cc

remove unnecessary internal_comparator param in newIterator

2017-07-27 14:30:42 -07:00

cuckoo_table_reader.h

remove unnecessary internal_comparator param in newIterator

2017-07-27 14:30:42 -07:00

filter_block.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

flush_block_policy.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

format.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

format.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

full_filter_bits_builder.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

full_filter_block_test.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

full_filter_block.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

full_filter_block.h

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

get_context.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

get_context.h

enable PinnableSlice for RowCache

2017-07-17 15:08:30 -07:00

index_builder.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

index_builder.h

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

internal_iterator.h

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

iter_heap.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

iterator_wrapper.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

iterator.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

merger_test.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

merging_iterator.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

merging_iterator.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

meta_blocks.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

meta_blocks.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

mock_table.cc

remove unnecessary internal_comparator param in newIterator

2017-07-27 14:30:42 -07:00

mock_table.h

remove unnecessary internal_comparator param in newIterator

2017-07-27 14:30:42 -07:00

partitioned_filter_block_test.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

partitioned_filter_block.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

partitioned_filter_block.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

persistent_cache_helper.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

persistent_cache_helper.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

persistent_cache_options.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

plain_table_builder.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

plain_table_builder.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

plain_table_factory.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

plain_table_factory.h

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

plain_table_index.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

plain_table_index.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

plain_table_key_coding.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

plain_table_key_coding.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

plain_table_reader.cc

remove unnecessary internal_comparator param in newIterator

2017-07-27 14:30:42 -07:00

plain_table_reader.h

remove unnecessary internal_comparator param in newIterator

2017-07-27 14:30:42 -07:00

scoped_arena_iterator.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

sst_file_writer_collectors.h

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

sst_file_writer.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

table_builder.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

table_properties_internal.h

Change RocksDB License

2017-07-15 16:11:23 -07:00

table_properties.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

table_reader_bench.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

table_reader.h

remove unnecessary internal_comparator param in newIterator

2017-07-27 14:30:42 -07:00

table_test.cc

Revert "comment out unused parameters"

2017-07-21 18:26:26 -07:00

two_level_iterator.cc

Change RocksDB License

2017-07-15 16:11:23 -07:00

two_level_iterator.h

Change RocksDB License

2017-07-15 16:11:23 -07:00