ec7a944360
Summary: We occasionally get write stalls (>1s Write() calls) on HDD under read load. The following timers explain almost all of the stalls: - perf_context.db_mutex_lock_nanos - perf_context.db_condition_wait_nanos - iostats_context.open_time - iostats_context.allocate_time - iostats_context.write_time - iostats_context.range_sync_time - iostats_context.logger_time In my experiments each of these occasionally takes >1s on write path under some workload. There are rare cases when Write() takes long but none of these takes long. Test Plan: Added code to our application to write the listed timings to log for slow writes. They usually add up to almost exactly the time Write() call took. Reviewers: rven, yhchiang, sdong Reviewed By: sdong Subscribers: march, dhruba, tnovak Differential Revision: https://reviews.facebook.net/D39177
64 lines
2.0 KiB
C
64 lines
2.0 KiB
C
// Copyright (c) 2014, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
//
|
|
#pragma once
|
|
#include "rocksdb/iostats_context.h"
|
|
#include "util/perf_step_timer.h"
|
|
|
|
#ifndef IOS_CROSS_COMPILE
|
|
|
|
// increment a specific counter by the specified value
|
|
#define IOSTATS_ADD(metric, value) \
|
|
(iostats_context.metric += value)
|
|
|
|
// Increase metric value only when it is positive
|
|
#define IOSTATS_ADD_IF_POSITIVE(metric, value) \
|
|
if (value > 0) { IOSTATS_ADD(metric, value); }
|
|
|
|
// reset a specific counter to zero
|
|
#define IOSTATS_RESET(metric) \
|
|
(iostats_context.metric = 0)
|
|
|
|
// reset all counters to zero
|
|
#define IOSTATS_RESET_ALL() \
|
|
(iostats_context.Reset())
|
|
|
|
#define IOSTATS_SET_THREAD_POOL_ID(value) \
|
|
(iostats_context.thread_pool_id = value)
|
|
|
|
#define IOSTATS_THREAD_POOL_ID() \
|
|
(iostats_context.thread_pool_id)
|
|
|
|
#define IOSTATS(metric) \
|
|
(iostats_context.metric)
|
|
|
|
// Stop the timer and update the metric
|
|
#define IOSTATS_TIMER_STOP(metric) \
|
|
iostats_step_timer_ ## metric.Stop();
|
|
|
|
#define IOSTATS_TIMER_START(metric) \
|
|
iostats_step_timer_ ## metric.Start();
|
|
|
|
// Declare and set start time of the timer
|
|
#define IOSTATS_TIMER_GUARD(metric) \
|
|
PerfStepTimer iostats_step_timer_ ## metric(&(iostats_context.metric)); \
|
|
iostats_step_timer_ ## metric.Start();
|
|
|
|
#else // IOS_CROSS_COMPILE
|
|
|
|
#define IOSTATS_ADD(metric, value)
|
|
#define IOSTATS_ADD_IF_POSITIVE(metric, value)
|
|
#define IOSTATS_RESET(metric)
|
|
#define IOSTATS_RESET_ALL()
|
|
#define IOSTATS_SET_THREAD_POOL_ID(value)
|
|
#define IOSTATS_THREAD_POOL_ID()
|
|
#define IOSTATS(metric) 0
|
|
|
|
#define IOSTATS_TIMER_GUARD(metric)
|
|
#define IOSTATS_TIMER_STOP(metric)
|
|
#define IOSTATS_TIMER_START(metric)
|
|
|
|
#endif // IOS_CROSS_COMPILE
|