sdong 079e50d2ba Disallow BlockBasedTableBuilder to set status from non-OK (#6776) ... Summary: There is no systematic mechanism to prevent BlockBasedTableBuilder's status to be set from non-OK to OK. Adding a mechanism to force this will help us prevent failures in the future. The solution is to only make it possible to set the status code if the status code to set is not OK. Since the status code passed to CompressAndVerifyBlock() is changed, a mini refactoring is done too so that the output arguments are changed from reference to pointers, based on Google C++ Style. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6776 Test Plan: Run all existing test. Reviewed By: pdillinger Differential Revision: D21314382 fbshipit-source-id: 27000c10f1e4c121661e026548d6882066409375		2020-04-30 15:37:03 -07:00
..
binary_search_index_reader.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
binary_search_index_reader.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
block_based_filter_block_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_filter_block.cc	Silence false alarms in db_stress fault injection (#6741)	2020-04-24 13:06:12 -07:00
block_based_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_based_table_builder.cc	Disallow BlockBasedTableBuilder to set status from non-OK (#6776)	2020-04-30 15:37:03 -07:00
block_based_table_builder.h	Disallow BlockBasedTableBuilder to set status from non-OK (#6776)	2020-04-30 15:37:03 -07:00
block_based_table_factory.cc	Add Functions to OptionTypeInfo (#6422)	2020-04-28 18:04:26 -07:00
block_based_table_factory.h	Add a ConfigOptions for use in comparing objects and converting to/from strings (#6389)	2020-04-21 17:38:17 -07:00
block_based_table_iterator.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
block_based_table_iterator.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621)	2020-04-15 17:40:44 -07:00
block_based_table_reader_impl.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
block_based_table_reader.cc	Pass a timeout to FileSystem for random reads (#6751)	2020-04-30 14:50:39 -07:00
block_based_table_reader.h	Stats for redundant insertions into block cache (#6681)	2020-04-27 13:20:27 -07:00
block_builder.cc	Add pipelined & parallel compression optimization (#6262)	2020-04-01 16:40:18 -07:00
block_builder.h	Add pipelined & parallel compression optimization (#6262)	2020-04-01 16:40:18 -07:00
block_prefetcher.cc	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_prefetcher.h	De-template block based table iterator (#6531)	2020-03-16 12:20:50 -07:00
block_prefix_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_prefix_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block_test.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
block_type.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
block.cc	Fix some typos in code comments (#6733)	2020-04-23 12:28:49 -07:00
block.h	fix comparison count for format_version=3 indexes (#6650)	2020-04-13 11:18:37 -07:00
cachable_entry.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_footer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_footer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_hash_index_test.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
data_block_hash_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
data_block_hash_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_block_reader_common.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_block_reader_common.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_block.h	Fix iterator reading filter block despite read_tier == kBlockCacheTier (#6562)	2020-03-26 15:21:26 -07:00
filter_policy_internal.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
filter_policy.cc	Add Functions to OptionTypeInfo (#6422)	2020-04-28 18:04:26 -07:00
flush_block_policy.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
flush_block_policy.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
full_filter_block_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
full_filter_block.cc	Basic MultiGet support for partitioned filters (#6757)	2020-04-28 14:49:34 -07:00
full_filter_block.h	Fix iterator reading filter block despite read_tier == kBlockCacheTier (#6562)	2020-03-26 15:21:26 -07:00
hash_index_reader.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
hash_index_reader.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
index_builder.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
index_builder.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
index_reader_common.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
index_reader_common.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
mock_block_based_table.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
parsed_full_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
parsed_full_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
partitioned_filter_block_test.cc	Fix range deletion tombstone ingestion with global seqno (#6429)	2020-02-25 15:31:48 -08:00
partitioned_filter_block.cc	Basic MultiGet support for partitioned filters (#6757)	2020-04-28 14:49:34 -07:00
partitioned_filter_block.h	Basic MultiGet support for partitioned filters (#6757)	2020-04-28 14:49:34 -07:00
partitioned_index_iterator.cc	Fix regression bug in partitioned index reseek caused by #6531 (#6551)	2020-03-17 12:33:10 -07:00
partitioned_index_iterator.h	Fix compiler warning treated as error (#6547)	2020-03-17 09:59:28 -07:00
partitioned_index_reader.cc	Silence false alarms in db_stress fault injection (#6741)	2020-04-24 13:06:12 -07:00
partitioned_index_reader.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
reader_common.cc	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
reader_common.h	Divide block_based_table_reader.cc (#6527)	2020-03-12 21:41:50 -07:00
uncompression_dict_reader.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
uncompression_dict_reader.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00