Igor Canadi 5142b37000 Fix a group commit bug in LogAndApply ...

Summary:
EncodeTo(&record) does not overwrite, it appends to it.

This means that group commit log and apply will look something like:
record1
record1record2
record1record2record3

I'm surprised this didn't show up in production, but I think the reason is that MANIFEST group commit almost never happens.

This bug turned up in column family work, where opening a database failed with "adding a same column family twice".

Test Plan: Tested the change in column family branch and observed that the problem is gone (with db_stress)

Reviewers: dhruba, haobo

Reviewed By: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D16461

2014-03-03 17:10:43 -08:00

..

builder.cc

Put table factory back to public api

2014-02-03 19:51:20 -08:00

builder.h

[Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte.

2014-02-03 12:19:30 -08:00

c_test.c

Fix C API

2014-02-24 15:15:34 -08:00

c.cc

A few more C API functions.

2014-02-25 10:32:28 -08:00

compaction_picker.cc

CompactionContext to include is_manual_compaction

2014-02-12 12:24:18 -08:00

compaction_picker.h

Make VersionSet::ReduceNumberOfLevels() static

2014-01-24 14:57:04 -08:00

compaction.cc

CompactionContext to include is_manual_compaction

2014-02-12 12:24:18 -08:00

compaction.h

CompactionContext to include is_manual_compaction

2014-02-12 12:24:18 -08:00

corruption_test.cc

Fix corruption_test failure caused by auto-enablement of checksum verification.

2014-01-31 17:16:38 -08:00

db_bench.cc

expose wal_dir in db_bench

2014-02-25 10:43:46 -08:00

db_filesnapshot.cc

Move functions from VersionSet to Version

2014-01-15 16:18:04 -08:00

db_impl_readonly.cc

use super_version in NewIterator() and MultiGet() function

2014-02-03 13:13:36 -08:00

db_impl_readonly.h

CompactRange() to return status

2014-01-23 16:41:46 -08:00

db_impl.cc

Make Log::Reader more robust

2014-02-28 13:19:47 -08:00

db_impl.h

Add ReadOptions to TransactionLogIterator.

2014-02-28 11:50:36 -08:00

db_iter.cc

[Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte.

2014-02-03 12:19:30 -08:00

db_iter.h

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

db_stats_logger.cc

Move functions from VersionSet to Version

2014-01-15 16:18:04 -08:00

db_test.cc

Add ReadOptions to TransactionLogIterator.

2014-02-28 11:50:36 -08:00

dbformat_test.cc

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

dbformat.cc

[Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte.

2014-02-03 12:19:30 -08:00

dbformat.h

[Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte.

2014-02-03 12:19:30 -08:00

deletefile_test.cc

Start DeleteFileTest with clean plate

2013-11-15 16:30:23 -08:00

filename_test.cc

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

filename.cc

Unify DeleteFile and DeleteWalFiles

2013-10-25 08:32:14 -07:00

filename.h

Unify DeleteFile and DeleteWalFiles

2013-10-25 08:32:14 -07:00

internal_stats.cc

InternalStatistics

2014-01-29 20:40:41 -08:00

internal_stats.h

InternalStatistics

2014-01-29 20:40:41 -08:00

log_format.h

Some minor refactoring on the code

2014-01-02 16:32:31 -08:00

log_reader.cc

Make Log::Reader more robust

2014-02-28 13:19:47 -08:00

log_reader.h

Fix UnmarkEOF for partial blocks

2014-01-27 14:49:10 -08:00

log_test.cc

Make Log::Reader more robust

2014-02-28 13:19:47 -08:00

log_writer.cc

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

log_writer.h

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

memtable_list.cc

IOError cleanup

2014-02-12 11:42:54 -08:00

memtable_list.h

IOError cleanup

2014-02-12 11:42:54 -08:00

memtable.cc

Reduce malloc of iterators in Get() code paths

2014-02-11 10:32:51 -08:00

memtable.h

Reduce malloc of iterators in Get() code paths

2014-02-11 10:32:51 -08:00

merge_context.h

Introduce MergeContext to Lazily Initialize merge operand list

2013-12-11 11:37:28 -08:00

merge_helper.cc

Statistics code cleanup

2014-01-17 12:46:06 -08:00

merge_helper.h

[RocksDB] Use raw pointer instead of shared pointer when passing Statistics object internally

2013-11-25 10:38:15 -08:00

merge_operator.cc

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

merge_test.cc

Use ASSERT_EQ() instead of assert() in merge_test

2014-01-11 09:25:47 -08:00

perf_context_test.cc

Merge branch 'master' into performance

2013-12-06 14:15:42 -08:00

plain_table_db_test.cc

Disable putting filter block to block cache

2014-02-19 15:38:57 -08:00

prefix_filter_iterator.h

Moving Some includes from options.h to forward declaration

2014-01-24 17:16:22 -08:00

prefix_test.cc

Add a test in prefix_test to verify correctness of results

2014-02-19 17:00:34 -08:00

repair.cc

Make Log::Reader more robust

2014-02-28 13:19:47 -08:00

simple_table_db_test.cc

Make table properties shareable

2014-02-07 19:26:49 -08:00

skiplist_test.cc

Clean up arena API

2014-01-30 22:10:10 -08:00

skiplist.h

Reduce malloc of iterators in Get() code paths

2014-02-11 10:32:51 -08:00

snapshot.h

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

table_cache.cc

Expose the table properties to application

2014-02-13 16:28:21 -08:00

table_cache.h

Expose the table properties to application

2014-02-13 16:28:21 -08:00

table_properties_collector_test.cc

Fix problem 3 for issue #80

2014-02-11 17:52:18 -08:00

table_properties_collector.cc

Extract metaindex block from block-based table

2013-12-05 16:34:16 -08:00

table_properties_collector.h

Extract metaindex block from block-based table

2013-12-05 16:34:16 -08:00

tailing_iter.cc

Moving Some includes from options.h to forward declaration

2014-01-24 17:16:22 -08:00

tailing_iter.h

Tailing iterator

2014-01-23 16:26:08 -08:00

transaction_log_impl.cc

Add ReadOptions to TransactionLogIterator.

2014-02-28 11:50:36 -08:00

transaction_log_impl.h

Add ReadOptions to TransactionLogIterator.

2014-02-28 11:50:36 -08:00

version_edit_test.cc

Remove compaction pointers

2014-01-16 14:06:53 -08:00

version_edit.cc

Merge branch 'master' into performance

2014-01-16 14:31:18 -08:00

version_edit.h

Merge branch 'master' into performance

2014-01-16 14:31:18 -08:00

version_set_test.cc

Add appropriate LICENSE and Copyright message.

2013-10-16 17:48:41 -07:00

version_set.cc

Fix a group commit bug in LogAndApply

2014-03-03 17:10:43 -08:00

version_set.h

Expose the table properties to application

2014-02-13 16:28:21 -08:00

write_batch_internal.h

In-place updates for equal keys and similar sized values

2013-10-31 11:27:12 -07:00

write_batch_test.cc

[Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte.

2014-02-03 12:19:30 -08:00

write_batch.cc

Merge branch 'master' into performance

2014-01-23 16:32:49 -08:00