e1346968d8
Summary: -Added null checks and revisions to DBIter::MergeValuesNewToOld() -Added DBIter test to stringappend_test -Major fix with Merge and TTL More plans for fixes later. Test Plan: -make clean; make stringappend_test -j 32; ./stringappend_test -make all check; Reviewers: haobo, emayanke, vamsi, dhruba Reviewed By: haobo CC: leveldb Differential Revision: https://reviews.facebook.net/D12315
55 lines
1.7 KiB
C++
55 lines
1.7 KiB
C++
#include <memory>
|
|
#include "leveldb/slice.h"
|
|
#include "leveldb/merge_operator.h"
|
|
#include "utilities/merge_operators.h"
|
|
|
|
using namespace leveldb;
|
|
|
|
namespace { // anonymous namespace
|
|
|
|
// A merge operator that mimics Put semantics
|
|
// Since this merge-operator will not be used in production,
|
|
// it is implemented as a non-associative merge operator to illustrate the
|
|
// new interface and for testing purposes. (That is, we inherit from
|
|
// the MergeOperator class rather than the AssociativeMergeOperator
|
|
// which would be simpler in this case).
|
|
//
|
|
// From the client-perspective, semantics are the same.
|
|
class PutOperator : public MergeOperator {
|
|
public:
|
|
virtual bool FullMerge(const Slice& key,
|
|
const Slice* existing_value,
|
|
const std::deque<std::string>& operand_sequence,
|
|
std::string* new_value,
|
|
Logger* logger) const override {
|
|
// Put basically only looks at the current/latest value
|
|
assert(!operand_sequence.empty());
|
|
assert(new_value != nullptr);
|
|
new_value->assign(operand_sequence.back());
|
|
return true;
|
|
}
|
|
|
|
virtual bool PartialMerge(const Slice& key,
|
|
const Slice& left_operand,
|
|
const Slice& right_operand,
|
|
std::string* new_value,
|
|
Logger* logger) const override {
|
|
new_value->assign(right_operand.data(), right_operand.size());
|
|
return true;
|
|
}
|
|
|
|
virtual const char* Name() const override {
|
|
return "PutOperator";
|
|
}
|
|
};
|
|
|
|
} // end of anonymous namespace
|
|
|
|
namespace leveldb {
|
|
|
|
std::shared_ptr<MergeOperator> MergeOperators::CreatePutOperator() {
|
|
return std::make_shared<PutOperator>();
|
|
}
|
|
|
|
}
|