andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/monitoring
History
Andrew Kryczka 9983eecdfb Dedicate cacheline for DB mutex (#9637) 
Summary:
We found a case of cacheline bouncing due to writers locking/unlocking `mutex_` and readers accessing `block_cache_tracer_`. We discovered it only after the issue was fixed by https://github.com/facebook/rocksdb/issues/9462 shifting the `DBImpl` members such that `mutex_` and `block_cache_tracer_` were naturally placed in separate cachelines in our regression testing setup. This PR forces the cacheline alignment of `mutex_` so we don't accidentally reintroduce the problem.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9637

Reviewed By: riversand963

Differential Revision: D34502233

Pulled By: ajkr

fbshipit-source-id: 46aa313b7fe83e80c3de254e332b6fb242434c07
2022-02-27 11:36:54 -08:00
..
file_read_sample.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
histogram_test.cc
Make SystemClock into a Customizable Class (#8636)
2021-09-21 09:23:48 -07:00
histogram_windowing.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
histogram_windowing.h
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
histogram.cc
improve-histogram-performance: remove valueIndexMap_ (#8625)
2021-10-14 14:45:20 -07:00
histogram.h
improve-histogram-performance: remove valueIndexMap_ (#8625)
2021-10-14 14:45:20 -07:00
in_memory_stats_history.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
in_memory_stats_history.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
instrumented_mutex.cc
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
instrumented_mutex.h
Dedicate cacheline for DB mutex (#9637)
2022-02-27 11:36:54 -08:00
iostats_context_imp.h
Remove IOSTATS_ADD_IF_POSITIVE() (#8984)
2021-10-01 14:43:00 -07:00
iostats_context_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
iostats_context.cc
Add file temperature related counter and bytes stats to and io_stats (#8710)
2021-10-07 14:58:41 -07:00
perf_context_imp.h
Add file temperature related counter and bytes stats to and io_stats (#8710)
2021-10-07 14:58:41 -07:00
perf_context.cc
Add a PerfContext counter for secondary cache hits (#8685)
2021-08-20 15:17:30 -07:00
perf_level_imp.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
perf_level.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
perf_step_timer.h
make PerfStepTimer struct smaller by reordering members (#7931)
2021-03-08 21:33:15 -08:00
persistent_stats_history.cc
Remove unused includes (#7604)
2020-10-28 23:22:27 -07:00
persistent_stats_history.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
statistics_test.cc
Added a default Name method to Statistics (#8918)
2021-09-17 07:25:43 -07:00
statistics.cc
Add last level and non-last level read statistics (#9519)
2022-02-18 14:23:07 -08:00
statistics.h
Add support for building on s390x platform (#8962)
2021-10-22 10:13:15 -07:00
stats_history_test.cc
remove bad extra RecordTick(stats_, WRITE_WITH_WAL) (#9064)
2021-11-01 11:43:14 -07:00
thread_status_impl.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_status_updater_debug.cc
Replace reinterpret_cast with static_cast_with_check (#7067)
2020-07-02 19:25:41 -07:00
thread_status_updater.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
thread_status_updater.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_status_util_debug.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
thread_status_util.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
thread_status_util.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00