andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
752ec46cd5
rocksdb/table
History
Kai Liu 69f6cf431d Fix two bugs in talbe format 
Summary:
Previous code had two bugs:

* didn't initialize the table_magic_number_ explicitly -- as a
  result a random junk number is stored for table_magic_number_, making
  HasInitializedMagicNumber() always return true.
* if condition is inconrrect in set_table_magic_number(), and the return value is not checked.
  I replace if-else by a stronger requirement enforced by assert().

Test Plan:
Previous sst_dump failed to work.
After the fix, things back to normal.

Reviewers: yhchiang

CC: haobo, sdong, igor, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D17055
2014-03-19 16:18:33 -07:00
..
block_based_table_builder.cc Make the block-based table's index pluggable 2014-02-28 18:19:07 -08:00
block_based_table_builder.h Make the block-based table's index pluggable 2014-02-28 18:19:07 -08:00
block_based_table_factory.cc Make the block-based table's index pluggable 2014-02-28 18:19:07 -08:00
block_based_table_factory.h Remove the terrible hack in for flush_block_policy_factory 2014-02-28 16:39:27 -08:00
block_based_table_reader.cc Make the Create() function comform the convention 2014-03-01 23:43:03 -08:00
block_based_table_reader.h Make the Create() function comform the convention 2014-03-01 23:43:03 -08:00
block_builder.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block_builder.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block_hash_index_test.cc Add a hash-index component for block 2014-03-03 21:11:49 -08:00
block_hash_index.cc Add a hash-index component for block 2014-03-03 21:11:49 -08:00
block_hash_index.h Add a hash-index component for block 2014-03-03 21:11:49 -08:00
block_test.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
block.cc Implement a compressed block cache. 2013-11-01 14:31:35 -07:00
block.h Fix inconsistent code format 2014-02-26 18:56:39 -08:00
filter_block_test.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
filter_block.cc Consolidate SliceTransform object ownership 2014-03-10 12:56:46 -07:00
filter_block.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
flush_block_policy.cc Remove the terrible hack in for flush_block_policy_factory 2014-02-28 16:39:27 -08:00
format.cc Merge pull request #74 from alberts/lz4 2014-02-10 15:46:56 -08:00
format.h Fix two bugs in talbe format 2014-03-19 16:18:33 -07:00
iter_heap.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
iterator_wrapper.h Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
iterator.cc Add appropriate LICENSE and Copyright message. 2013-10-16 17:48:41 -07:00
merger.cc Fix issue with iterator operations in this order: Prev(), Seek(), Prev() 2014-03-03 17:50:27 -08:00
merger.h Merge branch 'master' into performance 2014-01-28 10:35:55 -08:00
meta_blocks.cc Expose the table properties to application 2014-02-13 16:28:21 -08:00
meta_blocks.h Expose the table properties to application 2014-02-13 16:28:21 -08:00
plain_table_builder.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
plain_table_builder.h First phase API clean up 2014-02-03 00:30:43 -08:00
plain_table_factory.cc Add more black-box tests for PlainTable and explicitly support total order mode 2014-02-12 17:37:22 -08:00
plain_table_factory.h Add more black-box tests for PlainTable and explicitly support total order mode 2014-02-12 17:37:22 -08:00
plain_table_reader.cc More precise calculation of sub_index_size 2014-03-06 17:30:46 -08:00
plain_table_reader.h More precise calculation of sub_index_size 2014-03-06 17:30:46 -08:00
table_builder.h First phase API clean up 2014-02-03 00:30:43 -08:00
table_properties.cc Add support for plain table format to sst_dump. 2014-02-07 11:15:00 -08:00
table_reader_bench.cc Consolidate SliceTransform object ownership 2014-03-10 12:56:46 -07:00
table_reader.h Make table properties shareable 2014-02-07 19:26:49 -08:00
table_test.cc Consolidate SliceTransform object ownership 2014-03-10 12:56:46 -07:00
two_level_iterator.cc [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00
two_level_iterator.h [Performance Branch] PlainTable to encode rows with seqID 0, value type using 1 internal byte. 2014-02-03 12:19:30 -08:00