andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
767777c2bd
rocksdb/java/rocksjni
History
Igor Canadi 767777c2bd Turn on -Wshorten-64-to-32 and fix all the errors 
Summary:
We need to turn on -Wshorten-64-to-32 for mobile. See D1671432 (internal phabricator) for details.

This diff turns on the warning flag and fixes all the errors. There were also some interesting errors that I might call bugs, especially in plain table. Going forward, I think it makes sense to have this flag turned on and be very very careful when converting 64-bit to 32-bit variables.

Test Plan: compiles

Reviewers: ljin, rven, yhchiang, sdong

Reviewed By: yhchiang

Subscribers: bobbaldwin, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28689
2014-11-11 16:47:22 -05:00
..
backupablejni.cc [RocksJava] Integrated review comments 2014-10-28 18:42:30 +01:00
columnfamilyhandle.cc [RocksJava] Column family support 2014-10-13 10:34:52 +02:00
comparator.cc Fix code review comments raised in https://reviews.facebook.net/D22779 2014-10-21 15:52:28 +01:00
comparatorjnicallback.cc [RocksJava] - BackupInfos & Restore-/BackupableDB enhancements 2014-10-28 18:42:05 +01:00
comparatorjnicallback.h Fix code review comments raised in https://reviews.facebook.net/D22779 2014-10-21 15:52:28 +01:00
env.cc [RocksJava] -WShadow improvements 2014-11-06 23:14:48 +01:00
filter.cc Filters getting disposed by System.gc before EOL 2014-10-15 20:59:25 +02:00
iterator.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
memtablejni.cc [RocksJava] Memtables update to 3.6 2014-10-23 21:10:17 +02:00
merge_operator.cc Integrated feedback from ankgup87 2014-10-13 15:37:29 -07:00
options.cc [RocksJava] Flush functionality 2014-11-11 07:47:38 +01:00
portal.h [RocksJava] Flush functionality 2014-11-11 07:47:38 +01:00
ratelimiterjni.cc 32-Bit RocksJava resolution for jlong overflows 2014-10-12 22:42:18 +02:00
restorejni.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
rocksjni.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
slice.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
statistics.cc Adding iterator JNI binding 2014-04-19 03:26:22 -07:00
table.cc BlockBasedTableConfig & PlainTableConfig enhancements 2014-10-30 20:54:35 +01:00
write_batch.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
writebatchhandlerjnicallback.cc Addresed comments from code review https://reviews.facebook.net/D27567 2014-11-09 16:10:11 +00:00
writebatchhandlerjnicallback.h Addresed comments from code review https://reviews.facebook.net/D27567 2014-11-09 16:10:11 +00:00