andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
767777c2bd
rocksdb/table
History
Igor Canadi 767777c2bd Turn on -Wshorten-64-to-32 and fix all the errors 
Summary:
We need to turn on -Wshorten-64-to-32 for mobile. See D1671432 (internal phabricator) for details.

This diff turns on the warning flag and fixes all the errors. There were also some interesting errors that I might call bugs, especially in plain table. Going forward, I think it makes sense to have this flag turned on and be very very careful when converting 64-bit to 32-bit variables.

Test Plan: compiles

Reviewers: ljin, rven, yhchiang, sdong

Reviewed By: yhchiang

Subscribers: bobbaldwin, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28689
2014-11-11 16:47:22 -05:00
..
adaptive_table_factory.cc introduce ImmutableOptions 2014-09-04 16:18:36 -07:00
adaptive_table_factory.h Sanitize block-based table index type and check prefix_extractor 2014-10-17 21:18:36 -07:00
block_based_filter_block_test.cc Remove some unnecessary constructors 2014-09-17 16:45:58 -07:00
block_based_filter_block.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block_based_filter_block.h Remove some unnecessary constructors 2014-09-17 16:45:58 -07:00
block_based_table_builder.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block_based_table_builder.h introduce ImmutableOptions 2014-09-04 16:18:36 -07:00
block_based_table_factory.cc Avoid reloading filter on Get() if cache_index_and_filter_blocks == false 2014-10-22 11:52:35 -07:00
block_based_table_factory.h Sanitize block-based table index type and check prefix_extractor 2014-10-17 21:18:36 -07:00
block_based_table_reader.cc Turn on -Wshadow 2014-10-31 11:59:54 -07:00
block_based_table_reader.h Avoid reloading filter on Get() if cache_index_and_filter_blocks == false 2014-10-22 11:52:35 -07:00
block_builder.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block_builder.h delete unused Comparator 2014-09-04 09:10:13 +08:00
block_hash_index_test.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block_hash_index.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block_hash_index.h Turn on -Wshadow 2014-10-31 11:59:54 -07:00
block_prefix_index.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block_prefix_index.h fix a few compile warnings 2014-09-04 23:06:23 +08:00
block_test.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
block.h Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
bloom_block.cc table/bloom_block.*: pass func parameter by reference 2014-09-30 23:30:31 +02:00
bloom_block.h table/bloom_block.*: pass func parameter by reference 2014-09-30 23:30:31 +02:00
cuckoo_table_builder_test.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
cuckoo_table_builder.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
cuckoo_table_builder.h Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
cuckoo_table_factory.cc option to choose module when calculating CuckooTable hash 2014-09-25 13:53:27 -07:00
cuckoo_table_factory.h Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
cuckoo_table_reader_test.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
cuckoo_table_reader.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
cuckoo_table_reader.h use GetContext to replace callback function pointer 2014-09-29 11:09:09 -07:00
filter_block.h Replace naked calls to operator new and delete (Fixes #222) 2014-09-17 13:50:07 -07:00
flush_block_policy.cc move block based table related options BlockBasedTableOptions 2014-08-25 14:22:05 -07:00
format.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
format.h Turn -Wshadow back on 2014-11-06 11:14:28 -08:00
full_filter_block_test.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
full_filter_block.cc Run make format on PR #249 2014-09-17 15:08:50 -07:00
full_filter_block.h Replace naked calls to operator new and delete (Fixes #222) 2014-09-17 13:50:07 -07:00
get_context.cc use GetContext to replace callback function pointer 2014-09-29 11:09:09 -07:00
get_context.h use GetContext to replace callback function pointer 2014-09-29 11:09:09 -07:00
iter_heap.h Turn on -Wmissing-prototypes 2014-04-09 21:17:14 -07:00
iterator_wrapper.h Turn -Wshadow back on 2014-11-06 11:14:28 -08:00
iterator.cc In DB::NewIterator(), try to allocate the whole iterator tree in an arena 2014-06-02 17:44:57 -07:00
merger_test.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
merger.cc Turn -Wshadow back on 2014-11-06 11:14:28 -08:00
merger.h In DB::NewIterator(), try to allocate the whole iterator tree in an arena 2014-06-02 17:44:57 -07:00
meta_blocks.cc Apply InfoLogLevel to the logs in table/meta_blocks.cc 2014-10-29 17:55:19 -07:00
meta_blocks.h Adding option to save PlainTable index and bloom filter in SST file. 2014-07-18 16:58:13 -07:00
mock_table.cc TableMock + framework for mock classes 2014-10-28 17:52:32 -07:00
mock_table.h Include atomic in mock_table.h 2014-10-28 18:10:55 -07:00
plain_table_builder.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
plain_table_builder.h Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
plain_table_factory.cc in_table_factory.cc: use correct format specifier 2014-09-30 23:30:32 +02:00
plain_table_factory.h Sanitize block-based table index type and check prefix_extractor 2014-10-17 21:18:36 -07:00
plain_table_index.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
plain_table_index.h Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
plain_table_key_coding.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
plain_table_key_coding.h typo improvement 2014-09-06 23:21:26 +08:00
plain_table_reader.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
plain_table_reader.h Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
table_builder.h First phase API clean up 2014-02-03 00:30:43 -08:00
table_properties.cc Fix SIGFAULT when running sst_dump on v2.6 db 2014-04-21 17:49:47 -07:00
table_reader_bench.cc Fix -Wshadow for tools 2014-11-07 15:04:30 -08:00
table_reader.h use GetContext to replace callback function pointer 2014-09-29 11:09:09 -07:00
table_test.cc Turn on -Wshorten-64-to-32 and fix all the errors 2014-11-11 16:47:22 -05:00
two_level_iterator.cc ForwardIterator: reset incomplete iterators on Seek() 2014-08-29 16:21:29 -07:00
two_level_iterator.h Turn on -Wshadow 2014-10-31 11:59:54 -07:00