andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/util
History
Igor Canadi 767777c2bd Turn on -Wshorten-64-to-32 and fix all the errors 
Summary:
We need to turn on -Wshorten-64-to-32 for mobile. See D1671432 (internal phabricator) for details.

This diff turns on the warning flag and fixes all the errors. There were also some interesting errors that I might call bugs, especially in plain table. Going forward, I think it makes sense to have this flag turned on and be very very careful when converting 64-bit to 32-bit variables.

Test Plan: compiles

Reviewers: ljin, rven, yhchiang, sdong

Reviewed By: yhchiang

Subscribers: bobbaldwin, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28689
2014-11-11 16:47:22 -05:00
..
arena_test.cc
Arena to inline 2KB of data in it.
2014-05-14 11:49:01 -07:00
arena.cc
Fix typo huage => huge
2014-08-14 17:01:20 -07:00
arena.h
Fix -Wnon-virtual-dtor errors
2014-11-10 17:39:38 -05:00
auto_roll_logger_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
auto_roll_logger.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
auto_roll_logger.h
Renamed InfoLogLevel::DEBUG to InfoLogLevel::DEBUG_LEVEL
2014-04-10 15:27:42 -07:00
autovector_test.cc
Turn -Wshadow back on
2014-11-06 11:14:28 -08:00
autovector.h
Fix autovector iterator increment/decrement comments
2014-08-14 14:56:11 -07:00
benchharness_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
benchharness.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
benchharness.h
log_and_apply_bench on a new benchmark framework
2014-05-05 11:11:48 -07:00
blob_store_test.cc
Move the compiler back to 4.8.1 + more small fixes
2013-11-18 11:40:16 -08:00
blob_store.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
blob_store.h
Turn on -Wshadow
2014-10-31 11:59:54 -07:00
bloom_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
bloom.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
build_version.h
Dont build version if compiling for IOS
2014-04-11 10:54:47 -07:00
cache_bench.cc
Fix -Wshadow for tools
2014-11-07 15:04:30 -08:00
cache_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
cache.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
coding_test.cc
Remove BitStream* tests
2014-08-19 09:52:54 -04:00
coding.cc
Removing BitStream* functions
2014-08-19 06:48:21 -07:00
coding.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
comparator.cc
Changed name of ReverseBytewiseComparator based on review comment
2014-09-27 10:06:13 +02:00
crc32c_test.cc
Add appropriate LICENSE and Copyright message.
2013-10-16 17:48:41 -07:00
crc32c.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
crc32c.h
Add appropriate LICENSE and Copyright message.
2013-10-16 17:48:41 -07:00
db_info_dumper.cc
Apply InfoLogLevel to the logs in util/db_info_dumper.cc
2014-10-30 13:34:44 -07:00
dynamic_bloom_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
dynamic_bloom.cc
Changes to support unity build:
2014-08-11 13:22:47 -04:00
dynamic_bloom.h
Adding option to save PlainTable index and bloom filter in SST file.
2014-07-18 16:58:13 -07:00
env_hdfs.cc
Apply InfoLogLevel to the logs in util/env_hdfs.cc
2014-11-05 00:12:20 -08:00
env_posix.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
env_test.cc
DB::Open() to automatically increase thread pool size if it is smaller than max number of parallel compactions or flushes
2014-11-03 17:22:34 -08:00
env.cc
Check InfoLogLevel earlier in Log functions.
2014-10-30 13:36:18 -07:00
filelock_test.cc
Add appropriate LICENSE and Copyright message.
2013-10-16 17:48:41 -07:00
filter_policy.cc
Add appropriate LICENSE and Copyright message.
2013-10-16 17:48:41 -07:00
hash_cuckoo_rep.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
hash_cuckoo_rep.h
Pass logger to memtable rep and TLB page allocation error logged to info logs
2014-05-05 16:43:37 -07:00
hash_linklist_rep.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
hash_linklist_rep.h
HashLinkList memtable switches a bucket to a skip list to reduce performance outliers
2014-07-01 17:14:15 -07:00
hash_skiplist_rep.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
hash_skiplist_rep.h
Pass logger to memtable rep and TLB page allocation error logged to info logs
2014-05-05 16:43:37 -07:00
hash.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
hash.h
Changes to support unity build:
2014-08-11 13:22:47 -04:00
histogram_test.cc
Add appropriate LICENSE and Copyright message.
2013-10-16 17:48:41 -07:00
histogram.cc
fix a few compile warnings
2014-09-04 23:06:23 +08:00
histogram.h
fix a few compile warnings
2014-09-04 23:06:23 +08:00
iostats_context_imp.h
Fix ios compile
2014-08-28 12:46:05 -04:00
iostats_context.cc
Fix ios compile
2014-08-28 12:46:05 -04:00
ldb_cmd_execute_result.h
Revert "Fix lint errors and coding style of ldb related codes."
2014-10-31 19:22:49 -07:00
ldb_cmd.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
ldb_cmd.h
Revert "Fix lint errors and coding style of ldb related codes."
2014-10-31 19:22:49 -07:00
ldb_tool.cc
Revert "Fix lint errors and coding style of ldb related codes."
2014-10-31 19:22:49 -07:00
log_buffer.cc
Enlarge log size cap when printing file summary
2014-09-23 16:56:34 -07:00
log_buffer.h
Enlarge log size cap when printing file summary
2014-09-23 16:56:34 -07:00
log_write_bench.cc
Fix more gflag namespace issues
2014-05-09 08:41:02 -07:00
logging.cc
remove cast, replace %llu with % PRIu64
2014-09-23 01:10:46 +08:00
logging.h
remove unused variable
2014-09-21 22:20:00 +08:00
manual_compaction_test.cc
Fix CompactRange to apply filter to every key
2014-01-14 16:19:09 -08:00
mock_env_test.cc
Add fsync / corrupt simulation to env_mem
2014-10-31 15:16:31 -07:00
mock_env.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
mock_env.h
Add fsync / corrupt simulation to env_mem
2014-10-31 15:16:31 -07:00
murmurhash.cc
Add appropriate LICENSE and Copyright message.
2013-10-16 17:48:41 -07:00
murmurhash.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
mutable_cf_options.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
mutable_cf_options.h
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
mutexlock.h
Add separate Read/WriteUnlock methods in MutexRW.
2014-06-16 15:41:46 -07:00
options_builder.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
options_helper.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
options_helper.h
SetOptions() to return status and also add it to StackableDB
2014-11-04 16:23:05 -08:00
options_test.cc
fix
2014-10-31 13:30:08 -07:00
options.cc
CompactFiles, EventListener and GetDatabaseMetaData
2014-11-07 14:45:18 -08:00
perf_context_imp.h
Refactor PerfStepTimer to stop on destruct
2014-09-02 12:04:22 -07:00
perf_context.cc
Add a function to return current perf level
2014-07-10 11:35:48 -07:00
posix_logger.h
Renamed InfoLogLevel::DEBUG to InfoLogLevel::DEBUG_LEVEL
2014-04-10 15:27:42 -07:00
random.h
Add appropriate LICENSE and Copyright message.
2013-10-16 17:48:41 -07:00
rate_limiter_test.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
rate_limiter.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
rate_limiter.h
expose RateLimiter definition
2014-07-25 15:17:06 -07:00
scoped_arena_iterator.h
Remove path with arena==nullptr from NewInternalIterator
2014-09-04 17:40:41 -07:00
signal_test.cc
util/signal_test.cc: suppress intentional null pointer deref
2014-09-30 23:30:32 +02:00
skiplistrep.cc
SkipListRep::LookaheadIterator
2014-10-07 11:48:23 -07:00
slice.cc
FixedPrefixTransform to include prefix length in its name
2014-05-13 16:08:21 -07:00
sst_dump_tool.cc
Fix build
2014-11-09 13:01:50 -05:00
statistics.cc
fix more compile warnings
2014-09-05 14:14:37 +08:00
statistics.h
make statistics forward-able
2014-07-28 12:10:49 -07:00
status.cc
Turn on -Wshorten-64-to-32 and fix all the errors
2014-11-11 16:47:22 -05:00
stl_wrappers.h
Killing Transform Rep
2013-12-03 12:42:15 -08:00
stop_watch.h
Change StopWatch interface
2014-07-28 12:22:37 -07:00
string_util.cc
Turn on -Wmissing-prototypes
2014-04-09 21:17:14 -07:00
string_util.h
Turn on -Wmissing-prototypes
2014-04-09 21:17:14 -07:00
sync_point.cc
Don't compile sync_point if NDEBUG
2014-04-17 10:49:58 -07:00
sync_point.h
Fix ifdef NDEBUG
2014-04-17 14:29:28 -07:00
testharness.cc
introduce TestMemEnv and use it in db_test
2014-10-31 15:08:10 -07:00
testharness.h
introduce TestMemEnv and use it in db_test
2014-10-31 15:08:10 -07:00
testutil.cc
Merger test
2014-09-08 22:24:40 -07:00
testutil.h
Add ComparatorDBTest to test non-default comparators
2014-10-29 15:42:36 -07:00
thread_local_test.cc
Turn on -Wshadow
2014-10-31 11:59:54 -07:00
thread_local.cc
simplify ThreadLocalPtr a little bit
2014-04-22 21:13:34 -07:00
thread_local.h
Improve the comment of util/thread_local.h
2014-10-21 17:28:31 -07:00
vectorrep.cc
Remove assert in vector rep
2014-08-27 11:05:41 -07:00
xxhash.cc
xxHash
2014-05-01 14:09:32 -04:00
xxhash.h
xxHash
2014-05-01 14:09:32 -04:00