8d007b4aaf
Summary: (1) Fix SanitizeOptions() to also check HashLinkList. The current dynamic case just happens to work because the 2 classes have the same layout. (2) Do not delete SliceTransform object in HashSkipListFactory and HashLinkListFactory destructor. Reason: SanitizeOptions() enforces prefix_extractor and SliceTransform to be the same object when Hash**Factory is used. This makes the behavior strange: when Hash**Factory is used, prefix_extractor will be released by RocksDB. If other memtable factory is used, prefix_extractor should be released by user. Test Plan: db_bench && make asan_check Reviewers: haobo, igor, sdong Reviewed By: igor CC: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D16587
42 lines
1.3 KiB
C++
42 lines
1.3 KiB
C++
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#pragma once
|
|
#include "rocksdb/slice_transform.h"
|
|
#include "rocksdb/memtablerep.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
class HashSkipListRepFactory : public MemTableRepFactory {
|
|
public:
|
|
explicit HashSkipListRepFactory(
|
|
size_t bucket_count,
|
|
int32_t skiplist_height,
|
|
int32_t skiplist_branching_factor)
|
|
: bucket_count_(bucket_count),
|
|
skiplist_height_(skiplist_height),
|
|
skiplist_branching_factor_(skiplist_branching_factor) { }
|
|
|
|
virtual ~HashSkipListRepFactory() {}
|
|
|
|
virtual MemTableRep* CreateMemTableRep(
|
|
const MemTableRep::KeyComparator& compare, Arena* arena,
|
|
const SliceTransform* transform) override;
|
|
|
|
virtual const char* Name() const override {
|
|
return "HashSkipListRepFactory";
|
|
}
|
|
|
|
private:
|
|
const size_t bucket_count_;
|
|
const int32_t skiplist_height_;
|
|
const int32_t skiplist_branching_factor_;
|
|
};
|
|
|
|
}
|