rocksdb/utilities/blob_db
Levi Tamasi 7a7ca8eb5b BlobDB: only compare CF IDs when checking whether an API call is for the default CF (#6226)
Summary:
BlobDB currently only supports using the default column family. The earlier
code enforces this by comparing the `ColumnFamilyHandle` passed to the
`Get`/`Put`/etc. call with the handle returned by `DefaultColumnFamily`
(which, at the end of the day, comes from `DBImpl::default_cf_handle_`).
Since other `ColumnFamilyHandle`s can also point to the default column
family, this can reject legitimate requests as well. (As an example,
with the earlier code, the handle returned by `BlobDB::Open` cannot
actually be used in API calls.) The patch fixes this by comparing only
the IDs of the column family handles instead of the pointers themselves.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6226

Test Plan: `make check`

Differential Revision: D19187461

Pulled By: ltamasi

fbshipit-source-id: 54ce2e12ebb1f07e6d1e70e3b1e0213dfa94bda2
2019-12-19 18:05:49 -08:00
..
blob_compaction_filter.cc Move out valid blobs from the oldest blob files during compaction (#6121) 2019-12-13 10:13:05 -08:00
blob_compaction_filter.h Move out valid blobs from the oldest blob files during compaction (#6121) 2019-12-13 10:13:05 -08:00
blob_db_impl_filesnapshot.cc Add file number/oldest referenced blob file number to {Sst,Live}FileMetaData (#6011) 2019-11-07 14:04:16 -08:00
blob_db_impl.cc BlobDB: only compare CF IDs when checking whether an API call is for the default CF (#6226) 2019-12-19 18:05:49 -08:00
blob_db_impl.h Move out valid blobs from the oldest blob files during compaction (#6121) 2019-12-13 10:13:05 -08:00
blob_db_iterator.h Refactor ArenaWrappedDBIter into separate files (#5801) 2019-09-13 13:50:43 -07:00
blob_db_listener.h BlobDB: Maintain mapping between blob files and SSTs (#6020) 2019-11-11 14:01:34 -08:00
blob_db_test.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
blob_db.cc simplify include directive involving inttypes (#5402) 2019-06-06 13:56:07 -07:00
blob_db.h BlobDB: only compare CF IDs when checking whether an API call is for the default CF (#6226) 2019-12-19 18:05:49 -08:00
blob_dump_tool.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
blob_dump_tool.h Divide file_reader_writer.h and .cc (#5803) 2019-09-16 10:33:51 -07:00
blob_file.cc Introduce a new storage specific Env API (#5761) 2019-12-13 14:48:41 -08:00
blob_file.h Move out valid blobs from the oldest blob files during compaction (#6121) 2019-12-13 10:13:05 -08:00
blob_log_format.cc utilities: Fix build failure with -Werror=maybe-uninitialized (#5074) 2019-03-18 11:35:06 -07:00
blob_log_format.h Refactor blob file creation logic (#6066) 2019-11-26 13:28:32 -08:00
blob_log_reader.cc Divide file_reader_writer.h and .cc (#5803) 2019-09-16 10:33:51 -07:00
blob_log_reader.h Divide file_reader_writer.h and .cc (#5803) 2019-09-16 10:33:51 -07:00
blob_log_writer.cc Divide file_reader_writer.h and .cc (#5803) 2019-09-16 10:33:51 -07:00
blob_log_writer.h Use delete to disable automatic generated methods. (#5009) 2019-09-11 18:09:00 -07:00