andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table
History
Andrew Kryczka 7b655214d2 Assert keys/values pinned by range deletion meta-block iterators 
Summary:
`RangeDelAggregator` holds the pointers returned by `BlockIter::key()` and `BlockIter::value()` so requires the data to which they point is pinned. `BlockIter::key()` points into block memory and is guaranteed to be pinned if and only if prefix encoding is disabled (or, equivalently, restart interval is set to one). I think `BlockIter::value()` is always pinned. Added an assert for these and removed the wrong TODO about increasing restart interval, which would enable key prefix encoding and break the assertion.
Closes https://github.com/facebook/rocksdb/pull/3875

Differential Revision: D8063667

Pulled By: ajkr

fbshipit-source-id: 60b5ebcc0cdd610dd6aad9e74a23378793672c41
2018-05-21 09:57:00 -07:00
..
adaptive_table_factory.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
adaptive_table_factory.h
Comment out unused variables
2018-03-05 13:13:41 -08:00
block_based_filter_block_test.cc
Ignore empty filter block when data block is empty
2018-03-21 23:13:05 -07:00
block_based_filter_block.cc
Fix a leak in FilterBlockBuilder when adding prefix
2018-03-27 15:13:56 -07:00
block_based_filter_block.h
Ignore empty filter block when data block is empty
2018-03-21 23:13:05 -07:00
block_based_table_builder.cc
Assert keys/values pinned by range deletion meta-block iterators
2018-05-21 09:57:00 -07:00
block_based_table_builder.h
Align SST file data blocks to avoid spanning multiple pages
2018-03-26 20:26:10 -07:00
block_based_table_factory.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
block_based_table_factory.h
Align SST file data blocks to avoid spanning multiple pages
2018-03-26 20:26:10 -07:00
block_based_table_reader.cc
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
block_based_table_reader.h
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
block_builder.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_fetcher.cc
Imporve perf of random read and insert compare by suggesting inlining to the compiler
2018-03-23 13:26:55 -07:00
block_fetcher.h
Fix BlockFetcher ASAN error
2017-12-12 12:12:38 -08:00
block_prefix_index.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_prefix_index.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
block_test.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
block.cc
class Block to store num_restarts_
2018-05-18 12:56:55 -07:00
block.h
class Block to store num_restarts_
2018-05-18 12:56:55 -07:00
bloom_block.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
bloom_block.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cleanable_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
cuckoo_table_builder_test.cc
fix memory leak in two_level_iterator
2018-04-15 17:26:26 -07:00
cuckoo_table_builder.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
cuckoo_table_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cuckoo_table_factory.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
cuckoo_table_factory.h
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
cuckoo_table_reader_test.cc
fix memory leak in two_level_iterator
2018-04-15 17:26:26 -07:00
cuckoo_table_reader.cc
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
cuckoo_table_reader.h
Comment out unused variables
2018-03-05 13:13:41 -08:00
filter_block.h
Ignore empty filter block when data block is empty
2018-03-21 23:13:05 -07:00
flush_block_policy.cc
Align SST file data blocks to avoid spanning multiple pages
2018-03-26 20:26:10 -07:00
format.cc
Several small "fixes"
2018-02-15 16:57:37 -08:00
format.h
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
full_filter_bits_builder.h
Skip duplicate bloom keys when whole_key and prefix are mixed
2018-04-24 10:58:16 -07:00
full_filter_block_test.cc
Fix the bloom filter skipping empty prefixes
2018-04-26 13:28:31 -07:00
full_filter_block.cc
Fix the bloom filter skipping empty prefixes
2018-04-26 13:28:31 -07:00
full_filter_block.h
Fix the bloom filter skipping empty prefixes
2018-04-26 13:28:31 -07:00
get_context.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
get_context.h
Stats for false positive rate of full filtesr
2018-04-05 15:58:48 -07:00
index_builder.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
index_builder.h
Comment out unused variables
2018-03-05 13:13:41 -08:00
internal_iterator.h
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
iter_heap.h
Make InternalKeyComparator final and directly use it in merging iterator
2017-09-11 12:04:21 -07:00
iterator_wrapper.h
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
iterator.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
merger_test.cc
Make InternalKeyComparator final and directly use it in merging iterator
2017-09-11 12:04:21 -07:00
merging_iterator.cc
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
merging_iterator.h
fix DBImpl::NewInternalIterator super-version leak on failure
2017-10-11 14:57:43 -07:00
meta_blocks.cc
Refactor ReadBlockContents()
2017-12-11 15:27:32 -08:00
meta_blocks.h
Support prefetch last 512KB with direct I/O in block based file reader
2017-08-11 12:16:45 -07:00
mock_table.cc
Stats for false positive rate of full filtesr
2018-04-05 15:58:48 -07:00
mock_table.h
Comment out unused variables
2018-03-05 13:13:41 -08:00
partitioned_filter_block_test.cc
Reduce heavy hitter for Get operation
2017-12-12 21:11:33 -08:00
partitioned_filter_block.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
partitioned_filter_block.h
Fix the memory leak with pinned partitioned filters
2018-04-09 16:28:19 -07:00
persistent_cache_helper.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
persistent_cache_helper.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
persistent_cache_options.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_builder.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_builder.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_factory.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
plain_table_factory.h
Comment out unused variables
2018-03-05 13:13:41 -08:00
plain_table_index.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_index.h
table: Fix coverity issues
2017-12-07 11:57:36 -08:00
plain_table_key_coding.cc
Comment out unused variables
2018-03-05 13:13:41 -08:00
plain_table_key_coding.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
plain_table_reader.cc
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
plain_table_reader.h
remove unnecessary internal_comparator param in newIterator
2017-07-27 14:30:42 -07:00
scoped_arena_iterator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
sst_file_writer_collectors.h
Comment out unused variables
2018-03-05 13:13:41 -08:00
sst_file_writer.cc
Fix some typos in comments and docs.
2018-03-08 10:27:25 -08:00
table_builder.h
TableProperty::oldest_key_time defaults to 0
2017-10-27 15:00:05 -07:00
table_properties_internal.h
Eliminate some redundant block reads.
2018-01-10 17:11:58 -08:00
table_properties.cc
Eliminate some redundant block reads.
2018-01-10 17:11:58 -08:00
table_reader_bench.cc
comment unused parameters to turn on -Wunused-parameter flag
2018-04-12 17:59:16 -07:00
table_reader.h
Comment out unused variables
2018-03-05 13:13:41 -08:00
table_test.cc
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
two_level_iterator.cc
Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs
2018-05-17 02:56:56 -07:00
two_level_iterator.h
fix memory leak in two_level_iterator
2018-04-15 17:26:26 -07:00