7c70ceed14
Summary: Some bits are mutated and read while holding a lock, other immutable bits (esp. secondary cache compatibility) can be read by arbitrary threads without holding a lock. AFAIK, this doesn't cause an issue on any architecture we care about, because you will get some legitimate version of the value that includes the initialization, as long as synchronization guarantees the initialization happens before the read. I've only seen this in https://github.com/facebook/rocksdb/issues/8538 so far, but it should be fixed regardless. Otherwise, we'll surely get these false reports again some time. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8539 Test Plan: some local TSAN test runs and in CircleCI Reviewed By: zhichao-cao Differential Revision: D29720262 Pulled By: pdillinger fbshipit-source-id: 365fd7e565577c648815161f71b339bcb5ce12d5 |
||
|---|---|---|
| .. | ||
| cache_bench_tool.cc | ||
| cache_bench.cc | ||
| cache_entry_roles.cc | ||
| cache_entry_roles.h | ||
| cache_entry_stats.h | ||
| cache_helpers.h | ||
| cache_test.cc | ||
| cache.cc | ||
| clock_cache.cc | ||
| clock_cache.h | ||
| lru_cache_test.cc | ||
| lru_cache.cc | ||
| lru_cache.h | ||
| sharded_cache.cc | ||
| sharded_cache.h | ||