andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/util
History
Anand Ananthabhotla dfbe52e099 Fix the Logger::Close() and DBImpl::Close() design pattern 
Summary:
The recent Logger::Close() and DBImpl::Close() implementation rely on
calling the CloseImpl() virtual function from the destructor, which will
not work. Refactor the implementation to have a private close helper
function in derived classes that can be called by both CloseImpl() and
the destructor.
Closes https://github.com/facebook/rocksdb/pull/3528

Reviewed By: gfosco

Differential Revision: D7049303

Pulled By: anand1976

fbshipit-source-id: 76a64cbf403209216dfe4864ecf96b5d7f3db9f4
2018-02-23 13:57:26 -08:00
..
aligned_buffer.h
Rounddown in FilePrefetchBuffer::Prefetch
2018-01-26 12:57:25 -08:00
allocator.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
arena_test.cc
arena: derive alignment unit from std::max_align_t
2017-10-17 11:13:19 -07:00
arena.cc
fix advance reservation of arena block addresses
2018-02-15 19:41:52 -08:00
arena.h
arena: derive alignment unit from std::max_align_t
2017-10-17 11:13:19 -07:00
auto_roll_logger_test.cc
Add a Close() method to DB to return status when closing a db
2018-01-16 11:08:57 -08:00
auto_roll_logger.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
auto_roll_logger.h
Fix the Logger::Close() and DBImpl::Close() design pattern
2018-02-23 13:57:26 -08:00
autovector_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
autovector.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
bloom_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
bloom.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
build_version.cc.in
Makefile: generate util/build_version.cc from .in file (#1384)
2016-10-25 11:31:39 -07:00
build_version.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
cast_util.h
Add a missing "once" in .h
2017-07-31 12:12:03 -07:00
channel.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
coding_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
coding.cc
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
coding.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
compaction_job_stats_impl.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
comparator.cc
Move ~Comparator define to comparator.h
2017-10-17 09:58:13 -07:00
compression.h
Back out "[codemod] - comment out unused parameters"
2018-02-22 12:43:17 -08:00
concurrent_arena.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
concurrent_arena.h
util: Fix coverity issues
2017-11-03 14:42:08 -07:00
core_local.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
crc32c_ppc_asm.S
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
crc32c_ppc_constants.h
Make it explicit blob db doesn't support CF
2017-09-08 11:11:04 -07:00
crc32c_ppc.c
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
crc32c_ppc.h
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
crc32c_test.cc
Port 3 way SSE4.2 crc32c implementation from Folly
2017-12-19 18:26:49 -08:00
crc32c.cc
Suppress UBSAN error in finer guanularity
2018-02-13 12:18:07 -08:00
crc32c.h
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
delete_scheduler_test.cc
Make trash-to-DB size ratio limit configurable
2017-11-17 11:58:17 -08:00
delete_scheduler.cc
Fix DeleteScheduler::MarkAsTrash() handling existing trash
2017-12-12 18:17:13 -08:00
delete_scheduler.h
Make trash-to-DB size ratio limit configurable
2017-11-17 11:58:17 -08:00
dynamic_bloom_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
dynamic_bloom.cc
util: Fix coverity issues
2017-11-03 14:42:08 -07:00
dynamic_bloom.h
Enable MSVC W4 with a few exceptions. Fix warnings and bugs
2017-10-19 10:57:12 -07:00
event_logger_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
event_logger.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
event_logger.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
fault_injection_test_env.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
fault_injection_test_env.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
file_reader_writer_test.cc
Back out "[codemod] - comment out unused parameters"
2018-02-22 12:43:17 -08:00
file_reader_writer.cc
Direct I/O writable file should do fsync in Close()
2018-02-13 16:27:11 -08:00
file_reader_writer.h
util: Fix coverity issues
2017-11-03 14:42:08 -07:00
file_util.cc
fix CopyFile status checks
2017-11-03 11:57:10 -07:00
file_util.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
filelock_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
filename.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
filename.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
filter_policy.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
gflags_compat.h
fix gflags namespace
2017-12-01 10:42:05 -08:00
hash_map.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
hash_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
hash.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
hash.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
heap_test.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
heap.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
kv_map.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_buffer.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_buffer.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
log_write_bench.cc
fix gflags namespace
2017-12-01 10:42:05 -08:00
logging.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
memory_usage.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
mpsc.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
murmurhash.cc
Suppress UBSAN error in finer guanularity
2018-02-13 12:18:07 -08:00
murmurhash.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
mutexlock.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
ppc-opcode.h
Updated CRC32 Power Optimization Changes
2017-08-31 14:16:30 -07:00
random.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
random.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
rate_limiter_test.cc
rate limit auto-tuning
2017-10-04 19:15:01 -07:00
rate_limiter.cc
rate limit auto-tuning
2017-10-04 19:15:01 -07:00
rate_limiter.h
rate limit auto-tuning
2017-10-04 19:15:01 -07:00
slice_transform_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
slice.cc
Back out "[codemod] - comment out unused parameters"
2018-02-22 12:43:17 -08:00
sst_file_manager_impl.cc
Make trash-to-DB size ratio limit configurable
2017-11-17 11:58:17 -08:00
sst_file_manager_impl.h
Make trash-to-DB size ratio limit configurable
2017-11-17 11:58:17 -08:00
status_message.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
status.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
stderr_logger.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
stop_watch.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
string_util.cc
Several small "fixes"
2018-02-15 16:57:37 -08:00
string_util.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
sync_point.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
sync_point.h
Fix use-after-free in tailing iterator with merge operator
2018-02-02 21:26:28 -08:00
testharness.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
testharness.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
testutil.cc
Back out "[codemod] - comment out unused parameters"
2018-02-22 12:43:17 -08:00
testutil.h
Back out "[codemod] - comment out unused parameters"
2018-02-22 12:43:17 -08:00
thread_list_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
thread_local_test.cc
Back out "[codemod] - comment out unused parameters"
2018-02-22 12:43:17 -08:00
thread_local.cc
util: Fix coverity issues
2017-11-03 14:42:08 -07:00
thread_local.h
Fix deadlock in ColumnFamilyData::InstallSuperVersion()
2018-02-16 08:13:34 -08:00
thread_operation.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
threadpool_imp.cc
fix ThreadStatus for bottom-pri compaction threads
2017-12-14 14:57:49 -08:00
threadpool_imp.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
timer_queue_test.cc
Change RocksDB License
2017-07-15 16:11:23 -07:00
timer_queue.h
Change RocksDB License
2017-07-15 16:11:23 -07:00
transaction_test_util.cc
FIXED: string buffers potentially too small to fit formatted write
2017-12-20 08:12:22 -08:00
transaction_test_util.h
WritePrepared Txn: stress test
2017-12-06 09:42:28 -08:00
xxhash.cc
fixed typo
2017-06-05 11:27:34 -07:00
xxhash.h
Prevent xxhash symbols from polluting global namespace
2015-03-12 12:07:10 -07:00