07a00828af
Summary:
There are some time-related POSIX APIs that are not available on Windows
(e.g. `localtime_r`), which we have worked around by providing our own
implementations in `port/sys_time.h`. This workaround actually relies on
some ambiguity: on Windows, a call to `localtime_r` calls
`ROCKSDB_NAMESPACE::port::localtime_r` (which is pulled into
`ROCKSDB_NAMESPACE` by a using-declaration), while on other platforms
it calls the global `localtime_r`. This works fine as long as there is only one
candidate function; however, it breaks down when there is more than one
`localtime_r` visible in a scope.
The patch fixes this by introducing `ROCKSDB_NAMESPACE::port::{TimeVal, GetTimeOfDay, LocalTimeR}`
to eliminate any ambiguity.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/10045
Test Plan: `make check`
Reviewed By: riversand963
Differential Revision: D36639372
Pulled By: ltamasi
fbshipit-source-id: fc13dbfa421b7c8918111a6d9e24ce77e91a7c50
64 lines
1.4 KiB
C++
64 lines
1.4 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
// This file is a portable substitute for sys/time.h which does not exist on
|
|
// Windows
|
|
|
|
#pragma once
|
|
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
#if defined(OS_WIN) && (defined(_MSC_VER) || defined(__MINGW32__))
|
|
|
|
#include <time.h>
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
namespace port {
|
|
|
|
struct TimeVal {
|
|
long tv_sec;
|
|
long tv_usec;
|
|
};
|
|
|
|
void GetTimeOfDay(TimeVal* tv, struct timezone* tz);
|
|
|
|
inline struct tm* LocalTimeR(const time_t* timep, struct tm* result) {
|
|
errno_t ret = localtime_s(result, timep);
|
|
return (ret == 0) ? result : NULL;
|
|
}
|
|
|
|
} // namespace port
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
#else
|
|
#include <time.h>
|
|
#include <sys/time.h>
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
namespace port {
|
|
|
|
using TimeVal = struct timeval;
|
|
|
|
inline void GetTimeOfDay(TimeVal* tv, struct timezone* tz) {
|
|
gettimeofday(tv, tz);
|
|
}
|
|
|
|
inline struct tm* LocalTimeR(const time_t* timep, struct tm* result) {
|
|
return localtime_r(timep, result);
|
|
}
|
|
|
|
} // namespace port
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
|
|
|
#endif
|