andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/table/block_based
History
Ziyue Yang 8088482dd6 Fix a division by zero after #6262 (#6633) 
Summary:
With https://github.com/facebook/rocksdb/issues/6262, UBSAN fails with "division by zero":

[ RUN      ] Timestamp/DBBasicTestWithTimestampCompressionSettings.PutAndGetWithCompaction/3
internal_repo_rocksdb/repo/table/block_based/block_based_table_builder.cc:1066:39: runtime error: division by zero
    #0 0x7ffb3117b071 in rocksdb::BlockBasedTableBuilder::WriteRawBlock(rocksdb::Slice const&, rocksdb::CompressionType, rocksdb::BlockHandle*, bool) internal_repo_rocksdb/repo/table/block_based/block_based_table_builder.cc:1066
    https://github.com/facebook/rocksdb/issues/1 0x7ffb311775e1 in rocksdb::BlockBasedTableBuilder::WriteBlock(rocksdb::Slice const&, rocksdb::BlockHandle*, bool) internal_repo_rocksdb/repo/table/block_based/block_based_table_builder.cc:848
    https://github.com/facebook/rocksdb/issues/2 0x7ffb311771a2 in rocksdb::BlockBasedTableBuilder::WriteBlock(rocksdb::BlockBuilder*, rocksdb::BlockHandle*, bool) internal_repo_rocksdb/repo/table/block_based/block_based_table_builder.cc:832

This is caused by not returning immediately after CompressAndVerifyBlock call
in WriteBlock when rep_->status == kBuffered.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6633

Test Plan: Run all existing test.

Reviewed By: anand1976

Differential Revision: D20808366

fbshipit-source-id: 09f24b7c0fbaf4c7a8fc48cac61fa6fcb9b85811
2020-04-02 11:57:05 -07:00
..
binary_search_index_reader.cc
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
binary_search_index_reader.h
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
block_based_filter_block_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based_filter_block.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based_filter_block.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based_table_builder.cc
Fix a division by zero after #6262 (#6633)
2020-04-02 11:57:05 -07:00
block_based_table_builder.h
Add pipelined & parallel compression optimization (#6262)
2020-04-01 16:40:18 -07:00
block_based_table_factory.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based_table_factory.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_based_table_iterator.cc
De-template block based table iterator (#6531)
2020-03-16 12:20:50 -07:00
block_based_table_iterator.h
De-template block based table iterator (#6531)
2020-03-16 12:20:50 -07:00
block_based_table_reader_impl.h
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
block_based_table_reader.cc
Revert the recent cache deleter change (#6620)
2020-03-31 16:11:06 -07:00
block_based_table_reader.h
De-template block based table iterator (#6531)
2020-03-16 12:20:50 -07:00
block_builder.cc
Add pipelined & parallel compression optimization (#6262)
2020-04-01 16:40:18 -07:00
block_builder.h
Add pipelined & parallel compression optimization (#6262)
2020-04-01 16:40:18 -07:00
block_prefetcher.cc
De-template block based table iterator (#6531)
2020-03-16 12:20:50 -07:00
block_prefetcher.h
De-template block based table iterator (#6531)
2020-03-16 12:20:50 -07:00
block_prefix_index.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_prefix_index.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block_test.cc
Fix range deletion tombstone ingestion with global seqno (#6429)
2020-02-25 15:31:48 -08:00
block_type.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
block.cc
fix some spelling typos (#6464)
2020-02-28 14:14:03 -08:00
block.h
Fix range deletion tombstone ingestion with global seqno (#6429)
2020-02-25 15:31:48 -08:00
cachable_entry.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
data_block_footer.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
data_block_footer.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
data_block_hash_index_test.cc
Fix range deletion tombstone ingestion with global seqno (#6429)
2020-02-25 15:31:48 -08:00
data_block_hash_index.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
data_block_hash_index.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
filter_block_reader_common.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
filter_block_reader_common.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
filter_block.h
Fix iterator reading filter block despite read_tier == kBlockCacheTier (#6562)
2020-03-26 15:21:26 -07:00
filter_policy_internal.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
filter_policy.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
flush_block_policy.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
flush_block_policy.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
full_filter_block_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
full_filter_block.cc
Fix iterator reading filter block despite read_tier == kBlockCacheTier (#6562)
2020-03-26 15:21:26 -07:00
full_filter_block.h
Fix iterator reading filter block despite read_tier == kBlockCacheTier (#6562)
2020-03-26 15:21:26 -07:00
hash_index_reader.cc
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
hash_index_reader.h
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
index_builder.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
index_builder.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
index_reader_common.cc
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
index_reader_common.h
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
mock_block_based_table.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
parsed_full_filter_block.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
parsed_full_filter_block.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
partitioned_filter_block_test.cc
Fix range deletion tombstone ingestion with global seqno (#6429)
2020-02-25 15:31:48 -08:00
partitioned_filter_block.cc
Fix range deletion tombstone ingestion with global seqno (#6429)
2020-02-25 15:31:48 -08:00
partitioned_filter_block.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
partitioned_index_iterator.cc
Fix regression bug in partitioned index reseek caused by #6531 (#6551)
2020-03-17 12:33:10 -07:00
partitioned_index_iterator.h
Fix compiler warning treated as error (#6547)
2020-03-17 09:59:28 -07:00
partitioned_index_reader.cc
Revert the recent cache deleter change (#6620)
2020-03-31 16:11:06 -07:00
partitioned_index_reader.h
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
reader_common.cc
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
reader_common.h
Divide block_based_table_reader.cc (#6527)
2020-03-12 21:41:50 -07:00
uncompression_dict_reader.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
uncompression_dict_reader.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00