a52e4d7d02
Summary:
The main PHP code churn is caused by extracting the common code from `FacebookArcanistConfiguration.php` and `FacebookOldArcanistConfiguration.php` into `RocksDBCommonDeterminator.php`. This is necessary both for reducing the duplication of code and making sure that we can execute the common core logic separately from continuous runs.
The main logic in `RocksDBCommonDeterminator.php` remains quite the same with the exception of some things:
- Adding separation between the cases when a diff is submitted //vs.// when the code is triggered from a continuous run. There are certain actions which we should do in a case of diff only.
- Adding reporting - now the person who authored the diff will receive e-mail notifications if any of the jobs have failed.
- Enabling assertions and making sure that we'll terminate on failure. This is an internal code used by competent engineers, so instead of `if (!condition) { echo "Something"; exit(1); }` for every invariant I think that `assert(condition)` provides better readability with the same behavior. Especially taking into account that we're talking about things which shouldn't ever happen.
Enabling this entire process will be triggered internally and will be a subject of a separate code review. We should discuss the details of triggering continuous RocksDB build and tests on that diff.
Test Plan:
- Make sure that `[p]arc diff` scenario isn't broken by verifying that tests validating this diff will pass.
- Private testing of triggering the continuous build script.
- Once the changes will land then author an internal job which will use the script and verify its validity.
Reviewers: sdong, yhchiang, kradhakrishnan
Reviewed By: kradhakrishnan
Subscribers: andrewkr, dhruba
Differential Revision: https://reviews.facebook.net/D59811
37 lines
1.3 KiB
PHP
37 lines
1.3 KiB
PHP
<?php
|
|
// Copyright 2004-present Facebook. All Rights Reserved.
|
|
// This source code is licensed under the BSD-style license found in the
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
require('RocksDBCommonHelper.php');
|
|
|
|
define("DIFF_COMMAND", "diff");
|
|
|
|
class FacebookArcanistConfiguration extends ArcanistConfiguration {
|
|
|
|
public function didRunWorkflow($command,
|
|
ArcanistBaseWorkflow $workflow,
|
|
$error_code) {
|
|
// Default options don't terminate on failure, but that's what we want. In
|
|
// the current case we use assertions intentionally as "terminate on failure
|
|
// invariants".
|
|
assert_options(ASSERT_BAIL, true);
|
|
|
|
assert($workflow);
|
|
assert(strlen($command) > 0);
|
|
|
|
if ($command == DIFF_COMMAND && !$workflow->isRawDiffSource()) {
|
|
$diffID = $workflow->getDiffId();
|
|
|
|
// When submitting a diff this code path gets executed multiple times in
|
|
// a row. We only care about the case when ID for the diff is provided
|
|
// because that's what we need to apply the diff and trigger the tests.
|
|
if (strlen($diffID) > 0) {
|
|
assert(is_numeric($diffID));
|
|
startTestsInSandcastle(true /* $applyDiff */, $workflow, $diffID);
|
|
}
|
|
}
|
|
}
|
|
}
|