26f5dd9a5a
Summary: This diff addresses task #4296714 and rethinks how users provide us with TablePropertiesCollectors as part of Options. Here's description of task #4296714: I'm debugging #4295529 and noticed that our count of user properties kDeletedKeys is wrong. We're sharing one single InternalKeyPropertiesCollector with all Table Builders. In LOG Files, we're outputting number of kDeletedKeys as connected with a single table, while it's actually the total count of deleted keys since creation of the DB. For example, this table has 3155 entries and 1391828 deleted keys. The problem with current approach that we call methods on a single TablePropertiesCollector for all the tables we create. Even worse, we could do it from multiple threads at the same time and TablePropertiesCollector has no way of knowing which table we're calling it for. Good part: Looks like nobody inside Facebook is using Options::table_properties_collectors. This means we should be able to painfully change the API. In this change, I introduce TablePropertiesCollectorFactory. For every table we create, we call `CreateTablePropertiesCollector`, which creates a TablePropertiesCollector for a single table. We then use it sequentially from a single thread, which means it doesn't have to be thread-safe. Test Plan: Added a test in table_properties_collector_test that fails on master (build two tables, assert that kDeletedKeys count is correct for the second one). Also, all other tests Reviewers: sdong, dhruba, haobo, kailiu Reviewed By: kailiu CC: leveldb Differential Revision: https://reviews.facebook.net/D18579
212 lines
6.1 KiB
C++
212 lines
6.1 KiB
C++
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
#include "table/plain_table_builder.h"
|
|
|
|
#include <assert.h>
|
|
#include <map>
|
|
|
|
#include "rocksdb/comparator.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/filter_policy.h"
|
|
#include "rocksdb/options.h"
|
|
#include "table/plain_table_factory.h"
|
|
#include "db/dbformat.h"
|
|
#include "table/block_builder.h"
|
|
#include "table/filter_block.h"
|
|
#include "table/format.h"
|
|
#include "table/meta_blocks.h"
|
|
#include "util/coding.h"
|
|
#include "util/crc32c.h"
|
|
#include "util/stop_watch.h"
|
|
|
|
namespace rocksdb {
|
|
|
|
namespace {
|
|
|
|
// a utility that helps writing block content to the file
|
|
// @offset will advance if @block_contents was successfully written.
|
|
// @block_handle the block handle this particular block.
|
|
Status WriteBlock(
|
|
const Slice& block_contents,
|
|
WritableFile* file,
|
|
uint64_t* offset,
|
|
BlockHandle* block_handle) {
|
|
block_handle->set_offset(*offset);
|
|
block_handle->set_size(block_contents.size());
|
|
Status s = file->Append(block_contents);
|
|
|
|
if (s.ok()) {
|
|
*offset += block_contents.size();
|
|
}
|
|
return s;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
// kPlainTableMagicNumber was picked by running
|
|
// echo rocksdb.table.plain | sha1sum
|
|
// and taking the leading 64 bits.
|
|
extern const uint64_t kPlainTableMagicNumber = 0x8242229663bf9564ull;
|
|
extern const uint64_t kLegacyPlainTableMagicNumber = 0x4f3418eb7a8f13b8ull;
|
|
|
|
PlainTableBuilder::PlainTableBuilder(const Options& options,
|
|
WritableFile* file,
|
|
uint32_t user_key_len) :
|
|
options_(options), file_(file), user_key_len_(user_key_len) {
|
|
properties_.fixed_key_len = user_key_len;
|
|
|
|
// for plain table, we put all the data in a big chuck.
|
|
properties_.num_data_blocks = 1;
|
|
// emphasize that currently plain table doesn't have persistent index or
|
|
// filter block.
|
|
properties_.index_size = 0;
|
|
properties_.filter_size = 0;
|
|
properties_.format_version = 0;
|
|
|
|
for (auto& collector_factories :
|
|
options.table_properties_collector_factories) {
|
|
table_properties_collectors_.emplace_back(
|
|
collector_factories->CreateTablePropertiesCollector());
|
|
}
|
|
}
|
|
|
|
PlainTableBuilder::~PlainTableBuilder() {
|
|
}
|
|
|
|
void PlainTableBuilder::Add(const Slice& key, const Slice& value) {
|
|
size_t user_key_size = key.size() - 8;
|
|
assert(user_key_len_ == 0 || user_key_size == user_key_len_);
|
|
|
|
if (!IsFixedLength()) {
|
|
// Write key length
|
|
char key_size_buf[5]; // tmp buffer for key size as varint32
|
|
char* ptr = EncodeVarint32(key_size_buf, user_key_size);
|
|
assert(ptr <= key_size_buf + sizeof(key_size_buf));
|
|
auto len = ptr - key_size_buf;
|
|
file_->Append(Slice(key_size_buf, len));
|
|
offset_ += len;
|
|
}
|
|
|
|
// Write key
|
|
ParsedInternalKey parsed_key;
|
|
if (!ParseInternalKey(key, &parsed_key)) {
|
|
status_ = Status::Corruption(Slice());
|
|
return;
|
|
}
|
|
// For value size as varint32 (up to 5 bytes).
|
|
// If the row is of value type with seqId 0, flush the special flag together
|
|
// in this buffer to safe one file append call, which takes 1 byte.
|
|
char value_size_buf[6];
|
|
size_t value_size_buf_size = 0;
|
|
if (parsed_key.sequence == 0 && parsed_key.type == kTypeValue) {
|
|
file_->Append(Slice(key.data(), user_key_size));
|
|
offset_ += user_key_size;
|
|
value_size_buf[0] = PlainTableFactory::kValueTypeSeqId0;
|
|
value_size_buf_size = 1;
|
|
} else {
|
|
file_->Append(key);
|
|
offset_ += key.size();
|
|
}
|
|
|
|
// Write value length
|
|
int value_size = value.size();
|
|
char* end_ptr =
|
|
EncodeVarint32(value_size_buf + value_size_buf_size, value_size);
|
|
assert(end_ptr <= value_size_buf + sizeof(value_size_buf));
|
|
value_size_buf_size = end_ptr - value_size_buf;
|
|
file_->Append(Slice(value_size_buf, value_size_buf_size));
|
|
|
|
// Write value
|
|
file_->Append(value);
|
|
offset_ += value_size + value_size_buf_size;
|
|
|
|
properties_.num_entries++;
|
|
properties_.raw_key_size += key.size();
|
|
properties_.raw_value_size += value.size();
|
|
|
|
// notify property collectors
|
|
NotifyCollectTableCollectorsOnAdd(key, value, table_properties_collectors_,
|
|
options_.info_log.get());
|
|
}
|
|
|
|
Status PlainTableBuilder::status() const { return status_; }
|
|
|
|
Status PlainTableBuilder::Finish() {
|
|
assert(!closed_);
|
|
closed_ = true;
|
|
|
|
properties_.data_size = offset_;
|
|
|
|
// Write the following blocks
|
|
// 1. [meta block: properties]
|
|
// 2. [metaindex block]
|
|
// 3. [footer]
|
|
MetaIndexBuilder meta_index_builer;
|
|
|
|
PropertyBlockBuilder property_block_builder;
|
|
// -- Add basic properties
|
|
property_block_builder.AddTableProperty(properties_);
|
|
|
|
// -- Add user collected properties
|
|
NotifyCollectTableCollectorsOnFinish(table_properties_collectors_,
|
|
options_.info_log.get(),
|
|
&property_block_builder);
|
|
|
|
// -- Write property block
|
|
BlockHandle property_block_handle;
|
|
auto s = WriteBlock(
|
|
property_block_builder.Finish(),
|
|
file_,
|
|
&offset_,
|
|
&property_block_handle
|
|
);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
meta_index_builer.Add(kPropertiesBlock, property_block_handle);
|
|
|
|
// -- write metaindex block
|
|
BlockHandle metaindex_block_handle;
|
|
s = WriteBlock(
|
|
meta_index_builer.Finish(),
|
|
file_,
|
|
&offset_,
|
|
&metaindex_block_handle
|
|
);
|
|
if (!s.ok()) {
|
|
return s;
|
|
}
|
|
|
|
// Write Footer
|
|
// no need to write out new footer if we're using default checksum
|
|
Footer footer(kLegacyPlainTableMagicNumber);
|
|
footer.set_metaindex_handle(metaindex_block_handle);
|
|
footer.set_index_handle(BlockHandle::NullBlockHandle());
|
|
std::string footer_encoding;
|
|
footer.EncodeTo(&footer_encoding);
|
|
s = file_->Append(footer_encoding);
|
|
if (s.ok()) {
|
|
offset_ += footer_encoding.size();
|
|
}
|
|
|
|
return s;
|
|
}
|
|
|
|
void PlainTableBuilder::Abandon() {
|
|
closed_ = true;
|
|
}
|
|
|
|
uint64_t PlainTableBuilder::NumEntries() const {
|
|
return properties_.num_entries;
|
|
}
|
|
|
|
uint64_t PlainTableBuilder::FileSize() const {
|
|
return offset_;
|
|
}
|
|
|
|
} // namespace rocksdb
|
|
#endif // ROCKSDB_LITE
|