andreacavalli/rocksdb
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
rocksdb/monitoring
History
sdong 7f08a8503f Remove IOSTATS_ADD_IF_POSITIVE() (#8984) 
Summary:
IOSTATS_ADD_IF_POSITIVE() doesn't seem to a macro that aims to improve performance but does the opposite. The counter to add is almost always positive so the if is just a waste. Furthermore, adding to a thread local variable seemse to be much cheaper than an if condition if branch prediction has a possibility to be wrong. Remove the macro.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8984

Test Plan: See CI completes.

Reviewed By: anand1976

Differential Revision: D31348163

fbshipit-source-id: 30af6d45e1aa8bbc09b2c046206cce6f67f4777a
2021-10-01 14:43:00 -07:00
..
file_read_sample.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
histogram_test.cc
Make SystemClock into a Customizable Class (#8636)
2021-09-21 09:23:48 -07:00
histogram_windowing.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
histogram_windowing.h
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
histogram.cc
Fix FilterBench when RTTI=0 (#6732)
2020-04-29 13:09:23 -07:00
histogram.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
in_memory_stats_history.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
in_memory_stats_history.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
instrumented_mutex.cc
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
instrumented_mutex.h
Don't hold DB mutex for block cache entry stat scans (#8538)
2021-07-16 14:13:08 -07:00
iostats_context_imp.h
Remove IOSTATS_ADD_IF_POSITIVE() (#8984)
2021-10-01 14:43:00 -07:00
iostats_context_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
iostats_context.cc
Disable IOStatsContext/PerfContext if no thread local (#8117)
2021-04-13 07:56:59 -07:00
perf_context_imp.h
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)
2021-03-15 04:34:11 -07:00
perf_context.cc
Add a PerfContext counter for secondary cache hits (#8685)
2021-08-20 15:17:30 -07:00
perf_level_imp.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
perf_level.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
perf_step_timer.h
make PerfStepTimer struct smaller by reordering members (#7931)
2021-03-08 21:33:15 -08:00
persistent_stats_history.cc
Remove unused includes (#7604)
2020-10-28 23:22:27 -07:00
persistent_stats_history.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
statistics_test.cc
Added a default Name method to Statistics (#8918)
2021-09-17 07:25:43 -07:00
statistics.cc
Add remote compaction read/write bytes statistics (#8939)
2021-09-28 14:00:37 -07:00
statistics.h
Make Statistics a Customizable Class (#8637)
2021-09-10 09:47:39 -07:00
stats_history_test.cc
Fix a minor issue with initializing the test path (#8555)
2021-07-23 08:38:45 -07:00
thread_status_impl.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_status_updater_debug.cc
Replace reinterpret_cast with static_cast_with_check (#7067)
2020-07-02 19:25:41 -07:00
thread_status_updater.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
thread_status_updater.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00
thread_status_util_debug.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
thread_status_util.cc
Add a SystemClock class to capture the time functions of an Env (#7858)
2021-01-25 22:09:11 -08:00
thread_status_util.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
2020-02-20 12:09:57 -08:00