Peter Dillinger 85becd94c1 Refactor: use TableBuilderOptions to reduce parameter lists (#8240) ... Summary: Greatly reduced the not-quite-copy-paste giant parameter lists of rocksdb::NewTableBuilder, rocksdb::BuildTable, BlockBasedTableBuilder::Rep ctor, and BlockBasedTableBuilder ctor. Moved weird separate parameter `uint32_t column_family_id` of TableFactory::NewTableBuilder into TableBuilderOptions. Re-ordered parameters to TableBuilderOptions ctor, so that `uint64_t target_file_size` is not randomly placed between uint64_t timestamps (was easy to mix up). Replaced a couple of fields of BlockBasedTableBuilder::Rep with a FilterBuildingContext. The motivation for this change is making it easier to pass along more data into new fields in FilterBuildingContext (follow-up PR). Pull Request resolved: https://github.com/facebook/rocksdb/pull/8240 Test Plan: ASAN make check Reviewed By: mrambacher Differential Revision: D28075891 Pulled By: pdillinger fbshipit-source-id: fddb3dbb8260a0e8bdcbb51b877ebabf9a690d4f		2021-04-29 07:00:50 -07:00
..
adaptive	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
block_based	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
cuckoo	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
plain	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
block_fetcher_test.cc	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
block_fetcher.cc	Rename variables in ImmutableCFOptions to avoid conflicts with ImmutableDBOptions (#8227)	2021-04-26 12:43:45 -07:00
block_fetcher.h	Replace Status with IOStatus for block fetcher IO function (#8130)	2021-04-01 10:07:55 -07:00
cleanable_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
format.cc	Rename variables in ImmutableCFOptions to avoid conflicts with ImmutableDBOptions (#8227)	2021-04-26 12:43:45 -07:00
format.h	Add a host location property to TableProperties (#7479)	2020-10-19 11:38:48 -07:00
get_context.cc	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
get_context.h	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	2021-03-15 04:34:11 -07:00
internal_iterator.h	Clean up InternalIterator upper bound logic a little bit (#7200)	2020-08-05 10:44:57 -07:00
iter_heap.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
iterator_wrapper.h	Redesign block cache pinning API (#7520)	2020-10-11 14:58:24 -07:00
iterator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
merger_test.cc	More Makefile Cleanup (#7097)	2020-07-09 14:35:17 -07:00
merging_iterator.cc	Add some simulator cache and block tracer tests to ASSERT_STATUS_CHECKED (#7305)	2020-08-24 16:43:31 -07:00
merging_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
meta_blocks.cc	Rename variables in ImmutableCFOptions to avoid conflicts with ImmutableDBOptions (#8227)	2021-04-26 12:43:45 -07:00
meta_blocks.h	Make types of Immutable/Mutable Options fields match that of the underlying Option (#8176)	2021-04-22 20:43:54 -07:00
mock_table.cc	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
mock_table.h	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
multiget_context.h	Add initial blob support to batched MultiGet (#7766)	2020-12-14 13:48:22 -08:00
persistent_cache_helper.cc	Add more tests to ASSERT_STATUS_CHECKED (#7367)	2020-09-16 15:48:07 -07:00
persistent_cache_helper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
persistent_cache_options.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
scoped_arena_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
sst_file_dumper.cc	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
sst_file_dumper.h	Limit buffering for collecting samples for compression dictionary (#7970)	2021-02-19 14:09:54 -08:00
sst_file_reader_test.cc	Add a host location property to TableProperties (#7479)	2020-10-19 11:38:48 -07:00
sst_file_reader.cc	Remove Legacy and Custom FileWrapper classes from header files (#7851)	2021-01-28 22:10:32 -08:00
sst_file_writer_collectors.h	Apply sample_for_compression to all block-based tables (#8105)	2021-03-25 15:00:45 -07:00
sst_file_writer.cc	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
table_builder.h	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
table_factory.cc	Create a Customizable class to load classes and configurations (#6590)	2020-11-11 15:10:41 -08:00
table_properties_internal.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_properties.cc	Add sample_for_compression results to table properties (#8139)	2021-03-31 18:21:50 -07:00
table_reader_bench.cc	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
table_reader_caller.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00
table_reader.h	dedup ReadOptions in iterator hierarchy (#7210)	2020-08-03 15:23:04 -07:00
table_test.cc	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	2021-04-29 07:00:50 -07:00
two_level_iterator.cc	Redesign block cache pinning API (#7520)	2020-10-11 14:58:24 -07:00
two_level_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	2020-02-20 12:09:57 -08:00