78cb6b6112
Summary:
In Java API, `SstFileWriter.put/merge/delete` takes `Slice` type of key and value, which is a Java wrapper object around C++ Slice object. The Slice object inherited [ `finalize`](3c327ac2d0/java/src/main/java/org/rocksdb/AbstractNativeReference.java (L69)) method, which [added huge overhead](https://softwareengineering.stackexchange.com/questions/288715/is-overriding-object-finalize-really-bad/288753#288753) to JVM while creating new SstFile.
To address this issue, this PR overload the merge method to take Java byte array instead of the Slice object, and added unit test for it.
We also benchmark these two different merge function, where we could see GC Stall reduced from 50% to 1%, and the throughput increased from 50MB to 200MB.
Closes https://github.com/facebook/rocksdb/pull/2746
Reviewed By: sagar0
Differential Revision: D5653145
Pulled By: scv119
fbshipit-source-id: b55ea58554b573d0b1c6f6170f8d9223811bc4f5
249 lines
8.2 KiB
C++
249 lines
8.2 KiB
C++
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
//
|
|
// This file implements the "bridge" between Java and C++ and enables
|
|
// calling C++ rocksdb::SstFileWriter methods
|
|
// from Java side.
|
|
|
|
#include <jni.h>
|
|
#include <string>
|
|
|
|
#include "include/org_rocksdb_SstFileWriter.h"
|
|
#include "rocksdb/comparator.h"
|
|
#include "rocksdb/env.h"
|
|
#include "rocksdb/options.h"
|
|
#include "rocksdb/sst_file_writer.h"
|
|
#include "rocksjni/portal.h"
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: newSstFileWriter
|
|
* Signature: (JJJ)J
|
|
*/
|
|
jlong Java_org_rocksdb_SstFileWriter_newSstFileWriter__JJJ(JNIEnv *env, jclass jcls,
|
|
jlong jenvoptions,
|
|
jlong joptions,
|
|
jlong jcomparator) {
|
|
auto *env_options =
|
|
reinterpret_cast<const rocksdb::EnvOptions *>(jenvoptions);
|
|
auto *options = reinterpret_cast<const rocksdb::Options *>(joptions);
|
|
auto *comparator = reinterpret_cast<const rocksdb::Comparator *>(jcomparator);
|
|
rocksdb::SstFileWriter *sst_file_writer =
|
|
new rocksdb::SstFileWriter(*env_options, *options, comparator);
|
|
return reinterpret_cast<jlong>(sst_file_writer);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: newSstFileWriter
|
|
* Signature: (JJ)J
|
|
*/
|
|
jlong Java_org_rocksdb_SstFileWriter_newSstFileWriter__JJ(JNIEnv *env, jclass jcls,
|
|
jlong jenvoptions,
|
|
jlong joptions) {
|
|
auto *env_options =
|
|
reinterpret_cast<const rocksdb::EnvOptions *>(jenvoptions);
|
|
auto *options = reinterpret_cast<const rocksdb::Options *>(joptions);
|
|
rocksdb::SstFileWriter *sst_file_writer =
|
|
new rocksdb::SstFileWriter(*env_options, *options);
|
|
return reinterpret_cast<jlong>(sst_file_writer);
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: open
|
|
* Signature: (JLjava/lang/String;)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_open(JNIEnv *env, jobject jobj,
|
|
jlong jhandle, jstring jfile_path) {
|
|
const char *file_path = env->GetStringUTFChars(jfile_path, nullptr);
|
|
if(file_path == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return;
|
|
}
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Open(file_path);
|
|
env->ReleaseStringUTFChars(jfile_path, file_path);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: put
|
|
* Signature: (JJJ)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_put__JJJ(JNIEnv *env, jobject jobj,
|
|
jlong jhandle, jlong jkey_handle,
|
|
jlong jvalue_handle) {
|
|
auto *key_slice = reinterpret_cast<rocksdb::Slice *>(jkey_handle);
|
|
auto *value_slice = reinterpret_cast<rocksdb::Slice *>(jvalue_handle);
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Put(*key_slice,
|
|
*value_slice);
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: put
|
|
* Signature: (JJJ)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_put__J_3B_3B(JNIEnv *env, jobject jobj,
|
|
jlong jhandle, jbyteArray jkey,
|
|
jbyteArray jval) {
|
|
jbyte* key = env->GetByteArrayElements(jkey, nullptr);
|
|
if(key == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return;
|
|
}
|
|
rocksdb::Slice key_slice(
|
|
reinterpret_cast<char*>(key), env->GetArrayLength(jkey));
|
|
|
|
jbyte* value = env->GetByteArrayElements(jval, nullptr);
|
|
if(value == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
env->ReleaseByteArrayElements(jkey, key, JNI_ABORT);
|
|
return;
|
|
}
|
|
rocksdb::Slice value_slice(
|
|
reinterpret_cast<char*>(value), env->GetArrayLength(jval));
|
|
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Put(key_slice,
|
|
value_slice);
|
|
|
|
env->ReleaseByteArrayElements(jkey, key, JNI_ABORT);
|
|
env->ReleaseByteArrayElements(jval, value, JNI_ABORT);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: merge
|
|
* Signature: (JJJ)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_merge__JJJ(JNIEnv *env, jobject jobj,
|
|
jlong jhandle, jlong jkey_handle,
|
|
jlong jvalue_handle) {
|
|
auto *key_slice = reinterpret_cast<rocksdb::Slice *>(jkey_handle);
|
|
auto *value_slice = reinterpret_cast<rocksdb::Slice *>(jvalue_handle);
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Merge(*key_slice,
|
|
*value_slice);
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: merge
|
|
* Signature: (J[B[B)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_merge__J_3B_3B(JNIEnv *env, jobject jobj,
|
|
jlong jhandle, jbyteArray jkey,
|
|
jbyteArray jval) {
|
|
|
|
jbyte* key = env->GetByteArrayElements(jkey, nullptr);
|
|
if(key == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return;
|
|
}
|
|
rocksdb::Slice key_slice(
|
|
reinterpret_cast<char*>(key), env->GetArrayLength(jkey));
|
|
|
|
jbyte* value = env->GetByteArrayElements(jval, nullptr);
|
|
if(value == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
env->ReleaseByteArrayElements(jkey, key, JNI_ABORT);
|
|
return;
|
|
}
|
|
rocksdb::Slice value_slice(
|
|
reinterpret_cast<char*>(value), env->GetArrayLength(jval));
|
|
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Merge(key_slice,
|
|
value_slice);
|
|
|
|
env->ReleaseByteArrayElements(jkey, key, JNI_ABORT);
|
|
env->ReleaseByteArrayElements(jval, value, JNI_ABORT);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: delete
|
|
* Signature: (JJJ)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_delete__J_3B(JNIEnv *env, jobject jobj,
|
|
jlong jhandle, jbyteArray jkey) {
|
|
jbyte* key = env->GetByteArrayElements(jkey, nullptr);
|
|
if(key == nullptr) {
|
|
// exception thrown: OutOfMemoryError
|
|
return;
|
|
}
|
|
rocksdb::Slice key_slice(
|
|
reinterpret_cast<char*>(key), env->GetArrayLength(jkey));
|
|
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Delete(key_slice);
|
|
|
|
env->ReleaseByteArrayElements(jkey, key, JNI_ABORT);
|
|
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: delete
|
|
* Signature: (JJJ)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_delete__JJ(JNIEnv *env, jobject jobj,
|
|
jlong jhandle, jlong jkey_handle) {
|
|
auto *key_slice = reinterpret_cast<rocksdb::Slice *>(jkey_handle);
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Delete(*key_slice);
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: finish
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_finish(JNIEnv *env, jobject jobj,
|
|
jlong jhandle) {
|
|
rocksdb::Status s =
|
|
reinterpret_cast<rocksdb::SstFileWriter *>(jhandle)->Finish();
|
|
if (!s.ok()) {
|
|
rocksdb::RocksDBExceptionJni::ThrowNew(env, s);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Class: org_rocksdb_SstFileWriter
|
|
* Method: disposeInternal
|
|
* Signature: (J)V
|
|
*/
|
|
void Java_org_rocksdb_SstFileWriter_disposeInternal(JNIEnv *env, jobject jobj,
|
|
jlong jhandle) {
|
|
delete reinterpret_cast<rocksdb::SstFileWriter *>(jhandle);
|
|
}
|