3ffb3baa0b
Summary: New classes FileStorageInfo and LiveFileStorageInfo and 'experimental' function DB::GetLiveFilesStorageInfo, which is intended to largely replace several fragmented DB functions needed to create checkpoints and backups. This function is now used to create checkpoints and backups, because it fixes many (probably not all) of the prior complexities of checkpoint not having atomic access to DB metadata. This also ensures strong functional test coverage of the new API. Specifically, much of the old CheckpointImpl::CreateCustomCheckpoint has been migrated to and updated in DBImpl::GetLiveFilesStorageInfo, with the former now calling the latter. Also, the class FileStorageInfo in metadata.h compatibly replaces BackupFileInfo and serves as a new base class for SstFileMetaData. Some old fields of SstFileMetaData are still provided (for now) but deprecated. Although FileStorageInfo::directory is accurate when using db_paths and/or cf_paths, these have never been supported by Checkpoint nor BackupEngine and still are not. This change does now detect these cases and return NotSupported when appropriate. (More work needed for support.) Somehow this change broke ProgressCallbackDuringBackup, but the progress_callback logic was dubious to begin with because it would call the callback based on copy buffer size, not size actually copied. Logic and test updated to track size actually copied per-thread. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8968 Test Plan: tests updated. DB::GetLiveFilesStorageInfo mostly tested by use in CheckpointImpl. DBTest.SnapshotFiles updated to also test GetLiveFilesStorageInfo, including reading the data after DB close. Added CheckpointTest.CheckpointWithDbPath (NotSupported). Reviewed By: siying Differential Revision: D31242045 Pulled By: pdillinger fbshipit-source-id: b183d1ce9799e220daaefd6b3b5365d98de676c0
52 lines
1.5 KiB
C++
52 lines
1.5 KiB
C++
// Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
#pragma once
|
|
|
|
#include <assert.h>
|
|
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
#include <vector>
|
|
|
|
#include "rocksdb/rocksdb_namespace.h"
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
// This is a data structure specifically designed as a "Set" for a
|
|
// pretty small scale of Enum structure. For now, it can support up
|
|
// to 64 element, and it is expandable in the future.
|
|
template <typename ENUM_TYPE, ENUM_TYPE MAX_VALUE>
|
|
class SmallEnumSet {
|
|
public:
|
|
SmallEnumSet() : state_(0) {}
|
|
|
|
~SmallEnumSet() {}
|
|
|
|
// Return true if the input enum is included in the "Set" (i.e., changes the
|
|
// internal scalar state successfully), otherwise, it will return false.
|
|
bool Add(const ENUM_TYPE value) {
|
|
static_assert(MAX_VALUE <= 63, "Size currently limited to 64");
|
|
assert(value >= 0 && value <= MAX_VALUE);
|
|
uint64_t old_state = state_;
|
|
uint64_t tmp = 1;
|
|
state_ |= (tmp << value);
|
|
return old_state != state_;
|
|
}
|
|
|
|
// Return true if the input enum is contained in the "Set".
|
|
bool Contains(const ENUM_TYPE value) {
|
|
static_assert(MAX_VALUE <= 63, "Size currently limited to 64");
|
|
assert(value >= 0 && value <= MAX_VALUE);
|
|
uint64_t tmp = 1;
|
|
return state_ & (tmp << value);
|
|
}
|
|
|
|
private:
|
|
uint64_t state_;
|
|
};
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|